Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1839959/?format=api
{ "id": 1839959, "url": "http://patchwork.ozlabs.org/api/patches/1839959/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926224107.2951144-3-jonah.palmer@oracle.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230926224107.2951144-3-jonah.palmer@oracle.com>", "list_archive_url": null, "date": "2023-09-26T22:41:06", "name": "[RESEND,v5,2/3] qmp: update virtio feature maps, vhost-user-gpio introspection", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "32390bac0006ab53d6c2c1e418a4a802f3a06e08", "submitter": { "id": 81365, "url": "http://patchwork.ozlabs.org/api/people/81365/?format=api", "name": "Jonah Palmer", "email": "jonah.palmer@oracle.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926224107.2951144-3-jonah.palmer@oracle.com/mbox/", "series": [ { "id": 375011, "url": "http://patchwork.ozlabs.org/api/series/375011/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=375011", "date": "2023-09-26T22:41:04", "name": "qmp, vhost-user: Remove virtio_list & update virtio introspection", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/375011/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1839959/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1839959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256\n header.s=corp-2023-03-30 header.b=k29GBHOR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwFB04lm5z1yqW\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 27 Sep 2023 08:42:31 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1qlGkB-0005yB-3L; Tue, 26 Sep 2023 18:41:27 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jonah.palmer@oracle.com>)\n id 1qlGk9-0005xh-Ix\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 18:41:25 -0400", "from mx0a-00069f02.pphosted.com ([205.220.165.32])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jonah.palmer@oracle.com>)\n id 1qlGk7-0005UG-M4\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 18:41:25 -0400", "from pps.filterd (m0246627.ppops.net [127.0.0.1])\n by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 38QLTWOP010430; Tue, 26 Sep 2023 22:41:17 GMT", "from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com\n (phxpaimrmta02.appoci.oracle.com [147.154.114.232])\n by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t9pm285vy-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 26 Sep 2023 22:41:17 +0000", "from pps.filterd\n (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])\n by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19)\n with ESMTP id 38QMHK5r021229; Tue, 26 Sep 2023 22:41:17 GMT", "from pps.reinject (localhost [127.0.0.1])\n by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id\n 3t9pf74c93-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 26 Sep 2023 22:41:16 +0000", "from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com\n (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 38QMfBNp022981;\n Tue, 26 Sep 2023 22:41:16 GMT", "from jonah-ol8.us.oracle.com (dhcp-10-65-186-167.vpn.oracle.com\n [10.65.186.167])\n by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id\n 3t9pf74c6n-3; Tue, 26 Sep 2023 22:41:16 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=corp-2023-03-30;\n bh=2fS3cAZmVkJQ0vfSqem/x2WawjA8VFSLi6VRn/xD78o=;\n b=k29GBHOR3CP0v0ELsCBwpOX/AgbjH01XDZ5vkruJL5tBuwDIj0yKgbrQQ9cgAEzF/mnQ\n iQQs8v9jFLBox4bMOkfDJb42FyMUWVW38jZ8tAZDJSN0uR3hY/dns5tskaAJSh+u2wMd\n Z0MmIpcFjid0bXiszYciOMkcnUAEB0hi848UMMIWF7r+x94dYpxmbqiaaDajLPi+ZeMx\n 1EOmUyvNCK7HS8n2JQJQ0p9C3A0g4X/yiJIyNXe4TO0i4Y1mhk0sF1tgnSch+LJRLzFG\n qvF7kxx5LQtacPHyovfcFI4WhpTRsGxOoVhJowMFgs8jqKVUDE74WQm/enuATRNVRHs8 Pw==", "From": "Jonah Palmer <jonah.palmer@oracle.com>", "To": "qemu-devel@nongnu.org", "Cc": "philmd@linaro.org, laurent@vivier.eu, mst@redhat.com,\n boris.ostrovsky@oracle.com, alex.bennee@linaro.org,\n viresh.kumar@linaro.org, armbru@redhat.com, pbonzini@redhat.com,\n berrange@redhat.com, eduardo@habkost.net, jonah.palmer@oracle.com", "Subject": "[PATCH RESEND v5 2/3] qmp: update virtio feature maps,\n vhost-user-gpio introspection", "Date": "Tue, 26 Sep 2023 18:41:06 -0400", "Message-Id": "<20230926224107.2951144-3-jonah.palmer@oracle.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20230926224107.2951144-1-jonah.palmer@oracle.com>", "References": "<20230926224107.2951144-1-jonah.palmer@oracle.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-09-26_15,2023-09-26_01,2023-05-22_02", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 phishscore=0\n bulkscore=0 mlxscore=0\n adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 spamscore=0\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000\n definitions=main-2309260194", "X-Proofpoint-ORIG-GUID": "N2_shSICayPqzcMNlzJq8K5LfewDFRDB", "X-Proofpoint-GUID": "N2_shSICayPqzcMNlzJq8K5LfewDFRDB", "Received-SPF": "pass client-ip=205.220.165.32;\n envelope-from=jonah.palmer@oracle.com; helo=mx0a-00069f02.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add new vhost-user protocol feature to vhost-user protocol feature map\nand enumeration:\n - VHOST_USER_PROTOCOL_F_STATUS\n\nAdd new virtio device features for several virtio devices to their\nrespective feature mappings:\n\nvirtio-blk:\n - VIRTIO_BLK_F_SECURE_ERASE\n\nvirtio-net:\n - VIRTIO_NET_F_NOTF_COAL\n - VIRTIO_NET_F_GUEST_USO4\n - VIRTIO_NET_F_GUEST_USO6\n - VIRTIO_NET_F_HOST_USO\n\nvirtio/vhost-user-gpio:\n - VIRTIO_GPIO_F_IRQ\n - VHOST_USER_F_PROTOCOL_FEATURES\n\nAdd support for introspection on vhost-user-gpio devices.\n\nSigned-off-by: Jonah Palmer <jonah.palmer@oracle.com>\nReviewed-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>\n---\n hw/virtio/vhost-user-gpio.c | 7 +++++++\n hw/virtio/virtio-qmp.c | 34 +++++++++++++++++++++++++++++++++-\n 2 files changed, 40 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/virtio/vhost-user-gpio.c b/hw/virtio/vhost-user-gpio.c\nindex 3b013f2d0f..3d7fae3984 100644\n--- a/hw/virtio/vhost-user-gpio.c\n+++ b/hw/virtio/vhost-user-gpio.c\n@@ -205,6 +205,12 @@ static void vu_gpio_guest_notifier_mask(VirtIODevice *vdev, int idx, bool mask)\n vhost_virtqueue_mask(&gpio->vhost_dev, vdev, idx, mask);\n }\n \n+static struct vhost_dev *vu_gpio_get_vhost(VirtIODevice *vdev)\n+{\n+ VHostUserGPIO *gpio = VHOST_USER_GPIO(vdev);\n+ return &gpio->vhost_dev;\n+}\n+\n static void do_vhost_user_cleanup(VirtIODevice *vdev, VHostUserGPIO *gpio)\n {\n virtio_delete_queue(gpio->command_vq);\n@@ -413,6 +419,7 @@ static void vu_gpio_class_init(ObjectClass *klass, void *data)\n vdc->get_config = vu_gpio_get_config;\n vdc->set_status = vu_gpio_set_status;\n vdc->guest_notifier_mask = vu_gpio_guest_notifier_mask;\n+ vdc->get_vhost = vu_gpio_get_vhost;\n }\n \n static const TypeInfo vu_gpio_info = {\ndiff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c\nindex adebf87e9b..3431711db5 100644\n--- a/hw/virtio/virtio-qmp.c\n+++ b/hw/virtio/virtio-qmp.c\n@@ -30,6 +30,7 @@\n #include \"standard-headers/linux/virtio_iommu.h\"\n #include \"standard-headers/linux/virtio_mem.h\"\n #include \"standard-headers/linux/virtio_vsock.h\"\n+#include \"standard-headers/linux/virtio_gpio.h\"\n \n #include CONFIG_DEVICES\n \n@@ -53,6 +54,7 @@ enum VhostUserProtocolFeature {\n VHOST_USER_PROTOCOL_F_RESET_DEVICE = 13,\n VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS = 14,\n VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS = 15,\n+ VHOST_USER_PROTOCOL_F_STATUS = 16,\n VHOST_USER_PROTOCOL_F_MAX\n };\n \n@@ -136,6 +138,9 @@ static const qmp_virtio_feature_map_t vhost_user_protocol_map[] = {\n FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS, \\\n \"VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS: Configuration for \"\n \"memory slots supported\"),\n+ FEATURE_ENTRY(VHOST_USER_PROTOCOL_F_STATUS, \\\n+ \"VHOST_USER_PROTOCOL_F_STATUS: Querying and notifying back-end \"\n+ \"device status supported\"),\n { -1, \"\" }\n };\n \n@@ -178,6 +183,8 @@ static const qmp_virtio_feature_map_t virtio_blk_feature_map[] = {\n \"VIRTIO_BLK_F_DISCARD: Discard command supported\"),\n FEATURE_ENTRY(VIRTIO_BLK_F_WRITE_ZEROES, \\\n \"VIRTIO_BLK_F_WRITE_ZEROES: Write zeroes command supported\"),\n+ FEATURE_ENTRY(VIRTIO_BLK_F_SECURE_ERASE, \\\n+ \"VIRTIO_BLK_F_SECURE_ERASE: Secure erase supported\"),\n FEATURE_ENTRY(VIRTIO_BLK_F_ZONED, \\\n \"VIRTIO_BLK_F_ZONED: Zoned block devices\"),\n #ifndef VIRTIO_BLK_NO_LEGACY\n@@ -301,6 +308,14 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {\n FEATURE_ENTRY(VIRTIO_NET_F_CTRL_MAC_ADDR, \\\n \"VIRTIO_NET_F_CTRL_MAC_ADDR: MAC address set through control \"\n \"channel\"),\n+ FEATURE_ENTRY(VIRTIO_NET_F_NOTF_COAL, \\\n+ \"VIRTIO_NET_F_NOTF_COAL: Device supports coalescing notifications\"),\n+ FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \\\n+ \"VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4\"),\n+ FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \\\n+ \"VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6\"),\n+ FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \\\n+ \"VIRTIO_NET_F_HOST_USO: Device can receive USO\"),\n FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \\\n \"VIRTIO_NET_F_HASH_REPORT: Hash reporting supported\"),\n FEATURE_ENTRY(VIRTIO_NET_F_RSS, \\\n@@ -471,6 +486,18 @@ static const qmp_virtio_feature_map_t virtio_rng_feature_map[] = {\n };\n #endif\n \n+/* virtio/vhost-gpio features mapping */\n+#ifdef CONFIG_VHOST_USER_GPIO\n+static const qmp_virtio_feature_map_t virtio_gpio_feature_map[] = {\n+ FEATURE_ENTRY(VIRTIO_GPIO_F_IRQ, \\\n+ \"VIRTIO_GPIO_F_IRQ: Device supports interrupts on GPIO lines\"),\n+ FEATURE_ENTRY(VHOST_USER_F_PROTOCOL_FEATURES, \\\n+ \"VHOST_USER_F_PROTOCOL_FEATURES: Vhost-user protocol features \"\n+ \"negotiation supported\"),\n+ { -1, \"\" }\n+};\n+#endif\n+\n #define CONVERT_FEATURES(type, map, is_status, bitmap) \\\n ({ \\\n type *list = NULL; \\\n@@ -627,6 +654,12 @@ VirtioDeviceFeatures *qmp_decode_features(uint16_t device_id, uint64_t bitmap)\n features->dev_features =\n CONVERT_FEATURES(strList, virtio_rng_feature_map, 0, bitmap);\n break;\n+#endif\n+#ifdef CONFIG_VHOST_USER_GPIO\n+ case VIRTIO_ID_GPIO:\n+ features->dev_features =\n+ CONVERT_FEATURES(strList, virtio_gpio_feature_map, 0, bitmap);\n+ break;\n #endif\n /* No features */\n case VIRTIO_ID_9P:\n@@ -653,7 +686,6 @@ VirtioDeviceFeatures *qmp_decode_features(uint16_t device_id, uint64_t bitmap)\n case VIRTIO_ID_DMABUF:\n case VIRTIO_ID_PARAM_SERV:\n case VIRTIO_ID_AUDIO_POLICY:\n- case VIRTIO_ID_GPIO:\n break;\n default:\n g_assert_not_reached();\n", "prefixes": [ "RESEND", "v5", "2/3" ] }