Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1839942/?format=api
{ "id": 1839942, "url": "http://patchwork.ozlabs.org/api/patches/1839942/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926201532.221152-5-vsementsov@yandex-team.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230926201532.221152-5-vsementsov@yandex-team.ru>", "list_archive_url": null, "date": "2023-09-26T20:15:28", "name": "[v2,4/8] mc146818rtc: rtc_set_time(): initialize tm to zeroes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2741e9a034ba86ed9211648b7a4bbf9b4de6b3c9", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926201532.221152-5-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 375000, "url": "http://patchwork.ozlabs.org/api/series/375000/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=375000", "date": "2023-09-26T20:15:27", "name": "coverity fixes", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/375000/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1839942/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1839942/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=iuXBz6kl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Rw9yl1zMdz26jS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 27 Sep 2023 06:17:35 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1qlETa-0000YP-Kh; Tue, 26 Sep 2023 16:16:10 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1qlETX-0000Wi-Br\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:16:07 -0400", "from forwardcorp1c.mail.yandex.net\n ([2a02:6b8:c03:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1qlETR-0002hP-Rj\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:16:07 -0400", "from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net\n [IPv6:2a02:6b8:c12:550b:0:640:d49b:0])\n by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 4174560B95;\n Tue, 26 Sep 2023 23:15:58 +0300 (MSK)", "from vsementsov-lin.. (unknown [2a02:6b8:b081:b41d::1:39])\n by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id ZFWwvr0Oc0U0-8UOl5cvu; Tue, 26 Sep 2023 23:15:57 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1695759357;\n bh=EQA1Z1L3Ok0Pzqy4RW7FAhRw60+o+EX06kmlfEGLGIE=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=iuXBz6kljqjxWUQmRyaGaErXV8Cu9hApa9lzUeGGFU0KVpi8SJf85Ea3iO7zBWBpA\n TfE4nVzMMkuX/ZKnnmvSeOajtNjLLXoutfEfKUoFm9eiiZLct++xCUlxLrgxClSba2\n 4znIbHGTSoiJ7+PdeRBbCtaq2whHYE6fsBsmDXBQ=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "qemu-devel@nongnu.org", "Cc": "pbonzini@redhat.com, vsementsov@yandex-team.ru, peter.maydell@linaro.org,\n yc-core@yandex-team.ru, davydov-max@yandex-team.ru,\n \"Michael S. Tsirkin\" <mst@redhat.com>", "Subject": "[PATCH v2 4/8] mc146818rtc: rtc_set_time(): initialize tm to zeroes", "Date": "Tue, 26 Sep 2023 23:15:28 +0300", "Message-Id": "<20230926201532.221152-5-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230926201532.221152-1-vsementsov@yandex-team.ru>", "References": "<20230926201532.221152-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c03:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "set_time() function doesn't set all the fields, so it's better to\ninitialize tm structure. And Coverity will be happier about it.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n---\n hw/rtc/mc146818rtc.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c\nindex c27c362db9..2d391a8396 100644\n--- a/hw/rtc/mc146818rtc.c\n+++ b/hw/rtc/mc146818rtc.c\n@@ -599,7 +599,7 @@ static void rtc_get_time(MC146818RtcState *s, struct tm *tm)\n \n static void rtc_set_time(MC146818RtcState *s)\n {\n- struct tm tm;\n+ struct tm tm = {};\n g_autofree const char *qom_path = object_get_canonical_path(OBJECT(s));\n \n rtc_get_time(s, &tm);\n", "prefixes": [ "v2", "4/8" ] }