Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1839922/?format=api
{ "id": 1839922, "url": "http://patchwork.ozlabs.org/api/patches/1839922/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926192502.15986-1-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230926192502.15986-1-farosas@suse.de>", "list_archive_url": null, "date": "2023-09-26T19:25:02", "name": "optionrom: Remove build-id section", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bdd2e2368c4a8150d6dd69f6093c8675242b7aba", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926192502.15986-1-farosas@suse.de/mbox/", "series": [ { "id": 374994, "url": "http://patchwork.ozlabs.org/api/series/374994/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=374994", "date": "2023-09-26T19:25:02", "name": "optionrom: Remove build-id section", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/374994/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1839922/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1839922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=G4NqDgGT;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=03ULzx+j;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Rw8q51dqkz1ypD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 27 Sep 2023 05:25:53 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1qlDgH-0008Tj-3A; Tue, 26 Sep 2023 15:25:13 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1qlDgF-0008TT-0c\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 15:25:11 -0400", "from smtp-out2.suse.de ([195.135.220.29])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1qlDgD-00029n-7k\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 15:25:10 -0400", "from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de\n [192.168.254.74])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 0A6E81F749;\n Tue, 26 Sep 2023 19:25:07 +0000 (UTC)", "from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de\n [192.168.254.74])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)\n (No client certificate requested)\n by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5564313434;\n Tue, 26 Sep 2023 19:25:05 +0000 (UTC)", "from dovecot-director2.suse.de ([192.168.254.65])\n by imap2.suse-dmz.suse.de with ESMTPSA id 8w5+CBEwE2WCdwAAMHmgww\n (envelope-from <farosas@suse.de>); Tue, 26 Sep 2023 19:25:05 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1695756307;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=JKOKBhT57MVl9BDREKbRYpPBO6CGATfdJZDtO5lOybU=;\n b=G4NqDgGT5Z5b4U6Uv1COsgxkFWtZF5/Dq5CPmK/m2VECyaTtHDku53UrBMrMetRL1imNEj\n uhPA1TYhArweV7AbhWcb74UVD5SThR9wHv/9TRc0Qr5P0Jg2SPCszScTMd6iLlerIjNs4W\n dliJRx4YKXK5JOTnrBhH1AEihq9Cir0=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1695756307;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=JKOKBhT57MVl9BDREKbRYpPBO6CGATfdJZDtO5lOybU=;\n b=03ULzx+jn8NSOaDY1YgEjs8DMOJv8jAb/4g7yzSfvH+7ARZp7/HWjUP3CbBPd7wVWwlSyB\n 4PwJ2cLv3v3tSVCQ==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Dario Faggioli <dfaggioli@suse.com>,\n Vasiliy Ulyanov <vulyanov@suse.de>", "Subject": "[PATCH] optionrom: Remove build-id section", "Date": "Tue, 26 Sep 2023 16:25:02 -0300", "Message-Id": "<20230926192502.15986-1-farosas@suse.de>", "X-Mailer": "git-send-email 2.35.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=195.135.220.29; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Our linker script for optionroms specifies only the placement of the\n.text section, leaving the linker free to place the remaining sections\nat arbitrary places in the file.\n\nSince at least binutils 2.39, the .note.gnu.build-id section is now\nbeing placed at the start of the file, which causes label addresses to\nbe shifted. For linuxboot_dma.bin that means that the PnP header\n(among others) will not be found when determining the type of ROM at\noptionrom_setup():\n\n(0x1c is the label _pnph, where the magic \"PnP\" is)\n\n$ xxd /usr/share/qemu/linuxboot_dma.bin | grep \"PnP\"\n00000010: 0000 0000 0000 0000 0000 1c00 2450 6e50 ............$PnP\n\n$ xxd pc-bios/optionrom/linuxboot_dma.bin | grep \"PnP\"\n00000010: 0000 0000 0000 0000 0000 4c00 2450 6e50 ............$PnP\n ^bad\n\nUsing a freshly built linuxboot_dma.bin ROM results in a broken boot:\n\n SeaBIOS (version rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org)\n Booting from Hard Disk...\n Boot failed: could not read the boot disk\n\n Booting from Floppy...\n Boot failed: could not read the boot disk\n\n No bootable device.\n\nWe're not using the build-id section, so pass the --build-id=none\noption to the linker to remove it entirely.\n\nNote: In theory, this same issue could happen with any other\nsection. The ideal solution would be to have all unused sections\ndiscarded in the linker script. However that would be a larger change,\nspecially for the pvh rom which uses the .bss and COMMON sections so\nI'm addressing only the immediate issue here.\n\nReported-by: Vasiliy Ulyanov <vulyanov@suse.de>\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n pc-bios/optionrom/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile\nindex b1fff0ba6c..30d07026c7 100644\n--- a/pc-bios/optionrom/Makefile\n+++ b/pc-bios/optionrom/Makefile\n@@ -36,7 +36,7 @@ config-cc.mak: Makefile\n \t $(call cc-option,-Wno-array-bounds)) 3> config-cc.mak\n -include config-cc.mak\n \n-override LDFLAGS = -nostdlib -Wl,-T,$(SRC_DIR)/flat.lds\n+override LDFLAGS = -nostdlib -Wl,--build-id=none,-T,$(SRC_DIR)/flat.lds\n \n pvh.img: pvh.o pvh_main.o\n \n", "prefixes": [] }