Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1825229/?format=api
{ "id": 1825229, "url": "http://patchwork.ozlabs.org/api/patches/1825229/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230824092409.1492470-31-gaosong@loongson.cn/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230824092409.1492470-31-gaosong@loongson.cn>", "list_archive_url": null, "date": "2023-08-24T09:24:08", "name": "[PULL,30/31] target/loongarch: Split fcc register to fcc0-7 in gdbstub", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "86e65d0d204b3b2c99d7102ce7594bee71c2f106", "submitter": { "id": 82024, "url": "http://patchwork.ozlabs.org/api/people/82024/?format=api", "name": "gaosong", "email": "gaosong@loongson.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230824092409.1492470-31-gaosong@loongson.cn/mbox/", "series": [ { "id": 370173, "url": "http://patchwork.ozlabs.org/api/series/370173/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=370173", "date": "2023-08-24T09:23:41", "name": "[PULL,01/31] target/loongarch: Log I/O write accesses to CSR registers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/370173/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1825229/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1825229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RWd6X0yssz1ygJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 24 Aug 2023 19:28:04 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1qZ6ba-0003N1-Jy; Thu, 24 Aug 2023 05:26:20 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <gaosong@loongson.cn>)\n id 1qZ6bT-0003Ep-Aa\n for qemu-devel@nongnu.org; Thu, 24 Aug 2023 05:26:11 -0400", "from mail.loongson.cn ([114.242.206.163])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <gaosong@loongson.cn>) id 1qZ6bO-0004D6-Gj\n for qemu-devel@nongnu.org; Thu, 24 Aug 2023 05:26:10 -0400", "from loongson.cn (unknown [10.2.5.185])\n by gateway (Coremail) with SMTP id _____8Bxd+jIIedko3kbAA--.20150S3;\n Thu, 24 Aug 2023 17:24:24 +0800 (CST)", "from localhost.localdomain (unknown [10.2.5.185])\n by localhost.localdomain (Coremail) with SMTP id\n AQAAf8DxJ826IedkJjhiAA--.40637S32;\n Thu, 24 Aug 2023 17:24:24 +0800 (CST)" ], "From": "Song Gao <gaosong@loongson.cn>", "To": "qemu-devel@nongnu.org", "Cc": "stefanha@redhat.com, richard.henderson@linaro.org, Jiajie Chen <c@jia.je>", "Subject": "[PULL 30/31] target/loongarch: Split fcc register to fcc0-7 in\n gdbstub", "Date": "Thu, 24 Aug 2023 17:24:08 +0800", "Message-Id": "<20230824092409.1492470-31-gaosong@loongson.cn>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230824092409.1492470-1-gaosong@loongson.cn>", "References": "<20230824092409.1492470-1-gaosong@loongson.cn>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "AQAAf8DxJ826IedkJjhiAA--.40637S32", "X-CM-SenderInfo": "5jdr20tqj6z05rqj20fqof0/", "X-Coremail-Antispam": "1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7\n ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx\n nUUI43ZEXa7xR_UUUUUUUUU==", "Received-SPF": "pass client-ip=114.242.206.163;\n envelope-from=gaosong@loongson.cn;\n helo=mail.loongson.cn", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Jiajie Chen <c@jia.je>\n\nSince GDB 13.1(GDB commit ea3352172), GDB LoongArch changed to use\nfcc0-7 instead of fcc register. This commit partially reverts commit\n2f149c759 (`target/loongarch: Update gdb_set_fpu() and gdb_get_fpu()`)\nto match the behavior of GDB.\n\nNote that it is a breaking change for GDB 13.0 or earlier, but it is\nalso required for GDB 13.1 or later to work.\n\nSigned-off-by: Jiajie Chen <c@jia.je>\nAcked-by: Song Gao <gaosong@loongson.cn>\nMessage-Id: <20230808054315.3391465-1-c@jia.je>\nSigned-off-by: Song Gao <gaosong@loongson.cn>\n---\n gdb-xml/loongarch-fpu.xml | 9 ++++++++-\n target/loongarch/gdbstub.c | 16 +++++++---------\n 2 files changed, 15 insertions(+), 10 deletions(-)", "diff": "diff --git a/gdb-xml/loongarch-fpu.xml b/gdb-xml/loongarch-fpu.xml\nindex 78e42cf5dd..e81e3382e7 100644\n--- a/gdb-xml/loongarch-fpu.xml\n+++ b/gdb-xml/loongarch-fpu.xml\n@@ -45,6 +45,13 @@\n <reg name=\"f29\" bitsize=\"64\" type=\"fputype\" group=\"float\"/>\n <reg name=\"f30\" bitsize=\"64\" type=\"fputype\" group=\"float\"/>\n <reg name=\"f31\" bitsize=\"64\" type=\"fputype\" group=\"float\"/>\n- <reg name=\"fcc\" bitsize=\"64\" type=\"uint64\" group=\"float\"/>\n+ <reg name=\"fcc0\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc1\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc2\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc3\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc4\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc5\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc6\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n+ <reg name=\"fcc7\" bitsize=\"8\" type=\"uint8\" group=\"float\"/>\n <reg name=\"fcsr\" bitsize=\"32\" type=\"uint32\" group=\"float\"/>\n </feature>\ndiff --git a/target/loongarch/gdbstub.c b/target/loongarch/gdbstub.c\nindex e20b20f99b..b09804b62f 100644\n--- a/target/loongarch/gdbstub.c\n+++ b/target/loongarch/gdbstub.c\n@@ -88,10 +88,9 @@ static int loongarch_gdb_get_fpu(CPULoongArchState *env,\n {\n if (0 <= n && n < 32) {\n return gdb_get_reg64(mem_buf, env->fpr[n].vreg.D(0));\n- } else if (n == 32) {\n- uint64_t val = read_fcc(env);\n- return gdb_get_reg64(mem_buf, val);\n- } else if (n == 33) {\n+ } else if (32 <= n && n < 40) {\n+ return gdb_get_reg8(mem_buf, env->cf[n - 32]);\n+ } else if (n == 40) {\n return gdb_get_reg32(mem_buf, env->fcsr0);\n }\n return 0;\n@@ -105,11 +104,10 @@ static int loongarch_gdb_set_fpu(CPULoongArchState *env,\n if (0 <= n && n < 32) {\n env->fpr[n].vreg.D(0) = ldq_p(mem_buf);\n length = 8;\n- } else if (n == 32) {\n- uint64_t val = ldq_p(mem_buf);\n- write_fcc(env, val);\n- length = 8;\n- } else if (n == 33) {\n+ } else if (32 <= n && n < 40) {\n+ env->cf[n - 32] = ldub_p(mem_buf);\n+ length = 1;\n+ } else if (n == 40) {\n env->fcsr0 = ldl_p(mem_buf);\n length = 4;\n }\n", "prefixes": [ "PULL", "30/31" ] }