Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1825224/?format=api
{ "id": 1825224, "url": "http://patchwork.ozlabs.org/api/patches/1825224/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230824092409.1492470-32-gaosong@loongson.cn/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230824092409.1492470-32-gaosong@loongson.cn>", "list_archive_url": null, "date": "2023-08-24T09:24:09", "name": "[PULL,31/31] hw/loongarch: Fix ACPI processor id off-by-one error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c8aca82594dc3eb03084bd73b18097f7a64ac269", "submitter": { "id": 82024, "url": "http://patchwork.ozlabs.org/api/people/82024/?format=api", "name": "gaosong", "email": "gaosong@loongson.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20230824092409.1492470-32-gaosong@loongson.cn/mbox/", "series": [ { "id": 370173, "url": "http://patchwork.ozlabs.org/api/series/370173/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=370173", "date": "2023-08-24T09:23:41", "name": "[PULL,01/31] target/loongarch: Log I/O write accesses to CSR registers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/370173/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1825224/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1825224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RWd4q5j02z1yfF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 24 Aug 2023 19:26:35 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1qZ6ap-0005tC-IX; Thu, 24 Aug 2023 05:25:31 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <gaosong@loongson.cn>)\n id 1qZ6aM-0004Fx-HN\n for qemu-devel@nongnu.org; Thu, 24 Aug 2023 05:25:10 -0400", "from mail.loongson.cn ([114.242.206.163])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <gaosong@loongson.cn>) id 1qZ6aH-0003jr-C9\n for qemu-devel@nongnu.org; Thu, 24 Aug 2023 05:25:01 -0400", "from loongson.cn (unknown [10.2.5.185])\n by gateway (Coremail) with SMTP id _____8Cx5_HIIedkqHkbAA--.56042S3;\n Thu, 24 Aug 2023 17:24:24 +0800 (CST)", "from localhost.localdomain (unknown [10.2.5.185])\n by localhost.localdomain (Coremail) with SMTP id\n AQAAf8DxJ826IedkJjhiAA--.40637S33;\n Thu, 24 Aug 2023 17:24:24 +0800 (CST)" ], "From": "Song Gao <gaosong@loongson.cn>", "To": "qemu-devel@nongnu.org", "Cc": "stefanha@redhat.com, richard.henderson@linaro.org, Jiajie Chen <c@jia.je>,\n Bibo Mao <maobibo@loongson.cn>", "Subject": "[PULL 31/31] hw/loongarch: Fix ACPI processor id off-by-one error", "Date": "Thu, 24 Aug 2023 17:24:09 +0800", "Message-Id": "<20230824092409.1492470-32-gaosong@loongson.cn>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230824092409.1492470-1-gaosong@loongson.cn>", "References": "<20230824092409.1492470-1-gaosong@loongson.cn>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "AQAAf8DxJ826IedkJjhiAA--.40637S33", "X-CM-SenderInfo": "5jdr20tqj6z05rqj20fqof0/", "X-Coremail-Antispam": "1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7\n ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx\n nUUI43ZEXa7xR_UUUUUUUUU==", "Received-SPF": "pass client-ip=114.242.206.163;\n envelope-from=gaosong@loongson.cn;\n helo=mail.loongson.cn", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Jiajie Chen <c@jia.je>\n\nIn hw/acpi/aml-build.c:build_pptt() function, the code assumes that the\nACPI processor id equals to the cpu index, for example if we have 8\ncpus, then the ACPI processor id should be in range 0-7.\n\nHowever, in hw/loongarch/acpi-build.c:build_madt() function we broke the\nassumption. If we have 8 cpus again, the ACPI processor id in MADT table\nwould be in range 1-8. It violates the following description taken from\nACPI spec 6.4 table 5.138:\n\nIf the processor structure represents an actual processor, this field\nmust match the value of ACPI processor ID field in the processor’s entry\nin the MADT.\n\nIt will break the latest Linux 6.5-rc6 with the\nfollowing error message:\n\nACPI PPTT: PPTT table found, but unable to locate core 7 (8)\nInvalid BIOS PPTT\n\nHere 7 is the last cpu index, 8 is the ACPI processor id learned from\nMADT.\n\nWith this patch, Linux can properly detect SMT threads when \"-smp\n8,sockets=1,cores=4,threads=2\" is passed:\n\nThread(s) per core: 2\nCore(s) per socket: 2\nSocket(s): 2\n\nThe detection of number of sockets is still wrong, but that is out of\nscope of the commit.\n\nSigned-off-by: Jiajie Chen <c@jia.je>\nReviewed-by: Bibo Mao <maobibo@loongson.cn>\nMessage-Id: <20230820105658.99123-2-c@jia.je>\nSigned-off-by: Song Gao <gaosong@loongson.cn>\n---\n hw/loongarch/acpi-build.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c\nindex 0b62c3a2f7..ae292fc543 100644\n--- a/hw/loongarch/acpi-build.c\n+++ b/hw/loongarch/acpi-build.c\n@@ -127,7 +127,7 @@ build_madt(GArray *table_data, BIOSLinker *linker, LoongArchMachineState *lams)\n build_append_int_noprefix(table_data, 17, 1); /* Type */\n build_append_int_noprefix(table_data, 15, 1); /* Length */\n build_append_int_noprefix(table_data, 1, 1); /* Version */\n- build_append_int_noprefix(table_data, i + 1, 4); /* ACPI Processor ID */\n+ build_append_int_noprefix(table_data, i, 4); /* ACPI Processor ID */\n build_append_int_noprefix(table_data, arch_id, 4); /* Core ID */\n build_append_int_noprefix(table_data, 1, 4); /* Flags */\n }\n", "prefixes": [ "PULL", "31/31" ] }