Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/179812/?format=api
{ "id": 179812, "url": "http://patchwork.ozlabs.org/api/patches/179812/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1345803102-21110-2-git-send-email-gerlando.falauto@keymile.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1345803102-21110-2-git-send-email-gerlando.falauto@keymile.com>", "list_archive_url": null, "date": "2012-08-24T10:11:36", "name": "[U-Boot,v4,1/7] env: cosmetic: drop assignment i = iomux_doenv()", "commit_ref": "c2ba2ff51101cdcfabdc0bdc961e37cc51cb7d23", "pull_url": null, "state": "accepted", "archived": false, "hash": "2de9f5240082696ad5e0ec0172a11c65b6fb3348", "submitter": { "id": 9154, "url": "http://patchwork.ozlabs.org/api/people/9154/?format=api", "name": "Gerlando Falauto", "email": "gerlando.falauto@keymile.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1345803102-21110-2-git-send-email-gerlando.falauto@keymile.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/179812/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/179812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id 1CA932C00D2\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 Aug 2012 20:19:06 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 2973E280CA;\n\tFri, 24 Aug 2012 12:19:02 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id owVG5FSCaEcN; Fri, 24 Aug 2012 12:19:01 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id A373D28101;\n\tFri, 24 Aug 2012 12:18:49 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 8D22528101\n\tfor <u-boot@lists.denx.de>; Fri, 24 Aug 2012 12:18:40 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TFrrTxsrrYrG for <u-boot@lists.denx.de>;\n\tFri, 24 Aug 2012 12:18:40 +0200 (CEST)", "from mail-de.keymile.com (mail-de.keymile.com [195.8.104.1])\n\tby theia.denx.de (Postfix) with SMTP id 7FFDD28119\n\tfor <u-boot@lists.denx.de>; Fri, 24 Aug 2012 12:18:38 +0200 (CEST)", "from mailrelay.de.keymile.net ([10.9.1.54]) by eSafe SMTP Relay\n\t1345792219; Fri, 24 Aug 2012 12:18:35 +0200", "from chber1-10555x.ch.keymile.net (chber1-10555x.ch.keymile.net\n\t[172.31.40.82]) by mailrelay.de.keymile.net (8.12.2/8.12.2)\n\twith ESMTP id q7OAHMj9026728; Fri, 24 Aug 2012 12:17:27 +0200 (MEST)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "From": "Gerlando Falauto <gerlando.falauto@keymile.com>", "To": "u-boot@lists.denx.de", "Date": "Fri, 24 Aug 2012 12:11:36 +0200", "Message-Id": "<1345803102-21110-2-git-send-email-gerlando.falauto@keymile.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1345803102-21110-1-git-send-email-gerlando.falauto@keymile.com>", "References": "<1321634955-5561-1-git-send-email-gerlando.falauto@keymile.com><1345803102-21110-1-git-send-email-gerlando.falauto@keymile.com>", "X-ESAFE-STATUS": "[srvhellgate.de.keymile.net] Mail clean", "Cc": "marex@denx.de, holger.brunck@keymile.com,\n\tGerlando Falauto <gerlando.falauto@keymile.com>", "Subject": "[U-Boot] [PATCH v4 1/7] env: cosmetic: drop assignment i =\n\tiomux_doenv()", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "iomux_doenv() can only return 0 or 1.\nSo there is no need to save its return value in variable i, as checking\nits truth value within an if statement is enough.\n\nSigned-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>\n---\n common/cmd_nvedit.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c\nindex fd05e72..b8c7676 100644\n--- a/common/cmd_nvedit.c\n+++ b/common/cmd_nvedit.c\n@@ -239,9 +239,8 @@ int _do_env_set(int flag, int argc, char * const argv[])\n \t\t}\n \n #ifdef CONFIG_CONSOLE_MUX\n-\t\ti = iomux_doenv(console, argv[2]);\n-\t\tif (i)\n-\t\t\treturn i;\n+\t\tif (iomux_doenv(console, argv[2]))\n+\t\t\treturn 1;\n #else\n \t\t/* Try assigning specified device */\n \t\tif (console_assign(console, argv[2]) < 0)\n", "prefixes": [ "U-Boot", "v4", "1/7" ] }