Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/175283/?format=api
{ "id": 175283, "url": "http://patchwork.ozlabs.org/api/patches/175283/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1344239199-11445-6-git-send-email-monstr@monstr.eu/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1344239199-11445-6-git-send-email-monstr@monstr.eu>", "list_archive_url": null, "date": "2012-08-06T07:46:38", "name": "[U-Boot,v2,6/7] microblaze: Clean microblaze initialization", "commit_ref": "2380b8f529ae95cc51fa475e83101e40f4191a43", "pull_url": null, "state": "accepted", "archived": false, "hash": "c040b3b9f8f97ab203ceb6e9fd1323d1f788155a", "submitter": { "id": 2237, "url": "http://patchwork.ozlabs.org/api/people/2237/?format=api", "name": "Michal Simek", "email": "monstr@monstr.eu" }, "delegate": { "id": 1714, "url": "http://patchwork.ozlabs.org/api/users/1714/?format=api", "username": "vapier", "first_name": "Mike", "last_name": "Frysinger", "email": "vapier@gentoo.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1344239199-11445-6-git-send-email-monstr@monstr.eu/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/175283/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/175283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id 46EA62C0079\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Aug 2012 17:47:56 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 644D528173;\n\tMon, 6 Aug 2012 09:47:37 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SeBmUmPen6KB; Mon, 6 Aug 2012 09:47:37 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id AFDD728179;\n\tMon, 6 Aug 2012 09:47:18 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 25A3C28165\n\tfor <u-boot@lists.denx.de>; Mon, 6 Aug 2012 09:47:16 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Syot+2K80vf6 for <u-boot@lists.denx.de>;\n\tMon, 6 Aug 2012 09:47:15 +0200 (CEST)", "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180])\n\tby theia.denx.de (Postfix) with ESMTPS id 53EED28148\n\tfor <u-boot@lists.denx.de>; Mon, 6 Aug 2012 09:47:02 +0200 (CEST)", "by wibhm6 with SMTP id hm6so1167233wib.9\n\tfor <u-boot@lists.denx.de>; Mon, 06 Aug 2012 00:47:02 -0700 (PDT)", "by 10.180.104.197 with SMTP id gg5mr16142176wib.9.1344239222118;\n\tMon, 06 Aug 2012 00:47:02 -0700 (PDT)", "from localhost (nat-2.starnet.cz. [92.62.224.2])\n\tby mx.google.com with ESMTPS id\n\tz11sm21037555wiv.10.2012.08.06.00.47.01\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tMon, 06 Aug 2012 00:47:01 -0700 (PDT)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references\n\t:x-gm-message-state;\n\tbh=zNWU9+AJwJVJbEfHR+HtBO7ZkvwiP/AvrT7R8MeTLrI=;\n\tb=QB/kq9wTh0ZeMamdrR4iyS/DICKMx9KTr9U62IVBIMA1d/c6zIOsnfO6ThR9UHJWsy\n\t8egejsTTYUamObJDwXlOwzL9hk6XG9wx2S9LMl31PCbA9xKzb/JvUQqFtCScxDGT/NGL\n\tYOEiZyvUnLUFeZUrND2G5lVcGxKKcFZR1XXO3hcVipEWN2xw1PHoiU/pwbi+CxPz79sS\n\thTn0j/5dnK2SRWZI1jrkR4Uv4T/FpLkQJGWHYCbUBIbZuotATR6iUUCkwsAmRRXLwFkY\n\t88h+jyNKObCdq4dvB7+Vl+2trjX8DSaSxrR5Fqv93Cbb9BjidP1cMzPt6AHrYy2FHp7D\n\txqQg==", "From": "Michal Simek <monstr@monstr.eu>", "To": "u-boot@lists.denx.de", "Date": "Mon, 6 Aug 2012 09:46:38 +0200", "Message-Id": "<1344239199-11445-6-git-send-email-monstr@monstr.eu>", "X-Mailer": "git-send-email 1.7.0.4", "In-Reply-To": "<1344239199-11445-1-git-send-email-monstr@monstr.eu>", "References": "<1344239199-11445-1-git-send-email-monstr@monstr.eu>", "X-Gm-Message-State": "ALoCoQkyL06RiMmOGwaUxi9zfxEQlI+tB9jAQKIYZVNwSGew8V4LEUzN3MMT5o3WoJLlubCypX8H", "Cc": "linz@li-pro.net", "Subject": "[U-Boot] [PATCH v2 6/7] microblaze: Clean microblaze initialization", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "Move board specific function to board_init function in board/ folder\nRemove externs from generic board.c\nUse board_init_f function in board.c file.\n\nSigned-off-by: Michal Simek <monstr@monstr.eu>\n\n---\nv2: Remove global pointer\n Define board_init function in header\n---\n arch/microblaze/cpu/start.S | 2 +-\n arch/microblaze/include/asm/processor.h | 3 +++\n arch/microblaze/lib/board.c | 17 +++--------------\n .../xilinx/microblaze-generic/microblaze-generic.c | 9 +++++++++\n 4 files changed, 16 insertions(+), 15 deletions(-)", "diff": "diff --git a/arch/microblaze/cpu/start.S b/arch/microblaze/cpu/start.S\nindex 8a2f634..8564c4e 100644\n--- a/arch/microblaze/cpu/start.S\n+++ b/arch/microblaze/cpu/start.S\n@@ -149,7 +149,7 @@ clear_bss:\n \tcmp r6, r5, r4 /* check if we have reach the end */\n \tbnei r6, 2b\n 3:\t/* jumping to board_init */\n-\tbrai\tboard_init\n+\tbrai\tboard_init_f\n 1:\tbri\t1b\n \n /*\ndiff --git a/arch/microblaze/include/asm/processor.h b/arch/microblaze/include/asm/processor.h\nindex 2295d0a..2c4d5ff 100644\n--- a/arch/microblaze/include/asm/processor.h\n+++ b/arch/microblaze/include/asm/processor.h\n@@ -28,4 +28,7 @@\n extern char __end[];\n extern char __text_start[];\n \n+/* Microblaze board initialization function */\n+void board_init(void);\n+\n #endif /* __ASM_MICROBLAZE_PROCESSOR_H */\ndiff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c\nindex fde109f..b450367 100644\n--- a/arch/microblaze/lib/board.c\n+++ b/arch/microblaze/lib/board.c\n@@ -39,13 +39,6 @@\n \n DECLARE_GLOBAL_DATA_PTR;\n \n-#ifdef CONFIG_SYS_GPIO_0\n-extern int gpio_init (void);\n-#endif\n-#ifdef CONFIG_SYS_FSL_2\n-extern void fsl_init2 (void);\n-#endif\n-\n /*\n * All attempts to come up with a \"common\" initialization sequence\n * that works for all boards and architectures failed: some of the\n@@ -67,20 +60,14 @@ init_fnc_t *init_sequence[] = {\n #endif\n \tserial_init,\n \tconsole_init_f,\n-#ifdef CONFIG_SYS_GPIO_0\n-\tgpio_init,\n-#endif\n \tinterrupts_init,\n \ttimer_init,\n-#ifdef CONFIG_SYS_FSL_2\n-\tfsl_init2,\n-#endif\n \tNULL,\n };\n \n unsigned long monitor_flash_len;\n \n-void board_init (void)\n+void board_init_f(ulong not_used)\n {\n \tbd_t *bd;\n \tinit_fnc_t **init_fnc_ptr;\n@@ -189,6 +176,8 @@ void board_init (void)\n \t/* Initialize the console (after the relocation and devices init) */\n \tconsole_init_r();\n \n+\tboard_init();\n+\n \t/* Initialize from environment */\n \tload_addr = getenv_ulong(\"loadaddr\", 16, load_addr);\n \ndiff --git a/board/xilinx/microblaze-generic/microblaze-generic.c b/board/xilinx/microblaze-generic/microblaze-generic.c\nindex a1e2bfe..b75e62c 100644\n--- a/board/xilinx/microblaze-generic/microblaze-generic.c\n+++ b/board/xilinx/microblaze-generic/microblaze-generic.c\n@@ -28,6 +28,7 @@\n #include <common.h>\n #include <config.h>\n #include <netdev.h>\n+#include <asm/processor.h>\n #include <asm/microblaze_intc.h>\n #include <asm/asm.h>\n \n@@ -69,6 +70,14 @@ int fsl_init2 (void) {\n }\n #endif\n \n+void board_init(void)\n+{\n+\tgpio_init();\n+#ifdef CONFIG_SYS_FSL_2\n+\tfsl_init2();\n+#endif\n+}\n+\n int board_eth_init(bd_t *bis)\n {\n \tint ret = 0;\n", "prefixes": [ "U-Boot", "v2", "6/7" ] }