Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/175281/?format=api
{ "id": 175281, "url": "http://patchwork.ozlabs.org/api/patches/175281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1344239199-11445-4-git-send-email-monstr@monstr.eu/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1344239199-11445-4-git-send-email-monstr@monstr.eu>", "list_archive_url": null, "date": "2012-08-06T07:46:36", "name": "[U-Boot,v2,4/7] microblaze: intc: Coding style cleanup", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "6f16f219f35467e6609aa35483679672d36e2fd3", "submitter": { "id": 2237, "url": "http://patchwork.ozlabs.org/api/people/2237/?format=api", "name": "Michal Simek", "email": "monstr@monstr.eu" }, "delegate": { "id": 1714, "url": "http://patchwork.ozlabs.org/api/users/1714/?format=api", "username": "vapier", "first_name": "Mike", "last_name": "Frysinger", "email": "vapier@gentoo.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1344239199-11445-4-git-send-email-monstr@monstr.eu/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/175281/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/175281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id 01BCE2C0092\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Aug 2012 17:47:36 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 0A1A328142;\n\tMon, 6 Aug 2012 09:47:23 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hdCef5NW+wyP; Mon, 6 Aug 2012 09:47:22 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id E15A728158;\n\tMon, 6 Aug 2012 09:47:09 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 76C98280AD\n\tfor <u-boot@lists.denx.de>; Mon, 6 Aug 2012 09:47:07 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HXW-tiIlZ2mH for <u-boot@lists.denx.de>;\n\tMon, 6 Aug 2012 09:47:07 +0200 (CEST)", "from mail-wg0-f52.google.com (mail-wg0-f52.google.com\n\t[74.125.82.52])\n\tby theia.denx.de (Postfix) with ESMTPS id 0A04228123\n\tfor <u-boot@lists.denx.de>; Mon, 6 Aug 2012 09:46:58 +0200 (CEST)", "by wgbfg15 with SMTP id fg15so2492069wgb.9\n\tfor <u-boot@lists.denx.de>; Mon, 06 Aug 2012 00:46:58 -0700 (PDT)", "by 10.217.2.197 with SMTP id p47mr4808783wes.55.1344239218045;\n\tMon, 06 Aug 2012 00:46:58 -0700 (PDT)", "from localhost (nat-2.starnet.cz. [92.62.224.2])\n\tby mx.google.com with ESMTPS id j6sm21032708wiy.4.2012.08.06.00.46.56\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tMon, 06 Aug 2012 00:46:57 -0700 (PDT)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references\n\t:x-gm-message-state;\n\tbh=HkNCNSRsgNbcmTM4J75BD9C/4UZNY2OzjossdXcbqm8=;\n\tb=FGv+AGYqEXxJhZM7R7PRjSctcePVwtCes4ZywGGiRcxu53ExzzbocDlp1ytYyN/A8k\n\ta0GaC/D2zV7aKtPQgFMIUglyOvfSXpkoC/4wwlosHWK/AM1UM//Eln1CVZB1ZrCw1Eq0\n\tKAzScy3o2VoT7j9ItxMu1SmfUIVjZfMLqfy4SL4VOOPL0KywV1xtg9aaKz39mCg5kM82\n\t0lWraDhN0YUBckJN+Zdp+ksOqI4lON2PR+ntogJM2GMRhrssypafFXnCP4XkLoCAWphA\n\tQGGimexEADXqPqVDzSw7ceA3u8fQ2JzQq9ICsUNas/ObdGskXs0cU67W4dqf7+ssxRbk\n\t2jwQ==", "From": "Michal Simek <monstr@monstr.eu>", "To": "u-boot@lists.denx.de", "Date": "Mon, 6 Aug 2012 09:46:36 +0200", "Message-Id": "<1344239199-11445-4-git-send-email-monstr@monstr.eu>", "X-Mailer": "git-send-email 1.7.0.4", "In-Reply-To": "<1344239199-11445-1-git-send-email-monstr@monstr.eu>", "References": "<1344239199-11445-1-git-send-email-monstr@monstr.eu>", "X-Gm-Message-State": "ALoCoQk/LOowOraB7jawOdT+t1A2f/umKuRXxwEpj3taaJoowVzBNpes0W22i8TWoqj7Nb9qqyan", "Cc": "linz@li-pro.net", "Subject": "[U-Boot] [PATCH v2 4/7] microblaze: intc: Coding style cleanup", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "Just coding style cleanup.\nRemove unneeded externs.\n\nSigned-off-by: Michal Simek <monstr@monstr.eu>\nAcked-by: Simon Glass <sjg@chromium.org>\n\n--\nv2: Rebase - depends on previous intc patch\n---\n arch/microblaze/cpu/interrupts.c | 26 +++++++++++++-------------\n 1 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/arch/microblaze/cpu/interrupts.c b/arch/microblaze/cpu/interrupts.c\nindex 08f6bad..7f2ee64 100644\n--- a/arch/microblaze/cpu/interrupts.c\n+++ b/arch/microblaze/cpu/interrupts.c\n@@ -32,15 +32,12 @@\n \n #undef DEBUG_INT\n \n-extern void microblaze_disable_interrupts (void);\n-extern void microblaze_enable_interrupts (void);\n-\n-void enable_interrupts (void)\n+void enable_interrupts(void)\n {\n \tMSRSET(0x2);\n }\n \n-int disable_interrupts (void)\n+int disable_interrupts(void)\n {\n \tunsigned int msr;\n \n@@ -58,20 +55,21 @@ microblaze_intc_t *intc;\n /* default handler */\n static void def_hdlr(void)\n {\n-\tputs (\"def_hdlr\\n\");\n+\tputs(\"def_hdlr\\n\");\n }\n \n static void enable_one_interrupt(int irq)\n {\n \tint mask;\n \tint offset = 1;\n+\n \toffset <<= irq;\n \tmask = intc->ier;\n \tintc->ier = (mask | offset);\n #ifdef DEBUG_INT\n-\tprintf (\"Enable one interrupt irq %x - mask %x,ier %x\\n\", offset, mask,\n+\tprintf(\"Enable one interrupt irq %x - mask %x,ier %x\\n\", offset, mask,\n \t\tintc->ier);\n-\tprintf (\"INTC isr %x, ier %x, iar %x, mer %x\\n\", intc->isr, intc->ier,\n+\tprintf(\"INTC isr %x, ier %x, iar %x, mer %x\\n\", intc->isr, intc->ier,\n \t\tintc->iar, intc->mer);\n #endif\n }\n@@ -80,13 +78,14 @@ static void disable_one_interrupt(int irq)\n {\n \tint mask;\n \tint offset = 1;\n+\n \toffset <<= irq;\n \tmask = intc->ier;\n \tintc->ier = (mask & ~offset);\n #ifdef DEBUG_INT\n-\tprintf (\"Disable one interrupt irq %x - mask %x,ier %x\\n\", irq, mask,\n+\tprintf(\"Disable one interrupt irq %x - mask %x,ier %x\\n\", irq, mask,\n \t\tintc->ier);\n-\tprintf (\"INTC isr %x, ier %x, iar %x, mer %x\\n\", intc->isr, intc->ier,\n+\tprintf(\"INTC isr %x, ier %x, iar %x, mer %x\\n\", intc->isr, intc->ier,\n \t\tintc->iar, intc->mer);\n #endif\n }\n@@ -94,9 +93,10 @@ static void disable_one_interrupt(int irq)\n int install_interrupt_handler(int irq, interrupt_handler_t *hdlr, void *arg)\n {\n \tstruct irq_action *act;\n+\n \t/* irq out of range */\n \tif ((irq < 0) || (irq > irq_no)) {\n-\t\tputs (\"IRQ out of range\\n\");\n+\t\tputs(\"IRQ out of range\\n\");\n \t\treturn -1;\n \t}\n \tact = &vecs[irq];\n@@ -124,7 +124,7 @@ static void intc_init(void)\n \t/* XIntc_Start - hw_interrupt enable and all interrupt enable */\n \tintc->mer = 0x3;\n #ifdef DEBUG_INT\n-\tprintf (\"INTC isr %x, ier %x, iar %x, mer %x\\n\", intc->isr, intc->ier,\n+\tprintf(\"INTC isr %x, ier %x, iar %x, mer %x\\n\", intc->isr, intc->ier,\n \t\tintc->iar, intc->mer);\n #endif\n }\n@@ -159,7 +159,7 @@ int interrupts_init(void)\n \treturn 0;\n }\n \n-void interrupt_handler (void)\n+void interrupt_handler(void)\n {\n \tint irqs = intc->ivr;\t/* find active interrupt */\n \tint mask = 1;\n", "prefixes": [ "U-Boot", "v2", "4/7" ] }