Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/175280/?format=api
{ "id": 175280, "url": "http://patchwork.ozlabs.org/api/patches/175280/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1344239199-11445-3-git-send-email-monstr@monstr.eu/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1344239199-11445-3-git-send-email-monstr@monstr.eu>", "list_archive_url": null, "date": "2012-08-06T07:46:35", "name": "[U-Boot,v2,3/7] microblaze: intc: Registering interrupt should return value", "commit_ref": "8706908a2522f7d38f916e38ee13ca91e9f30bc5", "pull_url": null, "state": "accepted", "archived": false, "hash": "36e36ebb9e720316169ca95c48d8d2bf447993db", "submitter": { "id": 2237, "url": "http://patchwork.ozlabs.org/api/people/2237/?format=api", "name": "Michal Simek", "email": "monstr@monstr.eu" }, "delegate": { "id": 1714, "url": "http://patchwork.ozlabs.org/api/users/1714/?format=api", "username": "vapier", "first_name": "Mike", "last_name": "Frysinger", "email": "vapier@gentoo.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1344239199-11445-3-git-send-email-monstr@monstr.eu/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/175280/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/175280/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id CB1F12C0092\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 6 Aug 2012 17:47:25 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 921AD2813A;\n\tMon, 6 Aug 2012 09:47:16 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jmch0elQsdf6; Mon, 6 Aug 2012 09:47:16 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 4EC4228147;\n\tMon, 6 Aug 2012 09:47:04 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 7C7F7280B6\n\tfor <u-boot@lists.denx.de>; Mon, 6 Aug 2012 09:47:01 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YYaTTcTOo51s for <u-boot@lists.denx.de>;\n\tMon, 6 Aug 2012 09:47:01 +0200 (CEST)", "from mail-we0-f172.google.com (mail-we0-f172.google.com\n\t[74.125.82.172]) by theia.denx.de (Postfix) with ESMTPS id E74A3280E1\n\tfor <u-boot@lists.denx.de>; Mon, 6 Aug 2012 09:46:56 +0200 (CEST)", "by weyu54 with SMTP id u54so1855965wey.3\n\tfor <u-boot@lists.denx.de>; Mon, 06 Aug 2012 00:46:56 -0700 (PDT)", "by 10.180.105.130 with SMTP id gm2mr16198134wib.6.1344239216025;\n\tMon, 06 Aug 2012 00:46:56 -0700 (PDT)", "from localhost (nat-2.starnet.cz. [92.62.224.2])\n\tby mx.google.com with ESMTPS id\n\tef5sm21028433wib.3.2012.08.06.00.46.55\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tMon, 06 Aug 2012 00:46:55 -0700 (PDT)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references\n\t:x-gm-message-state;\n\tbh=2W2WlcThm3cKI1PDBw10xE0s0zw2V8HDHkUlIDylCus=;\n\tb=R8jWfVR1GWMGjX0Ev2bXwr/EvikCF+Rmm/HvHGaWu0fjBSUnUTmJ09sV5nQAjsuk3y\n\tfa4AzoNIBYQpdVMvaxH/3pu9JYMEstgwzjY+8J6xY7Aot1w0c6VoanMTDMwjVmJtmcYY\n\tW6JbeYC43Jg3UJUiXe4LRyMuUrCamNWBvZ/RyDKtc3wJiFJ44xaq093ZUeY5mrleSL1N\n\tYB2xRoxlg/z/V4x5Ocx+XdVP1IwsrnNdiMF2pG+VRr3aYGgdU9ejoTjI/LM7LOYFomAX\n\tWUq3A1BfIRC75Z5FeDGxV0vpe4vkO1STyK0SJGoIHdJgGQRhnAy0qsE4i0YYO7wVhci9\n\tBR1A==", "From": "Michal Simek <monstr@monstr.eu>", "To": "u-boot@lists.denx.de", "Date": "Mon, 6 Aug 2012 09:46:35 +0200", "Message-Id": "<1344239199-11445-3-git-send-email-monstr@monstr.eu>", "X-Mailer": "git-send-email 1.7.0.4", "In-Reply-To": "<1344239199-11445-1-git-send-email-monstr@monstr.eu>", "References": "<1344239199-11445-1-git-send-email-monstr@monstr.eu>", "X-Gm-Message-State": "ALoCoQnJsa4pXPiPfDabSSRWuuY/3K5kWDBgN6TPgricw6c+RsUEGTiryQOyYXjx/D+f1ztanZRv", "Cc": "linz@li-pro.net", "Subject": "[U-Boot] [PATCH v2 3/7] microblaze: intc: Registering interrupt\n\tshould return value", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "Return value to find out if un/registration was succesful.\n\nSigned-off-by: Michal Simek <monstr@monstr.eu>\n\n---\nv2: Add comment to header file to describe parameters and return codes\n---\n arch/microblaze/cpu/interrupts.c | 16 +++++++++-------\n arch/microblaze/include/asm/microblaze_intc.h | 11 ++++++++++-\n 2 files changed, 19 insertions(+), 8 deletions(-)", "diff": "diff --git a/arch/microblaze/cpu/interrupts.c b/arch/microblaze/cpu/interrupts.c\nindex ee67082..08f6bad 100644\n--- a/arch/microblaze/cpu/interrupts.c\n+++ b/arch/microblaze/cpu/interrupts.c\n@@ -91,14 +91,13 @@ static void disable_one_interrupt(int irq)\n #endif\n }\n \n-/* adding new handler for interrupt */\n-void install_interrupt_handler (int irq, interrupt_handler_t * hdlr, void *arg)\n+int install_interrupt_handler(int irq, interrupt_handler_t *hdlr, void *arg)\n {\n \tstruct irq_action *act;\n \t/* irq out of range */\n \tif ((irq < 0) || (irq > irq_no)) {\n \t\tputs (\"IRQ out of range\\n\");\n-\t\treturn;\n+\t\treturn -1;\n \t}\n \tact = &vecs[irq];\n \tif (hdlr) {\t\t/* enable */\n@@ -106,11 +105,14 @@ void install_interrupt_handler (int irq, interrupt_handler_t * hdlr, void *arg)\n \t\tact->arg = arg;\n \t\tact->count = 0;\n \t\tenable_one_interrupt (irq);\n-\t} else {\t\t/* disable */\n-\t\tact->handler = (interrupt_handler_t *) def_hdlr;\n-\t\tact->arg = (void *)irq;\n-\t\tdisable_one_interrupt (irq);\n+\t\treturn 0;\n \t}\n+\n+\t/* Disable */\n+\tact->handler = (interrupt_handler_t *) def_hdlr;\n+\tact->arg = (void *)irq;\n+\tdisable_one_interrupt(irq);\n+\treturn 1;\n }\n \n /* initialization interrupt controller - hardware */\ndiff --git a/arch/microblaze/include/asm/microblaze_intc.h b/arch/microblaze/include/asm/microblaze_intc.h\nindex 6142b9c..e9640f5 100644\n--- a/arch/microblaze/include/asm/microblaze_intc.h\n+++ b/arch/microblaze/include/asm/microblaze_intc.h\n@@ -39,7 +39,16 @@ struct irq_action {\n \tint count; /* number of interrupt */\n };\n \n-void install_interrupt_handler (int irq, interrupt_handler_t * hdlr,\n+/**\n+ * Register and unregister interrupt handler rutines\n+ *\n+ * @param irq\tIRQ number\n+ * @param hdlr\tInterrupt handler rutine\n+ * @param arg\tPointer to argument which is passed to int. handler rutine\n+ * @return\t0 if registration pass, 1 if unregistration pass,\n+ *\t\tor an error code < 0 otherwise\n+ */\n+int install_interrupt_handler(int irq, interrupt_handler_t *hdlr,\n \t\t\t\t void *arg);\n \n int interrupts_init(void);\n", "prefixes": [ "U-Boot", "v2", "3/7" ] }