Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745965/?format=api
{ "id": 1745965, "url": "http://patchwork.ozlabs.org/api/patches/1745965/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-36-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-36-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:19:01", "name": "[RFC,u-boot-mvebu,35/59] tools: kwbimage: Fix generating of kwbimage v0 header checksum", "commit_ref": "ee3da92d85aea4dad6d6d7c82b23407b85547325", "pull_url": null, "state": "accepted", "archived": false, "hash": "1bdffacb06619518e29afb91a082fdcd8289abab", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-36-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745965/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=C4Qp9BJM;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"C4Qp9BJM\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLvbR6P8vz240n\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 09:48:51 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 777B485942;\n\tTue, 21 Feb 2023 23:48:49 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id A071D85942; Tue, 21 Feb 2023 23:48:47 +0100 (CET)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2842C85A58\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 23:48:45 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id ED6B461085\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 22:48:43 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 4301BC433EF\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 22:48:43 +0000 (UTC)", "by pali.im (Postfix)\n id 18D1C9E0; Tue, 21 Feb 2023 23:48:41 +0100 (CET)", "by pali.im (Postfix)\n id 945029E0; Tue, 21 Feb 2023 21:22:33 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677019723;\n bh=Lv1/ersee8dbi9RRCaX4F8jXTGUMhE99E3qfr0vRu4Y=;\n h=Resent-From:Resent-Date:Resent-To:From:To:Cc:Subject:Date:\n In-Reply-To:References:From;\n b=C4Qp9BJM5LviAKISNtSvi3lwcNXphBLppRUeP1434H45W5FCyv50Js80bKnJPRU8X\n pcX5VA4wzEWMvP9vA4jw4FB6TC5lGzzLJX0H3BpolG5wcxemV2nd/DMP7yU5MJzr3X\n IXBbKuEbLNB43AI1j7hEIXFqlbnXOWz3yJpLWsXn03ozpSxsNc6cBBSYxXmRadu5r4\n BO6aiPTASVmHX6JjKYzAgb53j7+ggoEHZBT+wnkPS25nMsjTKxnuPOONS1TeB9Zrwv\n f34F9BURMCTUQtBhhWohIXAOIrnr1NqpR/7quNl3ElQTXBCF11Co5KYnudmWLD3XAd\n HkDVAgVROm9cA==", "Resent-From": "Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>", "Resent-Date": "Tue, 21 Feb 2023 23:48:40 +0100", "Resent-Message-ID": "<20230221224840.r6kb756km573iecr@pali>", "Resent-To": "u-boot@lists.denx.de", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 35/59] tools: kwbimage: Fix generating of\n kwbimage v0 header checksum", "Date": "Tue, 21 Feb 2023 21:19:01 +0100", "Message-Id": "<20230221201925.9644-36-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Checksum for v0 image must be generated after filling all fields in the\nmain header. Otherwise it would be invalid.\n\nExactly same problem for v1 images was already fixed in the past in commit\n9203c73895ab (\"tools: kwbimage: Fix checksum calculation for v1 images\").\n\nFixes: 5c61710c9880 (\"tools: kwbimage: Properly set srcaddr in kwbimage v0\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n tools/kwbimage.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/tools/kwbimage.c b/tools/kwbimage.c\nindex b6deb978f611..1128c934dda9 100644\n--- a/tools/kwbimage.c\n+++ b/tools/kwbimage.c\n@@ -1009,8 +1009,6 @@ static void *image_create_v0(size_t *imagesz, struct image_tool_params *params,\n \te = image_find_option(IMAGE_CFG_NAND_BADBLK_LOCATION);\n \tif (e)\n \t\tmain_hdr->nandbadblklocation = e->nandbadblklocation;\n-\tmain_hdr->checksum = image_checksum8(image,\n-\t\t\t\t\t sizeof(struct main_hdr_v0));\n \n \t/*\n \t * For SATA srcaddr is specified in number of sectors.\n@@ -1049,6 +1047,9 @@ static void *image_create_v0(size_t *imagesz, struct image_tool_params *params,\n \t\t\t\t\t\t sizeof(struct ext_hdr_v0));\n \t}\n \n+\tmain_hdr->checksum = image_checksum8(image,\n+\t\t\t\t\t sizeof(struct main_hdr_v0));\n+\n \t*imagesz = headersz;\n \treturn image;\n }\n", "prefixes": [ "RFC", "u-boot-mvebu", "35/59" ] }