Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745964/?format=api
{ "id": 1745964, "url": "http://patchwork.ozlabs.org/api/patches/1745964/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-34-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-34-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:18:59", "name": "[RFC,u-boot-mvebu,33/59] tools: kwbimage: Fix dumping NAND_BADBLK_LOCATION", "commit_ref": "e060779e59e79f8b1ff85ae03502e4a19c414608", "pull_url": null, "state": "accepted", "archived": false, "hash": "0ce7037cc7370c8c5be61edc73b91dfffe3c56fd", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-34-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745964/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745964/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BhiwnFXq;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"BhiwnFXq\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLvbB5DdLz240n\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 09:48:38 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1F8A6859FF;\n\tTue, 21 Feb 2023 23:48:36 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 0112485A6E; Tue, 21 Feb 2023 23:48:35 +0100 (CET)", "from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D86A88590C\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 23:48:32 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 8EB92B80F01\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 22:48:32 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 3AD7DC433D2\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 22:48:31 +0000 (UTC)", "by pali.im (Postfix)\n id D543670C; Tue, 21 Feb 2023 23:48:28 +0100 (CET)", "by pali.im (Postfix)\n id 3A83EAC9; Tue, 21 Feb 2023 21:22:33 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677019711;\n bh=xCC8OtSsBGFUjuRKKL+YNDZV7fqZR5dR1S1qfkK+4qY=;\n h=Resent-From:Resent-Date:Resent-To:From:To:Cc:Subject:Date:\n In-Reply-To:References:From;\n b=BhiwnFXqu9AEXOiEEMSPad7GFRUW6kgvvVWtnr34wZfDEuei34lFVNVSB4OavFsTZ\n L6vV5CigpXITRbc/v5N4Wo9u0zRfGOKxo5+Ys+8JIZYJqoiBwEB4kUC6WOyiMJcgLZ\n MJY7n7tSekm8JYMJcQEWtoKlKcXeewmlbk4JlcOVbiFWyA/eX25VR0od6AKwuHwYuR\n 1G5u2nn8nvEWiZICMWQuV6s3CFbUgXKdhA4m0W2ZRQxfaycuBC6yBEFu6Dz0CbiWLT\n puaZR8QWbGcDL4steTAR5jEHPr2sUfXEwMTFERtrRHAvcZbQYgL6L9YM0DWKqh8WyI\n sJxfj/JkOEHyw==", "Resent-From": "Pali =?utf-8?b?Um9ow6Fy?= <pali@kernel.org>", "Resent-Date": "Tue, 21 Feb 2023 23:48:28 +0100", "Resent-Message-ID": "<20230221224828.vtso65bfvk5p4giu@pali>", "Resent-To": "u-boot@lists.denx.de", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 33/59] tools: kwbimage: Fix dumping\n NAND_BADBLK_LOCATION", "Date": "Tue, 21 Feb 2023 21:18:59 +0100", "Message-Id": "<20230221201925.9644-34-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Value 0x0 for NAND_BADBLK_LOCATION/nandbadblklocation means that BBI is on\nthe first or second page and value 0x1 means that BBI is on the last page.\nThis indicates also NAND Flash Technology, value 0x0 is SLC NAND and value\n0x1 is MLC NAND.\n\nTherefore we need to dump NAND_BADBLK_LOCATION also when it is zero.\n\nNote that in v0 images, nandbadblklocation field overlaps with ddrinitdelay\nfield in one union. ddrinitdelay is used in Kirkwood and nandbadblklocation\nis used in Dove. For Dove images is_v0_ext should be set, so use it to\ndistinguish if nandbadblklocation is available or not. In v1 images there\nis always nandbadblklocation field.\n\nFixes: 1a8e6b63e24f (\"tools: kwbimage: Dump kwbimage config file on '-p -1' option\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n tools/kwbimage.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/tools/kwbimage.c b/tools/kwbimage.c\nindex a6f6f1578c79..4e9ba5ddfae2 100644\n--- a/tools/kwbimage.c\n+++ b/tools/kwbimage.c\n@@ -2187,7 +2187,7 @@ static int kwbimage_generate_config(void *ptr, struct image_tool_params *params)\n \tif (version != 0 && mhdr->blockid == IBR_HDR_NAND_ID)\n \t\tfprintf(f, \"NAND_BLKSZ 0x%x\\n\", (unsigned)mhdr->nandblocksize);\n \n-\tif (mhdr->blockid == IBR_HDR_NAND_ID && (mhdr->nandbadblklocation != 0 || is_v0_ext))\n+\tif (mhdr->blockid == IBR_HDR_NAND_ID && (version != 0 || is_v0_ext))\n \t\tfprintf(f, \"NAND_BADBLK_LOCATION 0x%x\\n\", (unsigned)mhdr->nandbadblklocation);\n \n \tif (version == 0 && mhdr->blockid == IBR_HDR_SATA_ID)\n", "prefixes": [ "RFC", "u-boot-mvebu", "33/59" ] }