Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745920/?format=api
{ "id": 1745920, "url": "http://patchwork.ozlabs.org/api/patches/1745920/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-39-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-39-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:19:04", "name": "[RFC,u-boot-mvebu,38/59] tools: kwbimage: Add support for dumping NAND_BLKSZ for v0 images", "commit_ref": "0a3a392c7122fccc1977d026cea9e48652b75688", "pull_url": null, "state": "accepted", "archived": false, "hash": "865ba7a02cfa2de299a50934b5422e04466c46ed", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-39-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745920/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745920/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PoREGtS8;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"PoREGtS8\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrgP19hWz240n\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:37:05 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B284E85B66;\n\tTue, 21 Feb 2023 21:25:53 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 2AD7F85B22; Tue, 21 Feb 2023 21:24:03 +0100 (CET)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1874C85B26\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:47 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id B1A43611EB;\n Tue, 21 Feb 2023 20:22:34 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 65BA1C4339C;\n Tue, 21 Feb 2023 20:22:34 +0000 (UTC)", "by pali.im (Postfix)\n id 225579FC; Tue, 21 Feb 2023 21:22:34 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010954;\n bh=IJlkqX9LHekWOg3vN0LLbPJUlyi/ctvcPZwWmBcWmnA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=PoREGtS8YdfefTNK1Q9Xilcj5iGJXOXdsvHWB7iqnUhjriQCJ9PdpdY8hHs3pG4If\n 5R7bqxMa6h1pK10yhRCgyK1d3DtNyROZyjYfD7DffMJL5MwXHZvYCxzflWpdBaIE0f\n QzO2EBw3B02yFPHvL0bGEorl2hekJO9fk252BsZTMzv34nDjfk7AdtRFCaX+h91+9j\n wWKlGabUPTjfPs6lW1t0Hbu7cQZY5FUAPoj1820TkBE4pcfacR8dRVG/+rPJJtDqhp\n jR9DQy5lrXEpJpsDoRhzhlJnWYSyzrzasNyXqcusUo11z7mJLbXhSu940js/zkD3Iv\n bJr5kDedtf6Cg==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 38/59] tools: kwbimage: Add support for\n dumping NAND_BLKSZ for v0 images", "Date": "Tue, 21 Feb 2023 21:19:04 +0100", "Message-Id": "<20230221201925.9644-39-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In Dove functional specification, which use kwbimage v0, is also defined\nnand block size field. So dump NAND_BLKSZ also for v0 images.\n\nIn Kirkwood functional specification, which also use kwbimage v0, this\nfield is not defined. So when it is zero and Kirkwood is detected, do not\ndump it.\n\nFixes: f76ae2571fe0 (\"tools: kwbimage: Add support for dumping extended and binary v0 headers\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n tools/kwbimage.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/tools/kwbimage.c b/tools/kwbimage.c\nindex 0c3b40d075e9..eb99ac944d24 100644\n--- a/tools/kwbimage.c\n+++ b/tools/kwbimage.c\n@@ -2185,7 +2185,7 @@ static int kwbimage_generate_config(void *ptr, struct image_tool_params *params)\n \tif (mhdr->blockid == IBR_HDR_NAND_ID)\n \t\tfprintf(f, \"NAND_PAGE_SIZE 0x%x\\n\", (unsigned)le16_to_cpu(mhdr->nandpagesize));\n \n-\tif (version != 0 && mhdr->blockid == IBR_HDR_NAND_ID) {\n+\tif (mhdr->blockid == IBR_HDR_NAND_ID && (version != 0 || is_v0_ext || mhdr->nandblocksize != 0)) {\n \t\tif (mhdr->nandblocksize != 0) /* block size explicitly set in 64 kB unit */\n \t\t\tfprintf(f, \"NAND_BLKSZ 0x%x\\n\", (unsigned)mhdr->nandblocksize * 64*1024);\n \t\telse if (le16_to_cpu(mhdr->nandpagesize) > 512)\n", "prefixes": [ "RFC", "u-boot-mvebu", "38/59" ] }