Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745913/?format=api
{ "id": 1745913, "url": "http://patchwork.ozlabs.org/api/patches/1745913/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-24-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-24-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:18:49", "name": "[RFC,u-boot-mvebu,23/59] cmd: mvebu/bubt: Rename variable image_size to hdr_size", "commit_ref": "e7813da07a21001fe13a1adf838bff43330091ca", "pull_url": null, "state": "accepted", "archived": false, "hash": "f25fc8d020239389f1526a665f56f0acfbe632a3", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-24-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745913/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745913/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AfXqwUwO;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"AfXqwUwO\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrdW2P0tz240n\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:35:27 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E3CCB85BB4;\n\tTue, 21 Feb 2023 21:25:30 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id C62E385AAC; Tue, 21 Feb 2023 21:24:01 +0100 (CET)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A2B2785B39\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:46 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id D9F8B611E1;\n Tue, 21 Feb 2023 20:22:33 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 8EB61C4339B;\n Tue, 21 Feb 2023 20:22:33 +0000 (UTC)", "by pali.im (Postfix)\n id 2FAFBA8C; Tue, 21 Feb 2023 21:22:31 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010953;\n bh=n3GVFqY2at2QIHEQRAOYT+nen1VKeY8VQUUWPi4n3p4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=AfXqwUwOtxd8kic6pjOKCZnkKWRWLyDIaWxqCKpXeQnPoLGkeYBD+/NDIve7iYFak\n ORqyRSeGjUwFykzZcpGvgA6fcFA4bDC3kP31F72aARKGHfdzGXLslwfPJAOPoxe6Ml\n hJG2APA+ZpCaku0f84r2NLTu0csptBTM0wHs9p4RiiQaH3XKtJ4B2xPM9XT+/6bGB2\n w3T4zU5LtKPOO+D5B57n//SUQKjbgnPe1Rr0POumRrf5xonMpiYrpVbtb25gIS0PAw\n UXqmtiv0AROMFH3ccO5zXb+zHhg+Y3ioueH0J08QTwcpkWpcHPbjCRpR170U0OIEc0\n ysct/22sJ7khQ==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 23/59] cmd: mvebu/bubt: Rename variable\n image_size to hdr_size", "Date": "Tue, 21 Feb 2023 21:18:49 +0100", "Message-Id": "<20230221201925.9644-24-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Variable image_size contains size of the header, not size of the whole\nimage. Rename this variable to reflect content.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n cmd/mvebu/bubt.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c\nindex df6b73c6a172..72ed87b89ec3 100644\n--- a/cmd/mvebu/bubt.c\n+++ b/cmd/mvebu/bubt.c\n@@ -905,12 +905,12 @@ static int check_image_header(void)\n \tu32 offset, size;\n \tconst struct a38x_main_hdr_v1 *hdr =\n \t\t(struct a38x_main_hdr_v1 *)get_load_addr();\n-\tconst size_t image_size = a38x_header_size(hdr);\n+\tconst size_t hdr_size = a38x_header_size(hdr);\n \n-\tif (!image_size)\n+\tif (!hdr_size)\n \t\treturn -ENOEXEC;\n \n-\tchecksum = image_checksum8(hdr, image_size);\n+\tchecksum = image_checksum8(hdr, hdr_size);\n \tchecksum -= hdr->checksum;\n \tif (checksum != hdr->checksum) {\n \t\tprintf(\"Error: Bad A38x image header checksum. 0x%x != 0x%x\\n\",\n@@ -944,7 +944,7 @@ static int check_image_header(void)\n #if defined(CONFIG_ARMADA_38X)\n static int a38x_image_is_secure(const struct a38x_main_hdr_v1 *hdr)\n {\n-\tu32 image_size = a38x_header_size(hdr);\n+\tconst size_t hdr_size = a38x_header_size(hdr);\n \tstruct a38x_opt_hdr_v1 *ohdr;\n \tu32 ohdr_size;\n \n@@ -965,7 +965,7 @@ static int a38x_image_is_secure(const struct a38x_main_hdr_v1 *hdr)\n \t\t\tbreak;\n \n \t\tohdr = (struct a38x_opt_hdr_v1 *)((u8 *)ohdr + ohdr_size);\n-\t\tif ((u8 *)ohdr >= (u8 *)hdr + image_size)\n+\t\tif ((u8 *)ohdr >= (u8 *)hdr + hdr_size)\n \t\t\tbreak;\n \t} while (1);\n \n", "prefixes": [ "RFC", "u-boot-mvebu", "23/59" ] }