Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745911/?format=api
{ "id": 1745911, "url": "http://patchwork.ozlabs.org/api/patches/1745911/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-35-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-35-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:19:00", "name": "[RFC,u-boot-mvebu,34/59] tools: kwbimage: Fix dumping NAND_BLKSZ", "commit_ref": "226abde8677537de55905d88973eef1a71b4d3e0", "pull_url": null, "state": "accepted", "archived": false, "hash": "a6e82a3c57b92f2a7dac9de18b8a637c7aa7e3b7", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-35-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745911/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745911/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hmwCRXD9;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"hmwCRXD9\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrcf5zxkz23j7\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:34:42 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D0BB485A72;\n\tTue, 21 Feb 2023 21:25:24 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 4799285ACB; Tue, 21 Feb 2023 21:24:02 +0100 (CET)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BC65085B33\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:46 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 015F8611E4;\n Tue, 21 Feb 2023 20:22:34 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id AB2A7C4339E;\n Tue, 21 Feb 2023 20:22:33 +0000 (UTC)", "by pali.im (Postfix)\n id 69AF1ADB; Tue, 21 Feb 2023 21:22:33 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010953;\n bh=RSHGLVBdlV9Djgrl6sLHbvX3WMl0bmz/3lqXV/Zx0hw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=hmwCRXD9XtjdhBMhd2KXwJ6YGgTM/x5XfVtN78iwGsjaY4LdfXg2FKODgdpHJeKiN\n DiqkGy632mCuLqufixk+V7k7pCS/Xj06w1I+QmEQiOLpblr5BzCJn5QphCYWHzIqeA\n ZtjJhzi53ljXLOLXwjLvYY6ZdUx5kVMXuPLmvMJzx3oD7IZ1m7d4+dN1m35fLTCnFM\n 9ZWNEQJT4BKCRCEBHj8ghnohtZuM1F4gPOp3iC8K1E+sh8YnW/GZKJhmL6qLXIj1lm\n yAytv2fQ8H23XRDMTsumbGRGdeEddtWRK2a2CJWxa1X6ccI5c8NgMEzJX2nuSIA2aF\n BO5exiujqu/Qg==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 34/59] tools: kwbimage: Fix dumping\n NAND_BLKSZ", "Date": "Tue, 21 Feb 2023 21:19:00 +0100", "Message-Id": "<20230221201925.9644-35-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "kwbimage nandblocksize field is in 64 kB unit, but NAND_BLKSZ command\nexpects it in bytes. So do required unit conversion.\n\nAlso zero value in nandblocksize field has special meaning. When this field\nis set to zero, the default block size is used. This default size is\ndefined by the NAND flash page size (16 KB for a 512B page or small page\nNAND and 64 KB for a large page NAND flash).\n\nFixes: 1a8e6b63e24f (\"tools: kwbimage: Dump kwbimage config file on '-p -1' option\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n tools/kwbimage.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/tools/kwbimage.c b/tools/kwbimage.c\nindex 4e9ba5ddfae2..b6deb978f611 100644\n--- a/tools/kwbimage.c\n+++ b/tools/kwbimage.c\n@@ -2184,8 +2184,14 @@ static int kwbimage_generate_config(void *ptr, struct image_tool_params *params)\n \tif (mhdr->blockid == IBR_HDR_NAND_ID)\n \t\tfprintf(f, \"NAND_PAGE_SIZE 0x%x\\n\", (unsigned)le16_to_cpu(mhdr->nandpagesize));\n \n-\tif (version != 0 && mhdr->blockid == IBR_HDR_NAND_ID)\n-\t\tfprintf(f, \"NAND_BLKSZ 0x%x\\n\", (unsigned)mhdr->nandblocksize);\n+\tif (version != 0 && mhdr->blockid == IBR_HDR_NAND_ID) {\n+\t\tif (mhdr->nandblocksize != 0) /* block size explicitly set in 64 kB unit */\n+\t\t\tfprintf(f, \"NAND_BLKSZ 0x%x\\n\", (unsigned)mhdr->nandblocksize * 64*1024);\n+\t\telse if (le16_to_cpu(mhdr->nandpagesize) > 512)\n+\t\t\tfprintf(f, \"NAND_BLKSZ 0x10000\\n\"); /* large page NAND flash = 64 kB block size */\n+\t\telse\n+\t\t\tfprintf(f, \"NAND_BLKSZ 0x4000\\n\"); /* small page NAND flash = 16 kB block size */\n+\t}\n \n \tif (mhdr->blockid == IBR_HDR_NAND_ID && (version != 0 || is_v0_ext))\n \t\tfprintf(f, \"NAND_BADBLK_LOCATION 0x%x\\n\", (unsigned)mhdr->nandbadblklocation);\n", "prefixes": [ "RFC", "u-boot-mvebu", "34/59" ] }