Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745898/?format=api
{ "id": 1745898, "url": "http://patchwork.ozlabs.org/api/patches/1745898/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-46-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-46-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:19:11", "name": "[RFC,u-boot-mvebu,45/59] tools: mkimage: Do not fill legacy_img_hdr for non-legacy XIP images", "commit_ref": "27670acaac82f370b635f1af103594a335322bcf", "pull_url": null, "state": "accepted", "archived": false, "hash": "4d6598017952819e4280a21c3f949b9fcea5922e", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-46-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745898/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745898/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=rHv7X8R7;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"rHv7X8R7\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrYj4gzwz23j7\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:32:09 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AFCA085B37;\n\tTue, 21 Feb 2023 21:24:23 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id B133785B23; Tue, 21 Feb 2023 21:23:47 +0100 (CET)", "from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E393485B12\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:44 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id DDF2AB810C6;\n Tue, 21 Feb 2023 20:22:36 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 6DF86C4339B;\n Tue, 21 Feb 2023 20:22:35 +0000 (UTC)", "by pali.im (Postfix)\n id 29EB1A8C; Tue, 21 Feb 2023 21:22:35 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010955;\n bh=PT4l4+FoTdylxdaox+KIk/b05fz52yB/7zNpvfFJ7yI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=rHv7X8R7TtVUaqxSJQYkqnrnVG8tmisc5KE8mlhcjNRiLoQxKv23YLQpV6QjLJ2jJ\n GXrLk8spj80txe+IFbQbNgoJFU2R4JzwWm82VbXZdA5cAfCa0F3HFa/zJR402IM7A4\n 5r4pGAHQ9uiwH9S+XfJU9LmVKkN3jf0FQY0kKneietbNGpBZFWERl4CLzZYLlhZKWj\n aEzgGfFhBE5PnwSYg/SC/b7/tokZXX3NAztzCO1MzAtXbrmz9OAZksl0lgClJ25MT4\n WhXGBMgzl5zHcDzqlATzEHyYRvTdNyijedSHPo0RCnNzyTdFmo4l94Z7OSntawn6QN\n +WYUSvIWwNhdA==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 45/59] tools: mkimage: Do not fill\n legacy_img_hdr for non-legacy XIP images", "Date": "Tue, 21 Feb 2023 21:19:11 +0100", "Message-Id": "<20230221201925.9644-46-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Skip filling legacy_img_hdr structure for XIP images which do not use\nlegacy_img_hdr structure header. Adding unwanted header to other image\nformats, like kwbimage cause generation of broken image.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n tools/mkimage.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/tools/mkimage.c b/tools/mkimage.c\nindex 30c6df77081f..955a1f39a419 100644\n--- a/tools/mkimage.c\n+++ b/tools/mkimage.c\n@@ -842,7 +842,9 @@ copy_file (int ifd, const char *datafile, int pad)\n \t\texit (EXIT_FAILURE);\n \t}\n \n-\tif (params.xflag) {\n+\tif (params.xflag &&\n+\t (((params.type > IH_TYPE_INVALID) && (params.type < IH_TYPE_FLATDT)) ||\n+\t (params.type == IH_TYPE_KERNEL_NOLOAD) || (params.type == IH_TYPE_FIRMWARE_IVT))) {\n \t\tunsigned char *p = NULL;\n \t\t/*\n \t\t * XIP: do not append the struct legacy_img_hdr at the\n", "prefixes": [ "RFC", "u-boot-mvebu", "45/59" ] }