Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745884/?format=api
{ "id": 1745884, "url": "http://patchwork.ozlabs.org/api/patches/1745884/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-27-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-27-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:18:52", "name": "[RFC,u-boot-mvebu,26/59] cmd: mvebu/bubt: Check also A8K boot image checksum", "commit_ref": "f5860c567b1f150141b919df573a8bdeb346a7ed", "pull_url": null, "state": "accepted", "archived": false, "hash": "2aefbf6a0daf183950ce7f130b1eb6cfd8110a01", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-27-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745884/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745884/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=cMKJ/3b5;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"cMKJ/3b5\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrS74D11z23yr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:27:19 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8A5A585AC6;\n\tTue, 21 Feb 2023 21:23:34 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 49A6F85A32; Tue, 21 Feb 2023 21:22:54 +0100 (CET)", "from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1A20D85A96\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:33 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id AE617B810C5;\n Tue, 21 Feb 2023 20:22:32 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 31D7FC433AF;\n Tue, 21 Feb 2023 20:22:32 +0000 (UTC)", "by pali.im (Postfix)\n id E27B4ADB; Tue, 21 Feb 2023 21:22:31 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010952;\n bh=TbpUPu9jmPfSTUPqanNhsXxoAVp2FwCv+85gsSPgJfM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=cMKJ/3b53bcrm+jf46xRTNVkQuAZXKfxKb5g6kWeATZXBPlFYmIoVqxZYGslzvXYJ\n uUlStH9VAH6HQTbejNqBsje1RxYUtMEgqa1RzJcSTqciKDVQoYsw1jYxXU+NqhVmuQ\n t/HLefJmW0tNNjgMc6EslVNU8tvTA17o1PjXuj4KOR6nGzj8Ungb28HB+3cC9YxljD\n b0Tj0s8WuxuxOOxyT//DZXwn0lvocZuUX9kK3UvGnES5+4lGeOgI9dO2o9eK28DQK6\n xj6dX+iNpmNWSJnye3ocOwJcw0znV/Hi4BpG1ZUE1eSAwpebhAPlUUD/Qkke8kPT+e\n AIOr8/4O6oc2w==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 26/59] cmd: mvebu/bubt: Check also A8K boot\n image checksum", "Date": "Tue, 21 Feb 2023 21:18:52 +0100", "Message-Id": "<20230221201925.9644-27-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Signed-off-by: Pali Rohár <pali@kernel.org>\n---\n cmd/mvebu/bubt.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c\nindex 1b08ca9298c2..74ea037dda98 100644\n--- a/cmd/mvebu/bubt.c\n+++ b/cmd/mvebu/bubt.c\n@@ -725,9 +725,8 @@ static int check_image_header(void)\n {\n \tstruct mvebu_image_header *hdr =\n \t\t\t(struct mvebu_image_header *)get_load_addr();\n-\tu32 header_len = hdr->prolog_size;\n \tu32 checksum;\n-\tu32 checksum_ref = hdr->prolog_checksum;\n+\tu32 checksum_ref;\n \n \t/*\n \t * For now compare checksum, and magic. Later we can\n@@ -739,8 +738,17 @@ static int check_image_header(void)\n \t\treturn -ENOEXEC;\n \t}\n \n-\tchecksum = do_checksum32((u32 *)hdr, header_len);\n+\tchecksum_ref = hdr->prolog_checksum;\n+\tchecksum = do_checksum32((u32 *)hdr, hdr->prolog_size);\n \tchecksum -= hdr->prolog_checksum;\n+\tif (checksum != checksum_ref) {\n+\t\tprintf(\"Error: Bad Prolog checksum. 0x%x != 0x%x\\n\",\n+\t\t checksum, checksum_ref);\n+\t\treturn -ENOEXEC;\n+\t}\n+\n+\tchecksum_ref = hdr->boot_image_checksum;\n+\tchecksum = do_checksum32((u32 *)((u8 *)hdr + hdr->prolog_size), hdr->boot_image_size);\n \tif (checksum != checksum_ref) {\n \t\tprintf(\"Error: Bad Image checksum. 0x%x != 0x%x\\n\",\n \t\t checksum, checksum_ref);\n", "prefixes": [ "RFC", "u-boot-mvebu", "26/59" ] }