Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1745882/?format=api
{ "id": 1745882, "url": "http://patchwork.ozlabs.org/api/patches/1745882/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-7-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20230221201925.9644-7-pali@kernel.org>", "list_archive_url": null, "date": "2023-02-21T20:18:32", "name": "[RFC,u-boot-mvebu,06/59] tools: kwboot: Fix parsing SATA kwbimage", "commit_ref": "e1c4ed57d5190e3064ae10ae3a87cdc75d2786fc", "pull_url": null, "state": "accepted", "archived": false, "hash": "b8ead3e88e309bf4141c4acff082ede52fcb68de", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-7-pali@kernel.org/mbox/", "series": [ { "id": 343058, "url": "http://patchwork.ozlabs.org/api/series/343058/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=343058", "date": "2023-02-21T20:18:27", "name": "arm: mvebu: Various fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/343058/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1745882/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1745882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pJLwtDg/;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"pJLwtDg/\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrRL3G5Cz23yr\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:26:38 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C29A985A5A;\n\tTue, 21 Feb 2023 21:23:18 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 2722D85A79; Tue, 21 Feb 2023 21:22:50 +0100 (CET)", "from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B89A085A87\n for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:32 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 600BCB81020;\n Tue, 21 Feb 2023 20:22:32 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id A9D95C433A4;\n Tue, 21 Feb 2023 20:22:30 +0000 (UTC)", "by pali.im (Postfix)\n id 741E4ADB; Tue, 21 Feb 2023 21:22:28 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010950;\n bh=xSX/rlfRJBejuh8d7G2S1BndO2lZwjjzKseYY5GFMb0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pJLwtDg/ES2SLDxn7nuI6XRQFnkBWwncnJkRRRScwESyAppuQxokyOg+lprMa9as4\n Gv0o1SU2ZJMU1zm7yCy4Kw0tBPD88VCU4uv9Kx8QUBjZjts/fwndA4mp8nWeC9LNRf\n bj0kjnfTv/NY1KRUYMoAD+gF11D6w3uNZYIshnQW0QDN/aPXz+VrUDHNvWhELIwX72\n AWizfEdG/e20KS6QsjYt0+QfSInXyAlM/nqGTqp7ypmAGF3qRm7ClvLnMRIgEHyzF+\n siOYTP2sVkCKozdKchgGsWMpXhBKmXAeDOrqZBhFCVc8DS9+LmjQvYPmdhtbrExalh\n lo5Q9zT7qer3Q==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "u-boot@lists.denx.de", "Cc": "Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>,\n Josua Mayer <josua@solid-run.com>", "Subject": "[PATCH RFC u-boot-mvebu 06/59] tools: kwboot: Fix parsing SATA\n kwbimage", "Date": "Tue, 21 Feb 2023 21:18:32 +0100", "Message-Id": "<20230221201925.9644-7-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20230221201925.9644-1-pali@kernel.org>", "References": "<20230221201925.9644-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Despite the official specification, Marvell BootROM does not interpret\nsrcaddr from SATA image as number of sectors the beginning of the hard\ndrive, but as number of sectors relative to the main header.\n\nTo parse SATA kwbimage in the same way as Marvell BootROM, it is needed to\ninterpret srcaddr as relative offset to the main header. This change fixes\nloading of SATA images via kwboot over UART.\n\nFixes: 792e42355083 (\"tools: kwboot: Patch source address in image header\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n tools/kwboot.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/tools/kwboot.c b/tools/kwboot.c\nindex 188f944263fa..bf410520de63 100644\n--- a/tools/kwboot.c\n+++ b/tools/kwboot.c\n@@ -1888,10 +1888,7 @@ kwboot_img_patch(void *img, size_t *size, int baudrate)\n \n \tswitch (hdr->blockid) {\n \tcase IBR_HDR_SATA_ID:\n-\t\tif (srcaddr < 1)\n-\t\t\tgoto err;\n-\n-\t\thdr->srcaddr = cpu_to_le32((srcaddr - 1) * 512);\n+\t\thdr->srcaddr = cpu_to_le32(srcaddr * 512);\n \t\tbreak;\n \n \tcase IBR_HDR_PEX_ID:\n", "prefixes": [ "RFC", "u-boot-mvebu", "06/59" ] }