Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1707780/?format=api
{ "id": 1707780, "url": "http://patchwork.ozlabs.org/api/patches/1707780/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20221122100759.208290-15-benjamin@sipsolutions.net/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20221122100759.208290-15-benjamin@sipsolutions.net>", "list_archive_url": null, "date": "2022-11-22T10:07:45", "name": "[v2,14/28] um: Remove stub-data.h include from common-offsets.h", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "7370823f4f3d37cac4e4a9a44ede2db3e9a56913", "submitter": { "id": 67525, "url": "http://patchwork.ozlabs.org/api/people/67525/?format=api", "name": "Benjamin Berg", "email": "benjamin@sipsolutions.net" }, "delegate": { "id": 54851, "url": "http://patchwork.ozlabs.org/api/users/54851/?format=api", "username": "rw", "first_name": "Richard", "last_name": "Weinberger", "email": "richard@nod.at" }, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20221122100759.208290-15-benjamin@sipsolutions.net/mbox/", "series": [ { "id": 329466, "url": "http://patchwork.ozlabs.org/api/series/329466/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=329466", "date": "2022-11-22T10:07:37", "name": "Implement SECCOMP based userland", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/329466/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1707780/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1707780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=i0+yNEik;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=TwC4urX4;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=sipsolutions.net header.i=@sipsolutions.net\n header.a=rsa-sha256 header.s=mail header.b=qrQgda8v;\n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4NGgRr3H3tz23nm\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Nov 2022 21:27:20 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQUf-007o7W-B8; Tue, 22 Nov 2022 10:27:09 +0000", "from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQTN-007nKg-EB\n\tfor linux-um@bombadil.infradead.org; Tue, 22 Nov 2022 10:25:49 +0000", "from s3.sipsolutions.net ([2a01:4f8:191:4433::2]\n helo=sipsolutions.net)\n\tby desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQF1-003P1s-1K\n\tfor linux-um@lists.infradead.org; Tue, 22 Nov 2022 10:11:02 +0000", "by sipsolutions.net with esmtpsa\n (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim 4.96)\n\t(envelope-from <benjamin@sipsolutions.net>)\n\tid 1oxQEp-006IGn-2W;\n\tTue, 22 Nov 2022 11:10:47 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=U8LRUC/w50SbwxVFZnzBXTRz2MtfsfoxMaTcFeJTUO0=; b=i0+yNEik+jhhsR\n\tHwBp9n8fAwrLL5kHPSzz995l1WdozZQd4IJZV6HXcAESfQBT2YoDnJyHVP+5BF5Hewn7JCcrht9Oe\n\t3MuacOAhPXgyOYPU5g10+r+b98xKKkNQA8RvntzX7qUi9mWKf8+IL2usZDC/Uxa2Kdtl+IY/FlIHq\n\tHSIH8cYBt97cqUXDQfrdbID5n7yDYj4QXh7WuqsknLpJ0EiR1pfy/T7bW33kuMHunF6UE+eZ5WjKa\n\thxb8HIs+GX4eVIYxVGpa7mHjwNePra0hkcCk0nCC97xNdTE9kjnhDB/Ei1aXskRQASx8T3Xdhqso3\n\tQbiZQ6qPjZdzucKEgOeg==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version\n\t:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:\n\tContent-Type:Content-ID:Content-Description;\n\tbh=DSZ5KWDl/z52RVWNk2bHbNpZglcD5PTtXIhz0rCVKEE=; b=TwC4urX4tcqYTKWLRtCnVTSyfX\n\tzT/HyD1/+07We0QLy1l7HzOasMJYoDc4s9s+oMDMml4ZWurVgDYcpQ6+sYNogmF9iDmBy20FOhJpL\n\t8MwIAbfwBn7Gi5SUlFk5btMB5mTdxyQ935bUtdQysZp/Nd8JuKxRw2v3PTAweEnakx7o9JDDZZ/fm\n\t6tDnj6f2zdZhqsao9LVhVPvFxyzDuawCKdC6sFGgymMD52pUBPxVbi/dnHpe54XWOGehAsYrbz/m/\n\tsQGhEXmIDVaSjKeKXHp5UqxcH/unvqonyT7zK3jS/FFXrdsNsejEv4WU51qWW/5Qlbth7auDehWxD\n\tv9mE9ETw==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version:\n\tReferences:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender\n\t:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:\n\tResent-Cc:Resent-Message-ID; bh=DSZ5KWDl/z52RVWNk2bHbNpZglcD5PTtXIhz0rCVKEE=;\n\tt=1669111858; x=1670321458; b=qrQgda8vk9EJCSFUomyEBpRCZtfBJdmlqYLH3xkq1koFAcq\n\t7cHlCXhJO8pYToJo25ob9+09XnKeSz6Z8UQEjCuSNEBM0Gfy91X2/eq9p/cAXbdwH//2qWh9pVc10\n\tlq3fHFm16eo5lfvkRTwXFlIIS2rhaTl1q91b/lyJXt1hMGOpInfRNq822a7YZK28xSP/5euiSZmC4\n\tvRWoW4DYXYRPikO2EUGUwfTHJ42A+P327odA9c7JbLS4WjDuLBh77faVNg0AeSE6dEcnFTHIG0SYF\n\t6SaHsiqD8sAHlxjQFlyP0N9kE9axBxOKe+ohKNs6Kd+P6ADfb6OQ0mUodGmFmHMQ==;" ], "From": "benjamin@sipsolutions.net", "To": "linux-um@lists.infradead.org", "Cc": "Benjamin Berg <benjamin@sipsolutions.net>", "Subject": "[PATCH v2 14/28] um: Remove stub-data.h include from common-offsets.h", "Date": "Tue, 22 Nov 2022 11:07:45 +0100", "Message-Id": "<20221122100759.208290-15-benjamin@sipsolutions.net>", "X-Mailer": "git-send-email 2.38.1", "In-Reply-To": "<20221122100759.208290-1-benjamin@sipsolutions.net>", "References": "<20221122100759.208290-1-benjamin@sipsolutions.net>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20221122_101059_285221_3CB17D26 ", "X-CRM114-Status": "UNSURE ( 7.49 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Benjamin Berg <benjamin@sipsolutions.net> Further\n commits\n will require values from common-offsets.h inside stub-data.h. Resolve the\n possible circular dependency and simply use offsetof() inside stub_32.h\n and\n stub_64.h.\n Content analysis details: (-0.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily\n valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Benjamin Berg <benjamin@sipsolutions.net>\n\nFurther commits will require values from common-offsets.h inside\nstub-data.h. Resolve the possible circular dependency and simply use\noffsetof() inside stub_32.h and stub_64.h.\n\nSigned-off-by: Benjamin Berg <benjamin@sipsolutions.net>\n---\n arch/um/include/shared/common-offsets.h | 5 -----\n arch/x86/um/shared/sysdep/stub_32.h | 7 ++++---\n arch/x86/um/shared/sysdep/stub_64.h | 7 ++++---\n 3 files changed, 8 insertions(+), 11 deletions(-)", "diff": "diff --git a/arch/um/include/shared/common-offsets.h b/arch/um/include/shared/common-offsets.h\nindex 96195483fbd0..579ed946a3a9 100644\n--- a/arch/um/include/shared/common-offsets.h\n+++ b/arch/um/include/shared/common-offsets.h\n@@ -1,6 +1,5 @@\n /* SPDX-License-Identifier: GPL-2.0 */\n /* for use by sys-$SUBARCH/kernel-offsets.c */\n-#include <stub-data.h>\n \n DEFINE(KERNEL_MADV_REMOVE, MADV_REMOVE);\n \n@@ -30,7 +29,3 @@ DEFINE(UML_CONFIG_64BIT, CONFIG_64BIT);\n DEFINE(UML_CONFIG_UML_TIME_TRAVEL_SUPPORT, CONFIG_UML_TIME_TRAVEL_SUPPORT);\n #endif\n \n-/* for stub */\n-DEFINE(UML_STUB_FIELD_OFFSET, offsetof(struct stub_data, offset));\n-DEFINE(UML_STUB_FIELD_CHILD_ERR, offsetof(struct stub_data, child_err));\n-DEFINE(UML_STUB_FIELD_FD, offsetof(struct stub_data, fd));\ndiff --git a/arch/x86/um/shared/sysdep/stub_32.h b/arch/x86/um/shared/sysdep/stub_32.h\nindex cdb3396679e1..c413927c6ad0 100644\n--- a/arch/x86/um/shared/sysdep/stub_32.h\n+++ b/arch/x86/um/shared/sysdep/stub_32.h\n@@ -6,6 +6,7 @@\n #ifndef __SYSDEP_STUB_H\n #define __SYSDEP_STUB_H\n \n+#include <stddef.h>\n #include <asm/ptrace.h>\n #include <generated/asm-offsets.h>\n \n@@ -98,9 +99,9 @@ static __always_inline void remap_stack_and_trap(void)\n \t\t: :\n \t\t\"g\" (~(UM_KERN_PAGE_SIZE - 1)),\n \t\t\"g\" (STUB_MMAP_NR),\n-\t\t\"g\" (UML_STUB_FIELD_FD),\n-\t\t\"g\" (UML_STUB_FIELD_OFFSET),\n-\t\t\"g\" (UML_STUB_FIELD_CHILD_ERR),\n+\t\t\"g\" (offsetof(struct stub_data, fd)),\n+\t\t\"g\" (offsetof(struct stub_data, offset)),\n+\t\t\"g\" (offsetof(struct stub_data, child_err)),\n \t\t\"c\" (UM_KERN_PAGE_SIZE),\n \t\t\"d\" (PROT_READ | PROT_WRITE),\n \t\t\"S\" (MAP_FIXED | MAP_SHARED)\ndiff --git a/arch/x86/um/shared/sysdep/stub_64.h b/arch/x86/um/shared/sysdep/stub_64.h\nindex da6fd28fa95e..361a6a9fe1e4 100644\n--- a/arch/x86/um/shared/sysdep/stub_64.h\n+++ b/arch/x86/um/shared/sysdep/stub_64.h\n@@ -6,6 +6,7 @@\n #ifndef __SYSDEP_STUB_H\n #define __SYSDEP_STUB_H\n \n+#include <stddef.h>\n #include <sysdep/ptrace_user.h>\n #include <generated/asm-offsets.h>\n #include <linux/stddef.h>\n@@ -101,9 +102,9 @@ static __always_inline void remap_stack_and_trap(void)\n \t\t\"g\" (STUB_MMAP_NR),\n \t\t\"g\" (~(UM_KERN_PAGE_SIZE - 1)),\n \t\t\"g\" (MAP_FIXED | MAP_SHARED),\n-\t\t\"g\" (UML_STUB_FIELD_FD),\n-\t\t\"g\" (UML_STUB_FIELD_OFFSET),\n-\t\t\"g\" (UML_STUB_FIELD_CHILD_ERR),\n+\t\t\"g\" (offsetof(struct stub_data, fd)),\n+\t\t\"g\" (offsetof(struct stub_data, offset)),\n+\t\t\"g\" (offsetof(struct stub_data, child_err)),\n \t\t\"S\" (UM_KERN_PAGE_SIZE),\n \t\t\"d\" (PROT_READ | PROT_WRITE)\n \t\t:\n", "prefixes": [ "v2", "14/28" ] }