Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1707750/?format=api
{ "id": 1707750, "url": "http://patchwork.ozlabs.org/api/patches/1707750/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20221122100759.208290-8-benjamin@sipsolutions.net/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20221122100759.208290-8-benjamin@sipsolutions.net>", "list_archive_url": null, "date": "2022-11-22T10:07:38", "name": "[v2,07/28] um: Do not use printk in SIGWINCH helper thread", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "04b6994904fe77cac3bdaab310a686c811b19e94", "submitter": { "id": 67525, "url": "http://patchwork.ozlabs.org/api/people/67525/?format=api", "name": "Benjamin Berg", "email": "benjamin@sipsolutions.net" }, "delegate": { "id": 54851, "url": "http://patchwork.ozlabs.org/api/users/54851/?format=api", "username": "rw", "first_name": "Richard", "last_name": "Weinberger", "email": "richard@nod.at" }, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20221122100759.208290-8-benjamin@sipsolutions.net/mbox/", "series": [ { "id": 329466, "url": "http://patchwork.ozlabs.org/api/series/329466/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=329466", "date": "2022-11-22T10:07:37", "name": "Implement SECCOMP based userland", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/329466/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1707750/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1707750/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OCnETBaA;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=sipsolutions.net header.i=@sipsolutions.net\n header.a=rsa-sha256 header.s=mail header.b=HYK8xpCH;\n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4NGg5j2m7Tz23nl\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Nov 2022 21:11:37 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQFU-007g8a-Ao; Tue, 22 Nov 2022 10:11:28 +0000", "from s3.sipsolutions.net ([2a01:4f8:191:4433::2]\n helo=sipsolutions.net)\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQF3-007feW-Fy\n\tfor linux-um@lists.infradead.org; Tue, 22 Nov 2022 10:11:12 +0000", "by sipsolutions.net with esmtpsa\n (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim 4.96)\n\t(envelope-from <benjamin@sipsolutions.net>)\n\tid 1oxQEn-006IGn-2I;\n\tTue, 22 Nov 2022 11:10:45 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=iSPXSBFICwj1ZxczI8MQYgjojpKQ0I2HZrTUNPRm21Y=; b=OCnETBaAG6iZet\n\tJcxHLDXp21pVMWFIgMbRlz21OXFqEQrxSi7ge34w6MzmWktqwuIav06tobRwP4mmfANvyrOfEpo/A\n\tDOJgdh2J5ZCqCCjN8rElBDvp9Klbn+N+XCvIp3EF6g+yDrEz01UQW+BNzxpjWlLR/Yrow9JKL+ruR\n\taVVAaPYaUhhJ1GCGu2qulD6jFXGFYreShdbBIp88qClPwun1MYDGdGwlOJES+hIg3wrLCFZkmUdZn\n\t2T9erL8te3FTkapkLyXYTtTRqERRDm/dFXNw9p7CcIgVYK4EV9ZRH+cAWsvsm2CspBSAPwNeoU9+S\n\tCXRqYEcTgMr+GaRiy+Zg==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version:\n\tReferences:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender\n\t:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:\n\tResent-Cc:Resent-Message-ID; bh=q3vBrqGWi2ofI9DhNMJnDnuBl39sYbcsd6mqWJjSse0=;\n\tt=1669111861; x=1670321461; b=HYK8xpCHt/ASxGSTWRtsPSzxGLN/++RHcQtaoX7y6lKMymK\n\tR88grBHfTXrsWmccMYhtrcxqsca2J151IrMAg3TxI/rPJx2ADTujPEF9VY7jzhZa7QlN7OU93BeBO\n\t7XvMcPAjHgvzG0C/qgopDug5wzyG/8bR6zhJAzDO8rqJcNQBR7C25dvEzqHQV820leaTgX12b8dNT\n\thbapmDW2pFier4wm+zbTFCDm3hFKR1BS6Sn9jEMU2SNXMNIsCR0uq3HtLIHrAxAx9Mq7qAKUwn1Bn\n\tb0nve8xHQkZfJG4aVLdfCMjJAYnKK3U7VyLpblacxrUuQaPgvFZqSgoDlv2CzySQ==;" ], "From": "benjamin@sipsolutions.net", "To": "linux-um@lists.infradead.org", "Cc": "Benjamin Berg <benjamin@sipsolutions.net>", "Subject": "[PATCH v2 07/28] um: Do not use printk in SIGWINCH helper thread", "Date": "Tue, 22 Nov 2022 11:07:38 +0100", "Message-Id": "<20221122100759.208290-8-benjamin@sipsolutions.net>", "X-Mailer": "git-send-email 2.38.1", "In-Reply-To": "<20221122100759.208290-1-benjamin@sipsolutions.net>", "References": "<20221122100759.208290-1-benjamin@sipsolutions.net>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20221122_021101_613442_710B5902 ", "X-CRM114-Status": "GOOD ( 12.36 )", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Benjamin Berg <benjamin@sipsolutions.net> The thread\n is running outside of the UML kernel scope and is a helper. As such,\n printk\n cannot work and os_info must be used instead. Signed-off-by: Benjamin Berg\n <benjamin@sipsolutions.net> --- arch/um/drivers/chan_user.c | 26\n +++++++++++++\n 1 file changed, 13 insertions(+), 13 deletions(-)\n Content analysis details: (-0.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily\n valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Benjamin Berg <benjamin@sipsolutions.net>\n\nThe thread is running outside of the UML kernel scope and is a helper.\nAs such, printk cannot work and os_info must be used instead.\n\nSigned-off-by: Benjamin Berg <benjamin@sipsolutions.net>\n---\n arch/um/drivers/chan_user.c | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/arch/um/drivers/chan_user.c b/arch/um/drivers/chan_user.c\nindex 25727ed648b7..c2b83cb99aae 100644\n--- a/arch/um/drivers/chan_user.c\n+++ b/arch/um/drivers/chan_user.c\n@@ -153,8 +153,8 @@ static int winch_thread(void *arg)\n \tpipe_fd = data->pipe_fd;\n \tcount = write(pipe_fd, &c, sizeof(c));\n \tif (count != sizeof(c))\n-\t\tprintk(UM_KERN_ERR \"winch_thread : failed to write \"\n-\t\t \"synchronization byte, err = %d\\n\", -count);\n+\t\tos_info(\"winch_thread : failed to write synchronization byte, err = %d\\n\",\n+\t\t\t-count);\n \n \t/*\n \t * We are not using SIG_IGN on purpose, so don't fix it as I thought to\n@@ -166,28 +166,28 @@ static int winch_thread(void *arg)\n \tsigfillset(&sigs);\n \t/* Block all signals possible. */\n \tif (sigprocmask(SIG_SETMASK, &sigs, NULL) < 0) {\n-\t\tprintk(UM_KERN_ERR \"winch_thread : sigprocmask failed, \"\n-\t\t \"errno = %d\\n\", errno);\n+\t\tos_info(\"winch_thread : sigprocmask failed, errno = %d\\n\",\n+\t\t\terrno);\n \t\texit(1);\n \t}\n \t/* In sigsuspend(), block anything else than SIGWINCH. */\n \tsigdelset(&sigs, SIGWINCH);\n \n \tif (setsid() < 0) {\n-\t\tprintk(UM_KERN_ERR \"winch_thread : setsid failed, errno = %d\\n\",\n+\t\tos_info(\"winch_thread : setsid failed, errno = %d\\n\",\n \t\t errno);\n \t\texit(1);\n \t}\n \n \tif (ioctl(pty_fd, TIOCSCTTY, 0) < 0) {\n-\t\tprintk(UM_KERN_ERR \"winch_thread : TIOCSCTTY failed on \"\n-\t\t \"fd %d err = %d\\n\", pty_fd, errno);\n+\t\tos_info(\"winch_thread : TIOCSCTTY failed on \"\n+\t\t\t\"fd %d err = %d\\n\", pty_fd, errno);\n \t\texit(1);\n \t}\n \n \tif (tcsetpgrp(pty_fd, os_getpid()) < 0) {\n-\t\tprintk(UM_KERN_ERR \"winch_thread : tcsetpgrp failed on \"\n-\t\t \"fd %d err = %d\\n\", pty_fd, errno);\n+\t\tos_info(\"winch_thread : tcsetpgrp failed on fd %d err = %d\\n\",\n+\t\t\tpty_fd, errno);\n \t\texit(1);\n \t}\n \n@@ -199,8 +199,8 @@ static int winch_thread(void *arg)\n \t */\n \tcount = read(pipe_fd, &c, sizeof(c));\n \tif (count != sizeof(c))\n-\t\tprintk(UM_KERN_ERR \"winch_thread : failed to read \"\n-\t\t \"synchronization byte, err = %d\\n\", errno);\n+\t\tos_info(\"winch_thread : failed to read synchronization byte, err = %d\\n\",\n+\t\t\terrno);\n \n \twhile(1) {\n \t\t/*\n@@ -211,8 +211,8 @@ static int winch_thread(void *arg)\n \n \t\tcount = write(pipe_fd, &c, sizeof(c));\n \t\tif (count != sizeof(c))\n-\t\t\tprintk(UM_KERN_ERR \"winch_thread : write failed, \"\n-\t\t\t \"err = %d\\n\", errno);\n+\t\t\tos_info(\"winch_thread : write failed, err = %d\\n\",\n+\t\t\t\terrno);\n \t}\n }\n \n", "prefixes": [ "v2", "07/28" ] }