Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1707748/?format=api
{ "id": 1707748, "url": "http://patchwork.ozlabs.org/api/patches/1707748/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20221122100759.208290-10-benjamin@sipsolutions.net/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20221122100759.208290-10-benjamin@sipsolutions.net>", "list_archive_url": null, "date": "2022-11-22T10:07:40", "name": "[v2,09/28] um: Do not use printk in userspace trampoline", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "baa084e6fd726140379a66fc283fab14cde5e152", "submitter": { "id": 67525, "url": "http://patchwork.ozlabs.org/api/people/67525/?format=api", "name": "Benjamin Berg", "email": "benjamin@sipsolutions.net" }, "delegate": { "id": 54851, "url": "http://patchwork.ozlabs.org/api/users/54851/?format=api", "username": "rw", "first_name": "Richard", "last_name": "Weinberger", "email": "richard@nod.at" }, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20221122100759.208290-10-benjamin@sipsolutions.net/mbox/", "series": [ { "id": 329466, "url": "http://patchwork.ozlabs.org/api/series/329466/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=329466", "date": "2022-11-22T10:07:37", "name": "Implement SECCOMP based userland", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/329466/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1707748/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1707748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=2RIgwUqv;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=sipsolutions.net header.i=@sipsolutions.net\n header.a=rsa-sha256 header.s=mail header.b=ZeBzAvmh;\n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4NGg5g1yyHz23nl\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Nov 2022 21:11:35 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQFS-007g5m-Fy; Tue, 22 Nov 2022 10:11:26 +0000", "from s3.sipsolutions.net ([2a01:4f8:191:4433::2]\n helo=sipsolutions.net)\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oxQF3-007feR-3D\n\tfor linux-um@lists.infradead.org; Tue, 22 Nov 2022 10:11:10 +0000", "by sipsolutions.net with esmtpsa\n (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim 4.96)\n\t(envelope-from <benjamin@sipsolutions.net>)\n\tid 1oxQEo-006IGn-2k;\n\tTue, 22 Nov 2022 11:10:46 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=4Q7S5QXZsNR4eOAb8gXnkKh4h0treIpYqYSxmwMzrtg=; b=2RIgwUqv8AOQSi\n\tP0+9FQzwV9nSOR9KLhS07IqolP2PsB8ir4Z5EhJGLPgxdSCEq4tzEYGgti3ISp9nlACXDs8+tt/dV\n\tsKisOH2m23+rnx6mjD9Tl1KXHB50o/0agPkhKOjC6Wp5dVs4h8NIzo6EX+ShMOeg/VixfyJ7MIhI5\n\tI5wxpNuuz5EEIYHlKIMYc0KaPNJQZaj/5ZLo3nceUQqHqbF8j3v706h6hcc3oEe46LsTjO72mtroF\n\tYq/iDxuiWapVclr2wA1fTuS3duaQuTNPo0lo2ZyXHVcNFjjy53NCog9F0GFt71mqc7hGWqjO5mbAq\n\tyxH8zHEVWO0mFplYG5Lg==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version:\n\tReferences:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender\n\t:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:\n\tResent-Cc:Resent-Message-ID; bh=0GOKaITcnUfATMBExVcQ+K8tMwNSYEyX3r0fYos9ylk=;\n\tt=1669111860; x=1670321460; b=ZeBzAvmhcSp99OhTOvjbPLawW7BtBTZTIDF0u1WTOQCoQnT\n\tRbDQAVYOaaftGLc2q0xjLemlyIUAUXAuAAPR+/2CTWr086D5o3s7LvmucZS/DbiSpa53QZcXsJAst\n\tVBEskVdm9lip8/BGbZIOxsTCeoCCb2pZiIZnJQKqFs3vmfpfO3SmAYqIdgAKi5xD9eRNy7dDbAgG9\n\tZ+SLzZy3aoiEjZDUgwf3Mgqd/D46GMSFIo9TcgQOzvwx7LnGp0tk1WMv7hdHlVV7pyaEfOBNFv2wC\n\tJDrVMBkV0ok8TsBwbyTZjgGx+KSBNPARHBFZGsjYXCKX3qPWJjhRKbsgNY0DAVTA==;" ], "From": "benjamin@sipsolutions.net", "To": "linux-um@lists.infradead.org", "Cc": "Benjamin Berg <benjamin@sipsolutions.net>", "Subject": "[PATCH v2 09/28] um: Do not use printk in userspace trampoline", "Date": "Tue, 22 Nov 2022 11:07:40 +0100", "Message-Id": "<20221122100759.208290-10-benjamin@sipsolutions.net>", "X-Mailer": "git-send-email 2.38.1", "In-Reply-To": "<20221122100759.208290-1-benjamin@sipsolutions.net>", "References": "<20221122100759.208290-1-benjamin@sipsolutions.net>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20221122_021101_227821_880BD358 ", "X-CRM114-Status": "UNSURE ( 9.48 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Benjamin Berg <benjamin@sipsolutions.net> The\n trampoline\n is running in a cloned process. It is not safe to use printk for error\n printing\n there. Signed-off-by: Benjamin Berg <benjamin@sipsolutions.net> ---\n arch/um/os-Linux/skas/process.c\n | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)\n Content analysis details: (-0.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily\n valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Benjamin Berg <benjamin@sipsolutions.net>\n\nThe trampoline is running in a cloned process. It is not safe to use\nprintk for error printing there.\n\nSigned-off-by: Benjamin Berg <benjamin@sipsolutions.net>\n---\n arch/um/os-Linux/skas/process.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/arch/um/os-Linux/skas/process.c b/arch/um/os-Linux/skas/process.c\nindex 90db8add1231..4198ca21e4ab 100644\n--- a/arch/um/os-Linux/skas/process.c\n+++ b/arch/um/os-Linux/skas/process.c\n@@ -221,8 +221,8 @@ static int userspace_tramp(void *stack)\n \taddr = mmap64((void *) STUB_CODE, UM_KERN_PAGE_SIZE,\n \t\t PROT_EXEC, MAP_FIXED | MAP_PRIVATE, fd, offset);\n \tif (addr == MAP_FAILED) {\n-\t\tprintk(UM_KERN_ERR \"mapping mmap stub at 0x%lx failed, errno = %d\\n\",\n-\t\t STUB_CODE, errno);\n+\t\tos_info(\"mapping mmap stub at 0x%lx failed, errno = %d\\n\",\n+\t\t\tSTUB_CODE, errno);\n \t\texit(1);\n \t}\n \n@@ -231,8 +231,8 @@ static int userspace_tramp(void *stack)\n \t\t UM_KERN_PAGE_SIZE, PROT_READ | PROT_WRITE,\n \t\t MAP_FIXED | MAP_SHARED, fd, offset);\n \tif (addr == MAP_FAILED) {\n-\t\tprintk(UM_KERN_ERR \"mapping segfault stack at 0x%lx failed, errno = %d\\n\",\n-\t\t STUB_DATA, errno);\n+\t\tos_info(\"mapping segfault stack at 0x%lx failed, errno = %d\\n\",\n+\t\t\tSTUB_DATA, errno);\n \t\texit(1);\n \t}\n \n@@ -242,8 +242,8 @@ static int userspace_tramp(void *stack)\n \tsa.sa_sigaction = (void *) segv_handler;\n \tsa.sa_restorer = NULL;\n \tif (sigaction(SIGSEGV, &sa, NULL) < 0) {\n-\t\tprintk(UM_KERN_ERR \"%s - setting SIGSEGV handler failed - errno = %d\\n\",\n-\t\t __func__, errno);\n+\t\tos_info(\"%s - setting SIGSEGV handler failed - errno = %d\\n\",\n+\t\t\t__func__, errno);\n \t\texit(1);\n \t}\n \n", "prefixes": [ "v2", "09/28" ] }