Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1671212/?format=api
{ "id": 1671212, "url": "http://patchwork.ozlabs.org/api/patches/1671212/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220828151929.32588-1-kabel@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220828151929.32588-1-kabel@kernel.org>", "list_archive_url": null, "date": "2022-08-28T15:19:29", "name": "[v2] board_f: Add support for CONFIG_OF_BOARD_FIXUP for XIP images", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "0e458944d6e1c820226154c91369834bbf62b1e1", "submitter": { "id": 80272, "url": "http://patchwork.ozlabs.org/api/people/80272/?format=api", "name": "Marek Behún", "email": "kabel@kernel.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220828151929.32588-1-kabel@kernel.org/mbox/", "series": [ { "id": 315694, "url": "http://patchwork.ozlabs.org/api/series/315694/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=315694", "date": "2022-08-28T15:19:29", "name": "[v2] board_f: Add support for CONFIG_OF_BOARD_FIXUP for XIP images", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/315694/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1671212/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1671212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=jqJPbJvN;\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"jqJPbJvN\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=kabel@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4MFy156gQWz1yh5\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 29 Aug 2022 01:19:52 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7DF2883FCA;\n\tSun, 28 Aug 2022 17:19:40 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 7EFB9840D2; Sun, 28 Aug 2022 17:19:39 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 16B4083D01\n for <u-boot@lists.denx.de>; Sun, 28 Aug 2022 17:19:37 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 19B7E61058;\n Sun, 28 Aug 2022 15:19:35 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 77652C433C1;\n Sun, 28 Aug 2022 15:19:33 +0000 (UTC)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1661699974;\n bh=4aYl3DNObGov/t4vr5EyPBdIDBtZrSH6c/ew+JDZfGk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=jqJPbJvN40u8T6oblY5ciPleBvQWQvrIsoRV4SRH92L/qxg93HDgxR/tpDnaqIxwd\n hBZV+/NhVZFOe+P0JacEUFwptGp6DPbmYjDQwmGPFOEApzmOHVV6uytei+RtwyTDy6\n xccUpobu1F2ao7uo6eT21WVds//GE2JR1Q2zKSnIybrlvbNFN5Paufz24xloBLL5TW\n +Hj3XLAna2TVBB6wM8vXUTw50O1pYupvGeKC2pkOnJl94P8yiu1SX3HG1GE/0itgKn\n hFIQW90eDvC4RxPUf+lmHM0jpvcNNKMFjFjPGdQvu3798deit3irGXeJS/tlS9r93k\n XTlpRyrN7Hnsw==", "From": "=?utf-8?q?Marek_Beh=C3=BAn?= <kabel@kernel.org>", "To": "Simon Glass <sjg@chromium.org>,\n =?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "Cc": "u-boot@lists.denx.de, =?utf-8?q?Marek_Beh=C3=BAn?= <kabel@kernel.org>", "Subject": "[PATCH v2] board_f: Add support for CONFIG_OF_BOARD_FIXUP for XIP\n images", "Date": "Sun, 28 Aug 2022 17:19:29 +0200", "Message-Id": "<20220828151929.32588-1-kabel@kernel.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220827181220.471-1-pali@kernel.org>", "References": "", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: Pali Rohár <pali@kernel.org>\n\nWhen U-Boot is running from flash memory (execute in place) then\ngd->fdt_blob before relocation points to read-only flash memory.\n\nSo U-Boot calls board_fix_fdt() with read-only gd->fdt_blob pointer which\ncause immediate CPU crash when callback is trying to modify gd->fdt_blob.\n\nFix this issue by introducing a new config option\nOF_DTB_READONLY_BEFORE_RELOC which moves fix_fdt callback after the\nreloc_fdt callback. This makes CONFIG_OF_BOARD_FIXUP working also if\nU-Boot before relocation is not running from read/write (S)RAM memory.\n\nThis is required for mpc85xx boards when booting from flash NOR.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\nSigned-off-by: Marek Behún <kabel@kernel.org>\n---\nChanges since v1:\n- just changed the new Kconfig option name and associated help string\n---\n common/board_f.c | 8 +++++++-\n dts/Kconfig | 6 ++++++\n 2 files changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/common/board_f.c b/common/board_f.c\nindex 18e2246733..35fb4a0753 100644\n--- a/common/board_f.c\n+++ b/common/board_f.c\n@@ -911,7 +911,7 @@ static const init_fnc_t init_sequence_f[] = {\n \t * - board info struct\n \t */\n \tsetup_dest_addr,\n-#ifdef CONFIG_OF_BOARD_FIXUP\n+#if defined(CONFIG_OF_BOARD_FIXUP) && !defined(CONFIG_OF_DTB_READONLY_BEFORE_RELOC)\n \tfix_fdt,\n #endif\n #ifdef CONFIG_PRAM\n@@ -926,6 +926,10 @@ static const init_fnc_t init_sequence_f[] = {\n \treserve_board,\n \treserve_global_data,\n \treserve_fdt,\n+#if defined(CONFIG_OF_BOARD_FIXUP) && defined(CONFIG_OF_DTB_READONLY_BEFORE_RELOC)\n+\treloc_fdt,\n+\tfix_fdt,\n+#endif\n \treserve_bootstage,\n \treserve_bloblist,\n \treserve_arch,\n@@ -936,7 +940,9 @@ static const init_fnc_t init_sequence_f[] = {\n \tsetup_bdinfo,\n \tdisplay_new_sp,\n \tINIT_FUNC_WATCHDOG_RESET\n+#if !defined(CONFIG_OF_BOARD_FIXUP) || !defined(CONFIG_OF_DTB_READONLY_BEFORE_RELOC)\n \treloc_fdt,\n+#endif\n \treloc_bootstage,\n \treloc_bloblist,\n \tsetup_reloc,\ndiff --git a/dts/Kconfig b/dts/Kconfig\nindex bc5f22029f..29e5248b15 100644\n--- a/dts/Kconfig\n+++ b/dts/Kconfig\n@@ -105,6 +105,12 @@ config OF_EMBED\n \n endchoice\n \n+config OF_DTB_READONLY_BEFORE_RELOC\n+\tbool \"Initial DTB (before relocation) for DT control is read-only\"\n+\thelp\n+\t If initial (before relocation) DTB for DT control is read-only,\n+\t (e.g. points to memory-mapped flash memory), set this option.\n+\n config OF_BOARD\n \tbool \"Provided by the board (e.g a previous loader) at runtime\"\n \tdefault y if SANDBOX || OF_HAS_PRIOR_STAGE\n", "prefixes": [ "v2" ] }