Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1664367/?format=api
{ "id": 1664367, "url": "http://patchwork.ozlabs.org/api/patches/1664367/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220807190422.20157-1-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220807190422.20157-1-pali@kernel.org>", "list_archive_url": null, "date": "2022-08-07T19:04:22", "name": "distroboot: ubifs: Add support for specifying UBI header offset", "commit_ref": "53a9f9ef879fbc9ae0e6bf5330d3817ebd726e5f", "pull_url": null, "state": "accepted", "archived": false, "hash": "73107537c8b278c4bb2e9b5e3740ca0371933509", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220807190422.20157-1-pali@kernel.org/mbox/", "series": [ { "id": 312883, "url": "http://patchwork.ozlabs.org/api/series/312883/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=312883", "date": "2022-08-07T19:04:22", "name": "distroboot: ubifs: Add support for specifying UBI header offset", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/312883/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1664367/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1664367/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hAj7Zra/;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"hAj7Zra/\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4M180B36Dxz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 8 Aug 2022 05:04:42 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4D90183FB0;\n\tSun, 7 Aug 2022 21:04:38 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id DA90883EF2; Sun, 7 Aug 2022 21:04:36 +0200 (CEST)", "from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BAA9783FB0\n for <u-boot@lists.denx.de>; Sun, 7 Aug 2022 21:04:34 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 5A3DCB80DC1;\n Sun, 7 Aug 2022 19:04:34 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id E487AC433C1;\n Sun, 7 Aug 2022 19:04:32 +0000 (UTC)", "by pali.im (Postfix)\n id D352897B; Sun, 7 Aug 2022 21:04:29 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1659899073;\n bh=YQCxsM4h/Kw88x1vKRDeJdrBKkFIaISFcI2VpL85zzE=;\n h=From:To:Cc:Subject:Date:From;\n b=hAj7Zra/ihqWl3d8ArZLK6er65FzSt3oE4Xr73XU49NyLUTmWT5w4uTa/fT4LwF7Y\n hTDCaLPc66GeTkvwvPzURO6wWcQO1emqPSS3Tge2H5AcyuL3w0nbUWzD7kMCMjbydU\n vqmjo3to1lXjrTCzrmzDzknr0pHjxlygN1tHynChCTdzNzj7CXZ6jm8U514ZSLN1kl\n 5Stt6wPFxvIRl4LWoZJkc7DztchYBJFl8x4asuJe4SYSCXxtsrikJDHEdI95vA5Bnk\n dNq27v9dCLdIZkv1ldsO/s5M0A7ZxnbLbTF9fpkSPbZmnTfNCaFX4cevWEhX3yznwx\n j62r1R5QX2rBg==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Simon Glass <sjg@chromium.org>,\n\tTom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH] distroboot: ubifs: Add support for specifying UBI header\n offset", "Date": "Sun, 7 Aug 2022 21:04:22 +0200", "Message-Id": "<20220807190422.20157-1-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Some UBI partitions may use non-standard UBI header offset. For attaching\nthese UBI partitions it is required to pass second argument with offset to\n\"ubi part\" command.\n\nTherefore extend distroboot to allow specifying additional optional 6th\nargument with UBI header offset. This offset is set in new distroboot\nvariable ${bootubioff} which may be used by distroboot script to e.g.\nproperly pass this value to linux kernel command line for proper mounting\nof rootfs by kernel. This variable is set to empty string (cleared) when\nUBI header offset is not specified into distroboot BOOT_TARGET_DEVICES\nmacro.\n\nUsage of helper macro BOOTENV_DEV_UBIFS_BOOTUBIOFF in this change is there\nas a type check. It ensures that in BOOT_TARGET_DEVICES macro was specified\nUBIFS func with either 5 or 6 arguments. If not then cpp throws compile\nerror.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n include/config_distro_bootcmd.h | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h\nindex 4e0c23be5645..f28f6095da08 100644\n--- a/include/config_distro_bootcmd.h\n+++ b/include/config_distro_bootcmd.h\n@@ -70,7 +70,7 @@\n #ifdef CONFIG_CMD_UBIFS\n #define BOOTENV_SHARED_UBIFS \\\n \t\"ubifs_boot=\" \\\n-\t\t\"if ubi part ${bootubipart} && \" \\\n+\t\t\"if ubi part ${bootubipart} ${bootubioff} && \" \\\n \t\t\t\"ubifsmount ubi0:${bootubivol}; \" \\\n \t\t\"then \" \\\n \t\t\t\"devtype=ubi; \" \\\n@@ -80,12 +80,14 @@\n \t\t\t\"run scan_dev_for_boot; \" \\\n \t\t\t\"ubifsumount; \" \\\n \t\t\"fi\\0\"\n-#define BOOTENV_DEV_UBIFS(devtypeu, devtypel, instance, bootubipart, bootubivol) \\\n+#define BOOTENV_DEV_UBIFS_BOOTUBIOFF(off) #off /* type check, throw error when called with more args */\n+#define BOOTENV_DEV_UBIFS(devtypeu, devtypel, instance, bootubipart, bootubivol, ...) \\\n \t\"bootcmd_ubifs\" #instance \"=\" \\\n \t\t\"bootubipart=\" #bootubipart \"; \" \\\n \t\t\"bootubivol=\" #bootubivol \"; \" \\\n+\t\t\"bootubioff=\" BOOTENV_DEV_UBIFS_BOOTUBIOFF(__VA_ARGS__) \"; \" \\\n \t\t\"run ubifs_boot\\0\"\n-#define BOOTENV_DEV_NAME_UBIFS(devtypeu, devtypel, instance, bootubipart, bootubivol) \\\n+#define BOOTENV_DEV_NAME_UBIFS(devtypeu, devtypel, instance, ...) \\\n \t#devtypel #instance \" \"\n #else\n #define BOOTENV_SHARED_UBIFS\n", "prefixes": [] }