Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/166376/?format=api
{ "id": 166376, "url": "http://patchwork.ozlabs.org/api/patches/166376/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1340307771-15204-1-git-send-email-linz@li-pro.net/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1340307771-15204-1-git-send-email-linz@li-pro.net>", "list_archive_url": null, "date": "2012-06-21T19:42:50", "name": "[U-Boot,1/2] microblaze: avoid compile error on systems without cfi flash", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "3962b3deed143ab5a00a8978a5c23629bc79d4bb", "submitter": { "id": 5893, "url": "http://patchwork.ozlabs.org/api/people/5893/?format=api", "name": "Stephan Linz", "email": "linz@li-pro.net" }, "delegate": { "id": 1692, "url": "http://patchwork.ozlabs.org/api/users/1692/?format=api", "username": "monstr", "first_name": "Michal", "last_name": "Simek", "email": "monstr@monstr.eu" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1340307771-15204-1-git-send-email-linz@li-pro.net/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/166376/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/166376/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from theia.denx.de (theia.denx.de [85.214.87.163])\n\tby ozlabs.org (Postfix) with ESMTP id 47C08B6FA4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Jun 2012 05:43:24 +1000 (EST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 3BCBF2808C;\n\tThu, 21 Jun 2012 21:43:18 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5fJx-hOwIWDp; Thu, 21 Jun 2012 21:43:18 +0200 (CEST)", "from theia.denx.de (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id C95792808D;\n\tThu, 21 Jun 2012 21:43:07 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby theia.denx.de (Postfix) with ESMTP id 3E57028085\n\tfor <u-boot@lists.denx.de>; Thu, 21 Jun 2012 21:43:03 +0200 (CEST)", "from theia.denx.de ([127.0.0.1])\n\tby localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AGRzz7AZjlIB for <u-boot@lists.denx.de>;\n\tThu, 21 Jun 2012 21:43:00 +0200 (CEST)", "from mo-p00-ob.rzone.de (mo-p00-ob.rzone.de [81.169.146.162])\n\tby theia.denx.de (Postfix) with ESMTPS id 3C79328086\n\tfor <u-boot@lists.denx.de>; Thu, 21 Jun 2012 21:42:58 +0200 (CEST)", "from localhost.localdomain (i58828E5A.versanet.de [88.130.142.90])\n\tby smtp.strato.de (jorabe mo12) (RZmta 29.16 DYNA|AUTH)\n\twith ESMTPA id N0730ao5LIOejA ; Thu, 21 Jun 2012 21:42:57 +0200 (CEST)" ], "X-Virus-Scanned": [ "Debian amavisd-new at theia.denx.de", "Debian amavisd-new at theia.denx.de" ], "X-policyd-weight": "NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5\n\tNOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)", "X-RZG-AUTH": ":IGUKb2CkcrLHmZv+FHarxbxlXmJO7WRQLa+vsyW+4RLunWeioNr2LcBsq9E=", "X-RZG-CLASS-ID": "mo00", "From": "Stephan Linz <linz@li-pro.net>", "To": "monstr@monstr.eu", "Date": "Thu, 21 Jun 2012 21:42:50 +0200", "Message-Id": "<1340307771-15204-1-git-send-email-linz@li-pro.net>", "X-Mailer": "git-send-email 1.7.0.4", "Cc": "Stephan Linz <linz@li-pro.net>, u-boot@lists.denx.de", "Subject": "[U-Boot] [PATCH 1/2] microblaze: avoid compile error on systems\n\twithout cfi flash", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<http://lists.denx.de/mailman/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<http://lists.denx.de/mailman/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "u-boot-bounces@lists.denx.de", "Errors-To": "u-boot-bounces@lists.denx.de" }, "content": "Use XILINX_FLASH_START to set/unset FLASH and RAMENV.\n\nError was:\nboard.c: In function 'board_init':\nboard.c:134: error: 'XILINX_FLASH_START' undeclared (first use in this function)\nboard.c:134: error: (Each undeclared identifier is reported only once\nboard.c:134: error: for each function it appears in.)\n\nSigned-off-by: Stephan Linz <linz@li-pro.net>\n---\n include/configs/microblaze-generic.h | 14 +++++++++-----\n 1 files changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h\nindex 295d123..2ef7d62 100644\n--- a/include/configs/microblaze-generic.h\n+++ b/include/configs/microblaze-generic.h\n@@ -31,6 +31,15 @@\n #define\tCONFIG_MICROBLAZE\t1\n #define\tMICROBLAZE_V5\t\t1\n \n+/* linear flash memory */\n+#ifdef XILINX_FLASH_START\n+#define\tFLASH\n+#undef\tRAMENV\t/* hold environment in flash */\n+#else\n+#undef\tFLASH\n+#define\tRAMENV\t/* hold environment in RAM */\n+#endif\n+\n /* uart */\n #ifdef XILINX_UARTLITE_BASEADDR\n # define CONFIG_XILINX_UARTLITE\n@@ -164,9 +173,6 @@\n /* stack */\n #define\tCONFIG_SYS_INIT_SP_OFFSET\tCONFIG_SYS_MALLOC_BASE\n \n-/*#define\tRAMENV */\n-#define\tFLASH\n-\n #ifdef FLASH\n # define CONFIG_SYS_FLASH_BASE\t\tXILINX_FLASH_START\n # define CONFIG_SYS_FLASH_SIZE\t\tXILINX_FLASH_SIZE\n@@ -200,8 +206,6 @@\n # define CONFIG_ENV_IS_NOWHERE\t1\n # define CONFIG_ENV_SIZE\t0x1000\n # define CONFIG_ENV_ADDR\t(CONFIG_SYS_MONITOR_BASE - CONFIG_ENV_SIZE)\n-/* hardware flash protection */\n-# define CONFIG_SYS_FLASH_PROTECTION\n #endif /* !FLASH */\n \n /* system ace */\n", "prefixes": [ "U-Boot", "1/2" ] }