Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1663637/?format=api
{ "id": 1663637, "url": "http://patchwork.ozlabs.org/api/patches/1663637/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220804110344.24268-1-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220804110344.24268-1-pali@kernel.org>", "list_archive_url": null, "date": "2022-08-04T11:03:44", "name": "misc: atsha204a: Don't check for error when waking up the device", "commit_ref": "ca514d0267f92d8aac2eb5f92ff7d150078df423", "pull_url": null, "state": "accepted", "archived": false, "hash": "e2e4ad47fd8798d8f5638f49888c023e0bc9cd11", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 1696, "url": "http://patchwork.ozlabs.org/api/users/1696/?format=api", "username": "stroese", "first_name": "Stefan", "last_name": "Roese", "email": "sr@denx.de" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220804110344.24268-1-pali@kernel.org/mbox/", "series": [ { "id": 312561, "url": "http://patchwork.ozlabs.org/api/series/312561/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=312561", "date": "2022-08-04T11:03:44", "name": "misc: atsha204a: Don't check for error when waking up the device", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/312561/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1663637/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1663637/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=nL5WZESI;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"nL5WZESI\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lz5T81HGxz9sGR\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 4 Aug 2022 21:04:07 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 272DF84209;\n\tThu, 4 Aug 2022 13:04:00 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id B560A83FE9; Thu, 4 Aug 2022 13:03:57 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2D8C0845C0\n for <u-boot@lists.denx.de>; Thu, 4 Aug 2022 13:03:55 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id EBD24616C4;\n Thu, 4 Aug 2022 11:03:53 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 30D2FC433D6;\n Thu, 4 Aug 2022 11:03:53 +0000 (UTC)", "by pali.im (Postfix)\n id A30EE80A; Thu, 4 Aug 2022 13:03:50 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1659611033;\n bh=wGnIExef4H+Lnd/dEKkUgtpSXu/VNMGp7LW38oSjZcw=;\n h=From:To:Cc:Subject:Date:From;\n b=nL5WZESIHTgR4Uk5+rcGGFB8lI/uQEbcs1OupJ+f+kKCpxF/hUBlh97fSD7aXlFqr\n EU3x7O1uBzn4ZGeoVF3ZcnbXNPh2UsBAHko5D2Xi/xIgk7DDvCUyvttuvvz+eikCp9\n UUdsDCBSFJaFNTseNqXIhZHd2I8+e3lTzDFOXah/e84fi7pr5MeAfHeeV/zKtis5D3\n VOQyayb3sFNdo7RC5R7JT1mG2cnQqslbtXrhDO77MCiiiH3oi9evhC2vvvj99fwpHR\n fxSP7b3FgYS5q8Tcpd3cVmdSvhhPmj11stRIJFke2EnPlNuH+OPHOEcqQkoa/WLI7C\n x7hykKEzhN2FQ==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Stefan Roese <sr@denx.de>,\n =?utf-8?q?Marek_Beh=C3=BAn?= <kabel@kernel.org>, =?utf-8?q?Pawe=C5=82_Aniki?=\n\t=?utf-8?q?el?= <pan@semihalf.com>,\n Adrian Fiergolski <adrian.fiergolski@fastree3d.com>,\n Simon Glass <sjg@chromium.org>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH] misc: atsha204a: Don't check for error when waking up the\n device", "Date": "Thu, 4 Aug 2022 13:03:44 +0200", "Message-Id": "<20220804110344.24268-1-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The device ignores any levels or transitions on the SCL pin when the device\nis idle, asleep or during waking up.\n\nLinux kernel driver for atsha204a (atmel-sha204a.ko) also ignores return\nvalue from i2c wakeup send command, see:\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/crypto/atmel-i2c.c?h=v5.19#n174\n\nAnd also userspace Turris libatsha204 library ignores return value from\nwakeup send command, see:\nhttps://gitlab.nic.cz/turris/libatsha204/-/blob/v29.2/src/libatsha204/layer_ni2c.c#L75-76\n\nU-Boot driver should do same thing.\n\nFixes waking up ATSHA204 on Turris 1.x boards.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n drivers/misc/atsha204a-i2c.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c\nindex 81ecb5b6177b..fa2d5948f128 100644\n--- a/drivers/misc/atsha204a-i2c.c\n+++ b/drivers/misc/atsha204a-i2c.c\n@@ -103,12 +103,13 @@ int atsha204a_wakeup(struct udevice *dev)\n \tfor (try = 1; try <= 10; ++try) {\n \t\tdebug(\"Try %i... \", try);\n \n+\t\t/*\n+\t\t * The device ignores any levels or transitions on the SCL pin\n+\t\t * when the device is idle, asleep or during waking up.\n+\t\t * Don't check for error when waking up the device.\n+\t\t */\n \t\tmemset(req, 0, 4);\n-\t\tres = atsha204a_send(dev, req, 4);\n-\t\tif (res) {\n-\t\t\tdebug(\"failed on I2C send, trying again\\n\");\n-\t\t\tcontinue;\n-\t\t}\n+\t\tatsha204a_send(dev, req, 4);\n \n \t\tudelay(ATSHA204A_TWLO_US + ATSHA204A_TWHI_US);\n \n", "prefixes": [] }