Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1662598/?format=api
{ "id": 1662598, "url": "http://patchwork.ozlabs.org/api/patches/1662598/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220801133146.11481-3-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220801133146.11481-3-pali@kernel.org>", "list_archive_url": null, "date": "2022-08-01T13:31:45", "name": "[v2,3/4] board: freescale: p1_p2_rdb_pc: Avoid usage of CPLD's system reset register", "commit_ref": "7e962cb132d6056b0a6f75eee2d800c9422da961", "pull_url": null, "state": "accepted", "archived": false, "hash": "afc1ea6613da4ce9e11a22aa284d331926c991ba", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 111897, "url": "http://patchwork.ozlabs.org/api/users/111897/?format=api", "username": "kabel", "first_name": "Marek", "last_name": "Behun", "email": "marek.behun@nic.cz" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220801133146.11481-3-pali@kernel.org/mbox/", "series": [ { "id": 312107, "url": "http://patchwork.ozlabs.org/api/series/312107/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=312107", "date": "2022-08-01T13:31:44", "name": "[v2,1/4] board: freescale: p1_p2_rdb_pc: Add workaround for board reset reboot loop", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/312107/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1662598/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1662598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=N1ENXdug;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"N1ENXdug\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LxJvj6LjZz9sCD\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 1 Aug 2022 23:32:33 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B181B84488;\n\tMon, 1 Aug 2022 15:32:11 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4AF72844DE; Mon, 1 Aug 2022 15:32:10 +0200 (CEST)", "from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E65FE8415B\n for <u-boot@lists.denx.de>; Mon, 1 Aug 2022 15:32:07 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by sin.source.kernel.org (Postfix) with ESMTPS id A1B46CE16B3;\n Mon, 1 Aug 2022 13:32:04 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id A7D5CC43470;\n Mon, 1 Aug 2022 13:32:02 +0000 (UTC)", "by pali.im (Postfix)\n id 3EB44CE4; Mon, 1 Aug 2022 15:32:00 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1659360722;\n bh=/G0+LhbqAn5iWcO4DxuHrlmkurcWrIBabPeSPARUhDA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=N1ENXdugxPhHbj3H8g4xvp8Fc4Yv4vRbaQTz4YbZ9G4PaOwk95TussZvqdve1g9Ed\n EuXTGQ/XzXnTsQ9td/4vEXSi5lotobgdBW7+uezZUaJCweW3WxB1CB9b2j9GUbeqvz\n qJys+6CUrO6R5xBPIkuoH7CZSDSnaL21mOUJUAPHfjAj9I4OcZZvKSMq7+TUbnUvWW\n Nw8lgpfwHWJZapcBrdFzl241qXjy5tkWHwVfnNw23penU68cGG4TSVl1iqdfp5qzd2\n E6Izw2GvBtr6fbwQnBTbZUYuzPt+tig1j60QTDVIsyetef2T/Bt/ClujkOz7LHmpl8\n KwIQT3TyqXdSQ==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "\"Peng Fan (OSS)\" <peng.fan@oss.nxp.com>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tu-boot@lists.denx.de", "Subject": "[PATCH v2 3/4] board: freescale: p1_p2_rdb_pc: Avoid usage of CPLD's\n system reset register", "Date": "Mon, 1 Aug 2022 15:31:45 +0200", "Message-Id": "<20220801133146.11481-3-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220801133146.11481-1-pali@kernel.org>", "References": "<20220501122314.32626-1-pali@kernel.org>\n <20220801133146.11481-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.6 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "CPLD's system reset register is buggy and requires workaround in U-Boot.\nSo use this kind of board reset only when there is no other reset option.\n\nIntroduce a new board_reset_last() callback which is last-stage\nboard-specific reset and implement CPLD's system reset in this new\nboard_reset_last() callback instead of board_reset() callback.\n\nFixes: 20fb58fc5a1c (\"board: freescale: p1_p2_rdb_pc: Implement board_reset()\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n arch/powerpc/cpu/mpc85xx/cpu.c | 4 ++++\n board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 2 +-\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c\nindex 226a26ba320a..c63c17286811 100644\n--- a/arch/powerpc/cpu/mpc85xx/cpu.c\n+++ b/arch/powerpc/cpu/mpc85xx/cpu.c\n@@ -44,6 +44,7 @@ __board_reset(void)\n \t/* Do nothing */\n }\n void board_reset(void) __attribute__((weak, alias(\"__board_reset\")));\n+void board_reset_last(void) __attribute__((weak, alias(\"__board_reset\")));\n \n int checkcpu (void)\n {\n@@ -328,6 +329,9 @@ int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])\n \t/* Next try asserting HRESET_REQ */\n \tout_be32(&gur->rstcr, 0x2);\n \tudelay(100);\n+\n+\t/* Attempt last-stage board-specific reset */\n+\tboard_reset_last();\n #endif\n \n \treturn 1;\ndiff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c\nindex 16224752adb1..4bcb05bed9b8 100644\n--- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c\n+++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c\n@@ -83,7 +83,7 @@ struct cpld_data {\n #define CPLD_FXS_LED\t0x0F\n #define CPLD_SYS_RST\t0x00\n \n-void board_reset(void)\n+void board_reset_last(void)\n {\n \tstruct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE);\n \tout_8(&cpld_data->system_rst, 1);\n", "prefixes": [ "v2", "3/4" ] }