Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1658289/?format=api
{ "id": 1658289, "url": "http://patchwork.ozlabs.org/api/patches/1658289/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-11-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-11-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:04:06", "name": "[v12,10/40] virtio_ring: split: extract the logic of attach vring", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "aa5fac7242dd3a8736f5b7a6e622088a13ac388a", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-11-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1658289/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1658289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=JHOw3EiR;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYW5zBxz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:19 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01Q-00HEQC-Ko; Wed, 20 Jul 2022 03:05:12 +0000", "from out199-17.us.a.mail.aliyun.com ([47.90.199.17])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01N-00HEHR-UV\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:05:11 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuvIWU_1658286300)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:05:01 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LaRCw6W0nrQU1CW/0qppLDt9XDDJzz/hyTRaBJ+DS9A=; b=JHOw3EiRBK+0q9\n\tH+PW+EQ0kShN+Xw6xTZutgxUDn+nJgbZ/m9Mz6OeaTT5pg5EmbrAFL7+BLDR8Zp9SMILOSF5R1b6N\n\twgxbRjsQA2wITR+JlRFaT3FCD4Cfde3GtyjlGcAdl7n6pRJ2KXZ9khMs9hk3r4k+AHL67pLmkxHnz\n\tLd41I3LP0QZTWIUEg2AKn5Ma1g8Yy8wIurYU4nP1qajEDR7mYJpNCrvtoH1UG/2rao0rvm/xtDR/g\n\tDLCOpcWyTWFqk+fGt0fVi3+6Vz9uesD0Mg71lYHKhmo3CQ8Aj/94KW1u2E/VnAzJ1JhnLR6dZeU8L\n\tk9pS35nFVQJfUnxiVOGQ==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuvIWU_1658286300;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 10/40] virtio_ring: split: extract the logic of attach\n vring", "Date": "Wed, 20 Jul 2022 11:04:06 +0800", "Message-Id": "<20220720030436.79520-11-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "In-Reply-To": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "References": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200510_280945_A11F8251 ", "X-CRM114-Status": "UNSURE ( 9.37 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Separate the logic of attach vring, subsequent patches will\n call it separately. Since the \"struct vring_virtqueue_split split\" is\n created\n on the stack and has been initialized to 0. So using\n split->queue_dma_addr/split->queue_size_in_bytes\n assignment for queue_dma_addr/queue_size [...]\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Separate the logic of attach vring, subsequent patches will call it\nseparately.\n\nSince the \"struct vring_virtqueue_split split\" is created on the\nstack and has been initialized to 0. So using\nsplit->queue_dma_addr/split->queue_size_in_bytes assignment for\nqueue_dma_addr/queue_size_in_bytes can keep the same as the original\ncode.\n\nOn the other hand, subsequent patches can use the \"struct\nvring_virtqueue_split split\" obtained by vring_alloc_queue_split() to\ndirectly complete the attach operation.\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\nAcked-by: Jason Wang <jasowang@redhat.com>\n---\n drivers/virtio/virtio_ring.c | 21 ++++++++++++++-------\n 1 file changed, 14 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex ef2077e8b38d..b2dbbf68736b 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -940,6 +940,18 @@ static void *virtqueue_detach_unused_buf_split(struct virtqueue *_vq)\n \treturn NULL;\n }\n \n+static void virtqueue_vring_attach_split(struct vring_virtqueue *vq,\n+\t\t\t\t\t struct vring_virtqueue_split *vring_split)\n+{\n+\tvq->split.queue_dma_addr = vring_split->queue_dma_addr;\n+\tvq->split.queue_size_in_bytes = vring_split->queue_size_in_bytes;\n+\n+\tvq->split.vring = vring_split->vring;\n+\n+\tvq->split.desc_state = vring_split->desc_state;\n+\tvq->split.desc_extra = vring_split->desc_extra;\n+}\n+\n static int vring_alloc_state_extra_split(struct vring_virtqueue_split *vring_split)\n {\n \tstruct vring_desc_state_split *state;\n@@ -2288,10 +2300,6 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n \tvq->indirect = virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC) &&\n \t\t!context;\n \n-\tvq->split.queue_dma_addr = 0;\n-\tvq->split.queue_size_in_bytes = 0;\n-\n-\tvq->split.vring = vring;\n \tvq->split.avail_flags_shadow = 0;\n \tvq->split.avail_idx_shadow = 0;\n \n@@ -2311,10 +2319,9 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n \t\treturn NULL;\n \t}\n \n-\tvq->split.desc_state = vring.desc_state;\n-\tvq->split.desc_extra = vring.desc_extra;\n-\n \tvirtqueue_init(vq, vring_split.vring.num);\n+\tvirtqueue_vring_attach_split(vq, &vring_split);\n+\tvirtqueue_vring_init_split(vq);\n \n \tspin_lock(&vdev->vqs_list_lock);\n \tlist_add_tail(&vq->vq.list, &vdev->vqs);\n", "prefixes": [ "v12", "10/40" ] }