Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1658288/?format=api
{ "id": 1658288, "url": "http://patchwork.ozlabs.org/api/patches/1658288/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-10-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-10-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:04:05", "name": "[v12,09/40] virtio_ring: split: extract the logic of alloc state and extra", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "2b1d805f9476a259913f04450ea26ccd6232aed1", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-10-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1658288/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1658288/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yOZih86h;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYP6yksz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:13 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01L-00HEIs-Au; Wed, 20 Jul 2022 03:05:07 +0000", "from out30-42.freemail.mail.aliyun.com ([115.124.30.42])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01I-00HEDt-Ss\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:05:06 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJux8zP_1658286298)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:04:59 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LAAHiJzxiWQFJICTcXV4NqDuoRL23i+ofcB6AMX8lI4=; b=yOZih86hXijrKf\n\tZvjJIl7X0nihUWjt/gzQjiXfVhg46GH3be8sM/74jbJCE5YrhIoKHSDZ/qFOaJs7f5Fja1HFUE5a6\n\tVC/hQqtpCf8lJxOOOLH5L0qWS54c+gN6V6+7V3mffcWLzZAZcugNwg2Y5uxtLkWP8JnYAKPo1Vwlg\n\tWV2i/DdeOPgcnTgOjlJEExv/wbm6oqJ2s1LQ2UBMSHsglH63qHReoN0IGopu9iKcm0d3bULwT1vDO\n\tgErHmaA61z6hwHeoJ7UEIo46W3OJE9HO0W/uUtKxqi8qZvNUROG1GXaNxcpZwPslFzS5FL4w1OdQE\n\tcfj4C+zZ/HfuIoDcQKZw==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R721e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJux8zP_1658286298;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 09/40] virtio_ring: split: extract the logic of alloc\n state and extra", "Date": "Wed, 20 Jul 2022 11:04:05 +0800", "Message-Id": "<20220720030436.79520-10-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "In-Reply-To": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "References": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200505_125062_44432CB3 ", "X-CRM114-Status": "GOOD ( 12.38 )", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Separate the logic of creating desc_state, desc_extra, and\n subsequent patches will call it independently. Since only the structure\n vring\n is passed into __vring_new_virtqueue(),\n when creating the function vring_alloc_state_extra_split(),\n we prefer to use vring_virtqueue_split as a parameter,\n and it will be [...] \n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.42 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Separate the logic of creating desc_state, desc_extra, and subsequent\npatches will call it independently.\n\nSince only the structure vring is passed into __vring_new_virtqueue(),\nwhen creating the function vring_alloc_state_extra_split(), we prefer to\nuse vring_virtqueue_split as a parameter, and it will be more convenient\nto pass vring_virtqueue_split to some subsequent functions.\n\nSo a new vring_virtqueue_split variable is added in\n__vring_new_virtqueue().\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\n---\n drivers/virtio/virtio_ring.c | 54 +++++++++++++++++++++++++-----------\n 1 file changed, 38 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex c7971438bb2c..ef2077e8b38d 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -204,6 +204,7 @@ struct vring_virtqueue {\n #endif\n };\n \n+static struct vring_desc_extra *vring_alloc_desc_extra(unsigned int num);\n \n /*\n * Helpers.\n@@ -939,6 +940,32 @@ static void *virtqueue_detach_unused_buf_split(struct virtqueue *_vq)\n \treturn NULL;\n }\n \n+static int vring_alloc_state_extra_split(struct vring_virtqueue_split *vring_split)\n+{\n+\tstruct vring_desc_state_split *state;\n+\tstruct vring_desc_extra *extra;\n+\tu32 num = vring_split->vring.num;\n+\n+\tstate = kmalloc_array(num, sizeof(struct vring_desc_state_split), GFP_KERNEL);\n+\tif (!state)\n+\t\tgoto err_state;\n+\n+\textra = vring_alloc_desc_extra(num);\n+\tif (!extra)\n+\t\tgoto err_extra;\n+\n+\tmemset(state, 0, num * sizeof(struct vring_desc_state_split));\n+\n+\tvring_split->desc_state = state;\n+\tvring_split->desc_extra = extra;\n+\treturn 0;\n+\n+err_extra:\n+\tkfree(state);\n+err_state:\n+\treturn -ENOMEM;\n+}\n+\n static void vring_free_split(struct vring_virtqueue_split *vring_split,\n \t\t\t struct virtio_device *vdev)\n {\n@@ -2233,7 +2260,9 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n \t\t\t\t\tvoid (*callback)(struct virtqueue *),\n \t\t\t\t\tconst char *name)\n {\n+\tstruct vring_virtqueue_split vring_split = {};\n \tstruct vring_virtqueue *vq;\n+\tint err;\n \n \tif (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED))\n \t\treturn NULL;\n@@ -2274,30 +2303,23 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n \t\t\t\t\tvq->split.avail_flags_shadow);\n \t}\n \n-\tvq->split.desc_state = kmalloc_array(vring.num,\n-\t\t\tsizeof(struct vring_desc_state_split), GFP_KERNEL);\n-\tif (!vq->split.desc_state)\n-\t\tgoto err_state;\n+\tvring_split.vring = vring;\n \n-\tvq->split.desc_extra = vring_alloc_desc_extra(vring.num);\n-\tif (!vq->split.desc_extra)\n-\t\tgoto err_extra;\n+\terr = vring_alloc_state_extra_split(&vring_split);\n+\tif (err) {\n+\t\tkfree(vq);\n+\t\treturn NULL;\n+\t}\n \n-\tmemset(vq->split.desc_state, 0, vring.num *\n-\t\t\tsizeof(struct vring_desc_state_split));\n+\tvq->split.desc_state = vring.desc_state;\n+\tvq->split.desc_extra = vring.desc_extra;\n \n-\tvirtqueue_init(vq, vq->split.vring.num);\n+\tvirtqueue_init(vq, vring_split.vring.num);\n \n \tspin_lock(&vdev->vqs_list_lock);\n \tlist_add_tail(&vq->vq.list, &vdev->vqs);\n \tspin_unlock(&vdev->vqs_list_lock);\n \treturn &vq->vq;\n-\n-err_extra:\n-\tkfree(vq->split.desc_state);\n-err_state:\n-\tkfree(vq);\n-\treturn NULL;\n }\n EXPORT_SYMBOL_GPL(__vring_new_virtqueue);\n \n", "prefixes": [ "v12", "09/40" ] }