Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1658287/?format=api
{ "id": 1658287, "url": "http://patchwork.ozlabs.org/api/patches/1658287/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-9-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-9-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:04:04", "name": "[v12,08/40] virtio_ring: split: extract the logic of alloc queue", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "fea9ce7472e86a29afacec762f6c4bcf10480f58", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-9-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1658287/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1658287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=asHppe8u;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYP26rjz9sFs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:13 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01L-00HEIX-5S; Wed, 20 Jul 2022 03:05:07 +0000", "from out30-57.freemail.mail.aliyun.com ([115.124.30.57])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01H-00HEBh-Q6\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:05:05 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuvIUY_1658286295)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:04:56 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=RTZVvgZfF3CrP5SBKj2XiIeKndNuEAMDooFtj8QQ/Ik=; b=asHppe8ullnWPN\n\t0GNY2nLLERzYP31cZpBryBc65FKSq5g4N0+HchsaN8Ud0Rc30jTsfMPclMKQ2AMkh2zwQFmJ8tGwf\n\toC/sHEFzu++czdmkuDIW1h1BzGl5yPQfRcr710olFBSU0YWaSyAnLJgzfkgW/+Ou+CbwRGBoOv6/I\n\tQz21kSC1GfNg8k5dyrw+QauzdUGOZMacvxfFvdYLN6Z4GbDX6UwScwJaN3uLxlvIj3RPh5SIUD6I9\n\t99sPOauKVC7k7JCemRwU65rWq/VlwCLdWPRBomUBhyaChLZp7q/Lx77F7LY00x5AkngzuG9ZuO20H\n\tMD3iegDsFZ0CRpSsi74Q==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R751e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuvIUY_1658286295;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 08/40] virtio_ring: split: extract the logic of alloc\n queue", "Date": "Wed, 20 Jul 2022 11:04:04 +0800", "Message-Id": "<20220720030436.79520-9-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "In-Reply-To": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "References": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200504_071811_3D4FF506 ", "X-CRM114-Status": "GOOD ( 10.12 )", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Separate the logic of split to create vring queue. This\n feature\n is required for subsequent virtuqueue reset vring. Signed-off-by: Xuan\n Zhuo\n <xuanzhuo@linux.alibaba.com> --- drivers/virtio/virtio_ring.c | 68\n ++++++++++++++++++++++\n 1 file changed, 42 insertions(+), 26 deletions(-)\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.57 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Separate the logic of split to create vring queue.\n\nThis feature is required for subsequent virtuqueue reset vring.\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\n---\n drivers/virtio/virtio_ring.c | 68 ++++++++++++++++++++++--------------\n 1 file changed, 42 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex c94c5461e702..c7971438bb2c 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -950,28 +950,19 @@ static void vring_free_split(struct vring_virtqueue_split *vring_split,\n \tkfree(vring_split->desc_extra);\n }\n \n-static struct virtqueue *vring_create_virtqueue_split(\n-\tunsigned int index,\n-\tunsigned int num,\n-\tunsigned int vring_align,\n-\tstruct virtio_device *vdev,\n-\tbool weak_barriers,\n-\tbool may_reduce_num,\n-\tbool context,\n-\tbool (*notify)(struct virtqueue *),\n-\tvoid (*callback)(struct virtqueue *),\n-\tconst char *name)\n+static int vring_alloc_queue_split(struct vring_virtqueue_split *vring_split,\n+\t\t\t\t struct virtio_device *vdev,\n+\t\t\t\t u32 num,\n+\t\t\t\t unsigned int vring_align,\n+\t\t\t\t bool may_reduce_num)\n {\n-\tstruct virtqueue *vq;\n \tvoid *queue = NULL;\n \tdma_addr_t dma_addr;\n-\tsize_t queue_size_in_bytes;\n-\tstruct vring vring;\n \n \t/* We assume num is a power of 2. */\n \tif (num & (num - 1)) {\n \t\tdev_warn(&vdev->dev, \"Bad virtqueue length %u\\n\", num);\n-\t\treturn NULL;\n+\t\treturn -EINVAL;\n \t}\n \n \t/* TODO: allocate each queue chunk individually */\n@@ -982,11 +973,11 @@ static struct virtqueue *vring_create_virtqueue_split(\n \t\tif (queue)\n \t\t\tbreak;\n \t\tif (!may_reduce_num)\n-\t\t\treturn NULL;\n+\t\t\treturn -ENOMEM;\n \t}\n \n \tif (!num)\n-\t\treturn NULL;\n+\t\treturn -ENOMEM;\n \n \tif (!queue) {\n \t\t/* Try to get a single page. You are my only hope! */\n@@ -994,21 +985,46 @@ static struct virtqueue *vring_create_virtqueue_split(\n \t\t\t\t\t &dma_addr, GFP_KERNEL|__GFP_ZERO);\n \t}\n \tif (!queue)\n-\t\treturn NULL;\n+\t\treturn -ENOMEM;\n+\n+\tvring_init(&vring_split->vring, num, queue, vring_align);\n \n-\tqueue_size_in_bytes = vring_size(num, vring_align);\n-\tvring_init(&vring, num, queue, vring_align);\n+\tvring_split->queue_dma_addr = dma_addr;\n+\tvring_split->queue_size_in_bytes = vring_size(num, vring_align);\n+\n+\treturn 0;\n+}\n+\n+static struct virtqueue *vring_create_virtqueue_split(\n+\tunsigned int index,\n+\tunsigned int num,\n+\tunsigned int vring_align,\n+\tstruct virtio_device *vdev,\n+\tbool weak_barriers,\n+\tbool may_reduce_num,\n+\tbool context,\n+\tbool (*notify)(struct virtqueue *),\n+\tvoid (*callback)(struct virtqueue *),\n+\tconst char *name)\n+{\n+\tstruct vring_virtqueue_split vring_split = {};\n+\tstruct virtqueue *vq;\n+\tint err;\n+\n+\terr = vring_alloc_queue_split(&vring_split, vdev, num, vring_align,\n+\t\t\t\t may_reduce_num);\n+\tif (err)\n+\t\treturn NULL;\n \n-\tvq = __vring_new_virtqueue(index, vring, vdev, weak_barriers, context,\n-\t\t\t\t notify, callback, name);\n+\tvq = __vring_new_virtqueue(index, vring_split.vring, vdev, weak_barriers,\n+\t\t\t\t context, notify, callback, name);\n \tif (!vq) {\n-\t\tvring_free_queue(vdev, queue_size_in_bytes, queue,\n-\t\t\t\t dma_addr);\n+\t\tvring_free_split(&vring_split, vdev);\n \t\treturn NULL;\n \t}\n \n-\tto_vvq(vq)->split.queue_dma_addr = dma_addr;\n-\tto_vvq(vq)->split.queue_size_in_bytes = queue_size_in_bytes;\n+\tto_vvq(vq)->split.queue_dma_addr = vring_split.queue_dma_addr;\n+\tto_vvq(vq)->split.queue_size_in_bytes = vring_split.queue_size_in_bytes;\n \tto_vvq(vq)->we_own_ring = true;\n \n \treturn vq;\n", "prefixes": [ "v12", "08/40" ] }