Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1658284/?format=api
{ "id": 1658284, "url": "http://patchwork.ozlabs.org/api/patches/1658284/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-2-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-2-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:03:57", "name": "[v12,01/40] virtio: record the maximum queue num supported by the device.", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "dbeaaff0bdb75ae8647e189b079f401f684f9c81", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-2-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1658284/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1658284/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1dHe+dqL;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYL1WmHz9sFs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:10 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE016-00HE3f-Cm; Wed, 20 Jul 2022 03:04:52 +0000", "from out30-54.freemail.mail.aliyun.com ([115.124.30.54])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE013-00HDwc-BA\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:04:51 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJux8u6_1658286278)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:04:40 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=kpohdBTWAiq02fIVf4cd+cq1S7QBCTKjvUY47XveKlg=; b=1dHe+dqLhbMrpn\n\tnXiHNfRWOvTB6JAHX2D9cNk/DnEPIhKwOKXD/y0xf+6mELnO9RVFYu0ti5RZyoFThxyX7lhKkr6dv\n\tuO8kNxNTOTc9zyYXBYUQt8rsQMnQuydd6kqJeCNRWickBUtY1DGmuLmg3oT9VTEZaJCoJWnE+PNpf\n\tw7tOGWmYMVdVUhZ2tdDbKaMtZqeGRZCve/NdL8bkm14F4HQ0J2pOaEVgLdZHuGlxrJQia+y3O/mi5\n\tZYQjryMf053GWaHTXD2eivi4ONs6Q+EHsGkIZmYKJ5os3ozo9d6frMujRrsLH7adjvM0LlFePr3nq\n\t3J5noJ7QDWPh3ZeYtX1Q==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJux8u6_1658286278;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 01/40] virtio: record the maximum queue num supported by\n the device.", "Date": "Wed, 20 Jul 2022 11:03:57 +0800", "Message-Id": "<20220720030436.79520-2-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "In-Reply-To": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "References": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200449_581156_733E53D9 ", "X-CRM114-Status": "GOOD ( 12.78 )", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: virtio-net can display the maximum (supported by hardware)\n ring size in ethtool -g eth0. When the subsequent patch implements vring\n reset,\n it can judge whether the ring size passed by the driver is legal based\n on this.\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.54 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "virtio-net can display the maximum (supported by hardware) ring size in\nethtool -g eth0.\n\nWhen the subsequent patch implements vring reset, it can judge whether\nthe ring size passed by the driver is legal based on this.\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\n---\n arch/um/drivers/virtio_uml.c | 1 +\n drivers/platform/mellanox/mlxbf-tmfifo.c | 2 ++\n drivers/remoteproc/remoteproc_virtio.c | 2 ++\n drivers/s390/virtio/virtio_ccw.c | 3 +++\n drivers/virtio/virtio_mmio.c | 2 ++\n drivers/virtio/virtio_pci_legacy.c | 2 ++\n drivers/virtio/virtio_pci_modern.c | 2 ++\n drivers/virtio/virtio_vdpa.c | 2 ++\n include/linux/virtio.h | 2 ++\n 9 files changed, 18 insertions(+)", "diff": "diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c\nindex 82ff3785bf69..e719af8bdf56 100644\n--- a/arch/um/drivers/virtio_uml.c\n+++ b/arch/um/drivers/virtio_uml.c\n@@ -958,6 +958,7 @@ static struct virtqueue *vu_setup_vq(struct virtio_device *vdev,\n \t\tgoto error_create;\n \t}\n \tvq->priv = info;\n+\tvq->num_max = num;\n \tnum = virtqueue_get_vring_size(vq);\n \n \tif (vu_dev->protocol_features &\ndiff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c\nindex 38800e86ed8a..1ae3c56b66b0 100644\n--- a/drivers/platform/mellanox/mlxbf-tmfifo.c\n+++ b/drivers/platform/mellanox/mlxbf-tmfifo.c\n@@ -959,6 +959,8 @@ static int mlxbf_tmfifo_virtio_find_vqs(struct virtio_device *vdev,\n \t\t\tgoto error;\n \t\t}\n \n+\t\tvq->num_max = vring->num;\n+\n \t\tvqs[i] = vq;\n \t\tvring->vq = vq;\n \t\tvq->priv = vring;\ndiff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c\nindex d43d74733f0a..0f7706e23eb9 100644\n--- a/drivers/remoteproc/remoteproc_virtio.c\n+++ b/drivers/remoteproc/remoteproc_virtio.c\n@@ -125,6 +125,8 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev,\n \t\treturn ERR_PTR(-ENOMEM);\n \t}\n \n+\tvq->num_max = num;\n+\n \trvring->vq = vq;\n \tvq->priv = rvring;\n \ndiff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c\nindex 161d3b141f0d..6b86d0280d6b 100644\n--- a/drivers/s390/virtio/virtio_ccw.c\n+++ b/drivers/s390/virtio/virtio_ccw.c\n@@ -530,6 +530,9 @@ static struct virtqueue *virtio_ccw_setup_vq(struct virtio_device *vdev,\n \t\terr = -ENOMEM;\n \t\tgoto out_err;\n \t}\n+\n+\tvq->num_max = info->num;\n+\n \t/* it may have been reduced */\n \tinfo->num = virtqueue_get_vring_size(vq);\n \ndiff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c\nindex 083ff1eb743d..a20d5a6b5819 100644\n--- a/drivers/virtio/virtio_mmio.c\n+++ b/drivers/virtio/virtio_mmio.c\n@@ -403,6 +403,8 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned int in\n \t\tgoto error_new_virtqueue;\n \t}\n \n+\tvq->num_max = num;\n+\n \t/* Activate the queue */\n \twritel(virtqueue_get_vring_size(vq), vm_dev->base + VIRTIO_MMIO_QUEUE_NUM);\n \tif (vm_dev->version == 1) {\ndiff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c\nindex a5e5721145c7..2257f1b3d8ae 100644\n--- a/drivers/virtio/virtio_pci_legacy.c\n+++ b/drivers/virtio/virtio_pci_legacy.c\n@@ -135,6 +135,8 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,\n \tif (!vq)\n \t\treturn ERR_PTR(-ENOMEM);\n \n+\tvq->num_max = num;\n+\n \tq_pfn = virtqueue_get_desc_addr(vq) >> VIRTIO_PCI_QUEUE_ADDR_SHIFT;\n \tif (q_pfn >> 32) {\n \t\tdev_err(&vp_dev->pci_dev->dev,\ndiff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c\nindex 623906b4996c..e7e0b8c850f6 100644\n--- a/drivers/virtio/virtio_pci_modern.c\n+++ b/drivers/virtio/virtio_pci_modern.c\n@@ -218,6 +218,8 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,\n \tif (!vq)\n \t\treturn ERR_PTR(-ENOMEM);\n \n+\tvq->num_max = num;\n+\n \t/* activate the queue */\n \tvp_modern_set_queue_size(mdev, index, virtqueue_get_vring_size(vq));\n \tvp_modern_queue_address(mdev, index, virtqueue_get_desc_addr(vq),\ndiff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c\nindex c40f7deb6b5a..9670cc79371d 100644\n--- a/drivers/virtio/virtio_vdpa.c\n+++ b/drivers/virtio/virtio_vdpa.c\n@@ -183,6 +183,8 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,\n \t\tgoto error_new_virtqueue;\n \t}\n \n+\tvq->num_max = max_num;\n+\n \t/* Setup virtqueue callback */\n \tcb.callback = callback ? virtio_vdpa_virtqueue_cb : NULL;\n \tcb.private = info;\ndiff --git a/include/linux/virtio.h b/include/linux/virtio.h\nindex d8fdf170637c..129bde7521e3 100644\n--- a/include/linux/virtio.h\n+++ b/include/linux/virtio.h\n@@ -19,6 +19,7 @@\n * @priv: a pointer for the virtqueue implementation to use.\n * @index: the zero-based ordinal number for this queue.\n * @num_free: number of elements we expect to be able to fit.\n+ * @num_max: the maximum number of elements supported by the device.\n *\n * A note on @num_free: with indirect buffers, each buffer needs one\n * element in the queue, otherwise a buffer will need one element per\n@@ -31,6 +32,7 @@ struct virtqueue {\n \tstruct virtio_device *vdev;\n \tunsigned int index;\n \tunsigned int num_free;\n+\tunsigned int num_max;\n \tvoid *priv;\n };\n \n", "prefixes": [ "v12", "01/40" ] }