Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1658283/?format=api
{ "id": 1658283, "url": "http://patchwork.ozlabs.org/api/patches/1658283/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-6-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-6-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:04:01", "name": "[v12,05/40] virtio_ring: split vring_virtqueue", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "455dd0f731614345d5975b2fbd992b9ff971c16c", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-6-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1658283/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1658283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ifya8RwI;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYJ0cGPz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:08 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01B-00HE8j-H9; Wed, 20 Jul 2022 03:04:57 +0000", "from out30-132.freemail.mail.aliyun.com ([115.124.30.132])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE018-00HE4D-OM\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:04:56 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuw0JL_1658286288)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:04:49 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=/Bfyz4muHc8kDsbS0ffnu6CVA2ACSnCGpRjpZriQOpo=; b=Ifya8RwI63mntw\n\ttTbqmSwyg9UmGh5lNsnE0cVRs/PsJOoKDkbm2gi5ULjfb7CXcLDXyG2l6UFeFR02SGjAfmUuw+54K\n\tYPUgtxK0JeeZWKBOuAEsd5aqW7xnqz5U7Dzwb6DvrR/UeHdezaljfrfwMDPFQXLCzN4VWz9+WAovV\n\tQsNUrjx8WQ8yoqrMgAOcSaD8F1Bxbkodi1dAfmXLlG79SrFBZXPd6PfwAgH0+qK2kxuyRUTZPs5TW\n\tS7US51DSfKtRe+QCCw9k7PAtJ+nobTUYwNYdA2txemma2mFGD4378tDW8kdKMS06YASoU5YEGc0Ue\n\tr/E2c0d1O1qy1KxKgc5w==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R841e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuw0JL_1658286288;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 05/40] virtio_ring: split vring_virtqueue", "Date": "Wed, 20 Jul 2022 11:04:01 +0800", "Message-Id": "<20220720030436.79520-6-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "In-Reply-To": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "References": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200454_979841_A852E70B ", "X-CRM114-Status": "GOOD ( 10.78 )", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Separate the two inline structures(split and packed) from\n the structure vring_virtqueue. In this way, we can use these two structures\n later to pass parameters and retain temporary variables. Signed-off-by:\n Xuan\n Zhuo <xuanzhuo@linux.alibaba.com> Acked-by: Jason Wang\n <jasowang@redhat.com>\n --- drivers/virtio/virtio_ring.c | 116 ++++++++++++++++++ 1 file changed,\n 60 insertion [...]\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.132 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Separate the two inline structures(split and packed) from the structure\nvring_virtqueue.\n\nIn this way, we can use these two structures later to pass parameters\nand retain temporary variables.\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\nAcked-by: Jason Wang <jasowang@redhat.com>\n---\n drivers/virtio/virtio_ring.c | 116 ++++++++++++++++++-----------------\n 1 file changed, 60 insertions(+), 56 deletions(-)", "diff": "diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex a3d76fd87983..1bc5794e9739 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -85,6 +85,64 @@ struct vring_desc_extra {\n \tu16 next;\t\t\t/* The next desc state in a list. */\n };\n \n+struct vring_virtqueue_split {\n+\t/* Actual memory layout for this queue. */\n+\tstruct vring vring;\n+\n+\t/* Last written value to avail->flags */\n+\tu16 avail_flags_shadow;\n+\n+\t/*\n+\t * Last written value to avail->idx in\n+\t * guest byte order.\n+\t */\n+\tu16 avail_idx_shadow;\n+\n+\t/* Per-descriptor state. */\n+\tstruct vring_desc_state_split *desc_state;\n+\tstruct vring_desc_extra *desc_extra;\n+\n+\t/* DMA address and size information */\n+\tdma_addr_t queue_dma_addr;\n+\tsize_t queue_size_in_bytes;\n+};\n+\n+struct vring_virtqueue_packed {\n+\t/* Actual memory layout for this queue. */\n+\tstruct {\n+\t\tunsigned int num;\n+\t\tstruct vring_packed_desc *desc;\n+\t\tstruct vring_packed_desc_event *driver;\n+\t\tstruct vring_packed_desc_event *device;\n+\t} vring;\n+\n+\t/* Driver ring wrap counter. */\n+\tbool avail_wrap_counter;\n+\n+\t/* Avail used flags. */\n+\tu16 avail_used_flags;\n+\n+\t/* Index of the next avail descriptor. */\n+\tu16 next_avail_idx;\n+\n+\t/*\n+\t * Last written value to driver->flags in\n+\t * guest byte order.\n+\t */\n+\tu16 event_flags_shadow;\n+\n+\t/* Per-descriptor state. */\n+\tstruct vring_desc_state_packed *desc_state;\n+\tstruct vring_desc_extra *desc_extra;\n+\n+\t/* DMA address and size information */\n+\tdma_addr_t ring_dma_addr;\n+\tdma_addr_t driver_event_dma_addr;\n+\tdma_addr_t device_event_dma_addr;\n+\tsize_t ring_size_in_bytes;\n+\tsize_t event_size_in_bytes;\n+};\n+\n struct vring_virtqueue {\n \tstruct virtqueue vq;\n \n@@ -124,64 +182,10 @@ struct vring_virtqueue {\n \n \tunion {\n \t\t/* Available for split ring */\n-\t\tstruct {\n-\t\t\t/* Actual memory layout for this queue. */\n-\t\t\tstruct vring vring;\n-\n-\t\t\t/* Last written value to avail->flags */\n-\t\t\tu16 avail_flags_shadow;\n-\n-\t\t\t/*\n-\t\t\t * Last written value to avail->idx in\n-\t\t\t * guest byte order.\n-\t\t\t */\n-\t\t\tu16 avail_idx_shadow;\n-\n-\t\t\t/* Per-descriptor state. */\n-\t\t\tstruct vring_desc_state_split *desc_state;\n-\t\t\tstruct vring_desc_extra *desc_extra;\n-\n-\t\t\t/* DMA address and size information */\n-\t\t\tdma_addr_t queue_dma_addr;\n-\t\t\tsize_t queue_size_in_bytes;\n-\t\t} split;\n+\t\tstruct vring_virtqueue_split split;\n \n \t\t/* Available for packed ring */\n-\t\tstruct {\n-\t\t\t/* Actual memory layout for this queue. */\n-\t\t\tstruct {\n-\t\t\t\tunsigned int num;\n-\t\t\t\tstruct vring_packed_desc *desc;\n-\t\t\t\tstruct vring_packed_desc_event *driver;\n-\t\t\t\tstruct vring_packed_desc_event *device;\n-\t\t\t} vring;\n-\n-\t\t\t/* Driver ring wrap counter. */\n-\t\t\tbool avail_wrap_counter;\n-\n-\t\t\t/* Avail used flags. */\n-\t\t\tu16 avail_used_flags;\n-\n-\t\t\t/* Index of the next avail descriptor. */\n-\t\t\tu16 next_avail_idx;\n-\n-\t\t\t/*\n-\t\t\t * Last written value to driver->flags in\n-\t\t\t * guest byte order.\n-\t\t\t */\n-\t\t\tu16 event_flags_shadow;\n-\n-\t\t\t/* Per-descriptor state. */\n-\t\t\tstruct vring_desc_state_packed *desc_state;\n-\t\t\tstruct vring_desc_extra *desc_extra;\n-\n-\t\t\t/* DMA address and size information */\n-\t\t\tdma_addr_t ring_dma_addr;\n-\t\t\tdma_addr_t driver_event_dma_addr;\n-\t\t\tdma_addr_t device_event_dma_addr;\n-\t\t\tsize_t ring_size_in_bytes;\n-\t\t\tsize_t event_size_in_bytes;\n-\t\t} packed;\n+\t\tstruct vring_virtqueue_packed packed;\n \t};\n \n \t/* How to notify other side. FIXME: commonalize hcalls! */\n", "prefixes": [ "v12", "05/40" ] }