Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1658282/?format=api
{ "id": 1658282, "url": "http://patchwork.ozlabs.org/api/patches/1658282/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-7-xuanzhuo@linux.alibaba.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220720030436.79520-7-xuanzhuo@linux.alibaba.com>", "list_archive_url": null, "date": "2022-07-20T03:04:02", "name": "[v12,06/40] virtio_ring: introduce virtqueue_init()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "85ccd06d2dca59f1777118ef13040c4cccc7fbac", "submitter": { "id": 80519, "url": "http://patchwork.ozlabs.org/api/people/80519/?format=api", "name": "Xuan Zhuo", "email": "xuanzhuo@linux.alibaba.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-7-xuanzhuo@linux.alibaba.com/mbox/", "series": [ { "id": 310331, "url": "http://patchwork.ozlabs.org/api/series/310331/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=310331", "date": "2022-07-20T03:03:59", "name": "virtio pci support VIRTIO_F_RING_RESET", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/310331/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1658282/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1658282/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=AhM6i8Ws;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYG3xqLz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:06 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01D-00HEAV-MH; Wed, 20 Jul 2022 03:04:59 +0000", "from out30-130.freemail.mail.aliyun.com ([115.124.30.130])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01A-00HE5V-Q2\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:04:58 +0000", "from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuyeD2_1658286290)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:04:52 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=EdA29EtRd+11uPxLL3Oi05VDbaVq7+7JxHMXyIWhA3U=; b=AhM6i8Ws6qEfH6\n\tzige2hOMTvr76dG8yVdXnpDc0shLIrMNl74vY0TFIGWz+VFP4g8ZJD6e0b5PuYPElOjHavo5pt7Nb\n\tOx5VchEVPRiwg8wvd9eXGNT7bbcsxydgL7lI4OHTn1N9lhcF6kebK2BN38ngBMdzGmPbDgQ8XHTUy\n\tdpp/aa1frtKrQou5m3jstVEoc9qJaGUvB+gvz1r7YIz8ZSdp943HxWFIYtf3UlHM0bGbJjtmnOc+D\n\tw9dxBs8O4Z7Pa2Y6QpvRVpACWs0A1N5Rgrfw7yG25nXEv5tDirVZplU1U+ux7wPp8+HnIe0NmjUDB\n\tLNMnwHdVl94Xh0jHso4A==;", "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuyeD2_1658286290;", "From": "Xuan Zhuo <xuanzhuo@linux.alibaba.com>", "To": "virtualization@lists.linux-foundation.org", "Cc": "Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com", "Subject": "[PATCH v12 06/40] virtio_ring: introduce virtqueue_init()", "Date": "Wed, 20 Jul 2022 11:04:02 +0800", "Message-Id": "<20220720030436.79520-7-xuanzhuo@linux.alibaba.com>", "X-Mailer": "git-send-email 2.31.0", "In-Reply-To": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "References": "<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>", "MIME-Version": "1.0", "X-Git-Hash": "366032b2ffac", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20220719_200457_040934_728C8A65 ", "X-CRM114-Status": "UNSURE ( 9.37 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-8.0 (--------)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Separate the logic of virtqueue initialization. This logic\n is irrelevant to ring layout. This logic can be called independently when\n implementing resize/reset later. Signed-off-by: Xuan Zhuo\n <xuanzhuo@linux.alibaba.com>\n --- drivers/virtio/virtio_ring.c | 61 ++++++++++++++++++ 1 file changed,\n 31 insertions(+), 30 deletions(-)\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.130 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Separate the logic of virtqueue initialization. This logic is irrelevant\nto ring layout.\n\nThis logic can be called independently when implementing resize/reset\nlater.\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\n---\n drivers/virtio/virtio_ring.c | 61 ++++++++++++++++++------------------\n 1 file changed, 31 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex 1bc5794e9739..87ce17562b29 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -368,6 +368,34 @@ static int vring_mapping_error(const struct vring_virtqueue *vq,\n \treturn dma_mapping_error(vring_dma_dev(vq), addr);\n }\n \n+static void virtqueue_init(struct vring_virtqueue *vq, u32 num)\n+{\n+\tstruct virtio_device *vdev;\n+\n+\tvdev = vq->vq.vdev;\n+\n+\tvq->vq.num_free = num;\n+\tif (vq->packed_ring)\n+\t\tvq->last_used_idx = 0 | (1 << VRING_PACKED_EVENT_F_WRAP_CTR);\n+\telse\n+\t\tvq->last_used_idx = 0;\n+\tvq->event_triggered = false;\n+\tvq->num_added = 0;\n+\tvq->use_dma_api = vring_use_dma_api(vdev);\n+#ifdef DEBUG\n+\tvq->in_use = false;\n+\tvq->last_add_time_valid = false;\n+#endif\n+\n+\tvq->event = virtio_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX);\n+\n+\tif (virtio_has_feature(vdev, VIRTIO_F_ORDER_PLATFORM))\n+\t\tvq->weak_barriers = false;\n+\n+\t/* Put everything in free lists. */\n+\tvq->free_head = 0;\n+}\n+\n \n /*\n * Split ring specific functions - *_split().\n@@ -1706,7 +1734,6 @@ static struct virtqueue *vring_create_virtqueue_packed(\n \tvq->vq.callback = callback;\n \tvq->vq.vdev = vdev;\n \tvq->vq.name = name;\n-\tvq->vq.num_free = num;\n \tvq->vq.index = index;\n \tvq->we_own_ring = true;\n \tvq->notify = notify;\n@@ -1716,22 +1743,10 @@ static struct virtqueue *vring_create_virtqueue_packed(\n #else\n \tvq->broken = false;\n #endif\n-\tvq->last_used_idx = 0 | (1 << VRING_PACKED_EVENT_F_WRAP_CTR);\n-\tvq->event_triggered = false;\n-\tvq->num_added = 0;\n \tvq->packed_ring = true;\n-\tvq->use_dma_api = vring_use_dma_api(vdev);\n-#ifdef DEBUG\n-\tvq->in_use = false;\n-\tvq->last_add_time_valid = false;\n-#endif\n \n \tvq->indirect = virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC) &&\n \t\t!context;\n-\tvq->event = virtio_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX);\n-\n-\tif (virtio_has_feature(vdev, VIRTIO_F_ORDER_PLATFORM))\n-\t\tvq->weak_barriers = false;\n \n \tvq->packed.ring_dma_addr = ring_dma_addr;\n \tvq->packed.driver_event_dma_addr = driver_event_dma_addr;\n@@ -1759,8 +1774,7 @@ static struct virtqueue *vring_create_virtqueue_packed(\n \tmemset(vq->packed.desc_state, 0,\n \t\tnum * sizeof(struct vring_desc_state_packed));\n \n-\t/* Put everything in free lists. */\n-\tvq->free_head = 0;\n+\tvirtqueue_init(vq, num);\n \n \tvq->packed.desc_extra = vring_alloc_desc_extra(num);\n \tif (!vq->packed.desc_extra)\n@@ -2205,7 +2219,6 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n \tvq->vq.callback = callback;\n \tvq->vq.vdev = vdev;\n \tvq->vq.name = name;\n-\tvq->vq.num_free = vring.num;\n \tvq->vq.index = index;\n \tvq->we_own_ring = false;\n \tvq->notify = notify;\n@@ -2215,21 +2228,9 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n #else\n \tvq->broken = false;\n #endif\n-\tvq->last_used_idx = 0;\n-\tvq->event_triggered = false;\n-\tvq->num_added = 0;\n-\tvq->use_dma_api = vring_use_dma_api(vdev);\n-#ifdef DEBUG\n-\tvq->in_use = false;\n-\tvq->last_add_time_valid = false;\n-#endif\n \n \tvq->indirect = virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC) &&\n \t\t!context;\n-\tvq->event = virtio_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX);\n-\n-\tif (virtio_has_feature(vdev, VIRTIO_F_ORDER_PLATFORM))\n-\t\tvq->weak_barriers = false;\n \n \tvq->split.queue_dma_addr = 0;\n \tvq->split.queue_size_in_bytes = 0;\n@@ -2255,11 +2256,11 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n \tif (!vq->split.desc_extra)\n \t\tgoto err_extra;\n \n-\t/* Put everything in free lists. */\n-\tvq->free_head = 0;\n \tmemset(vq->split.desc_state, 0, vring.num *\n \t\t\tsizeof(struct vring_desc_state_split));\n \n+\tvirtqueue_init(vq, vq->split.vring.num);\n+\n \tspin_lock(&vdev->vqs_list_lock);\n \tlist_add_tail(&vq->vq.list, &vdev->vqs);\n \tspin_unlock(&vdev->vqs_list_lock);\n", "prefixes": [ "v12", "06/40" ] }