Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1629703/?format=api
{ "id": 1629703, "url": "http://patchwork.ozlabs.org/api/patches/1629703/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220511182713.26790-1-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220511182713.26790-1-pali@kernel.org>", "list_archive_url": null, "date": "2022-05-11T18:27:12", "name": "[1/2] mmc: fsl_esdhc: Set fallback mode to 1-bit", "commit_ref": "a29eb319a3f8ccfb657053b2941581fa1933974e", "pull_url": null, "state": "accepted", "archived": false, "hash": "84c62210fbe22d74d9607f3adacc99e77064e48b", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 55230, "url": "http://patchwork.ozlabs.org/api/users/55230/?format=api", "username": "freenix", "first_name": "Peng", "last_name": "Fan", "email": "van.freenix@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220511182713.26790-1-pali@kernel.org/mbox/", "series": [ { "id": 299685, "url": "http://patchwork.ozlabs.org/api/series/299685/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=299685", "date": "2022-05-11T18:27:13", "name": "[1/2] mmc: fsl_esdhc: Set fallback mode to 1-bit", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/299685/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1629703/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1629703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=u0cU6kJt;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"u0cU6kJt\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kz4Yr3hbRz9sFk\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 May 2022 05:22:54 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1D8CD84355;\n\tWed, 11 May 2022 20:28:00 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 620CD8434C; Wed, 11 May 2022 20:27:53 +0200 (CEST)", "from ams.source.kernel.org (unknown [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B3F9B841FF\n for <u-boot@lists.denx.de>; Wed, 11 May 2022 20:27:48 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 613C5B825EE;\n Wed, 11 May 2022 18:27:28 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id EC8C8C340EE;\n Wed, 11 May 2022 18:27:26 +0000 (UTC)", "by pali.im (Postfix)\n id 3AF5421A6; Wed, 11 May 2022 20:27:24 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,\n SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1652293647;\n bh=5pVL9kwSINQ2aT2NSLYND01Sh1NzWb0ZAQyVYzXr//c=;\n h=From:To:Cc:Subject:Date:From;\n b=u0cU6kJtcIvHvEQKtMmPoVi9MEvlpSM4Po51MCLn0gzQN0+IYhKKBp65fOBNLgsiQ\n 4dXvFftmW+eJ3zseChBCCvk0KL6i1532FI9n0tzXZnhHZ2uWTKV0zkTKKfLQbQmmPF\n nHSaG8jK4GJNDc+Jh2lOYLN0Y8e40w8VymCgxN2w8higKUieDLCyOXIFPyXyKXzzGI\n gVHpQ2oAymPuD4BSzXKNE7As2183DpE14mhFVhIkndCcWIasy/K+uc5Cy+BX3RU1d9\n Ee6+mwcBn2YVavcBMoDFuP4R/DhECNRvCe7YuOpvSxB8QiY9tXOBltx2OGK9arveIw\n zrIysHX3a87iQ==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Peng Fan <peng.fan@nxp.com>, Jaehoon Chung <jh80.chung@samsung.com>,\n Priyanka Jain <priyanka.jain@nxp.com>, Sinan Akman <sinan@writeme.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 1/2] mmc: fsl_esdhc: Set fallback mode to 1-bit", "Date": "Wed, 11 May 2022 20:27:12 +0200", "Message-Id": "<20220511182713.26790-1-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "8-bit mode is not supported by SD cards and on P2020 are four SDHC pins\nshared with SPI (so if P2020 board have also SPI then only 4-bit SDHC mode\nis provided). So 8-bit SDHC mode is really bad default.\n\nWhen max bus width is not provided then set mode to 1-bit. This mode is\nsupported by all cards, so it is the best option for fallback mode.\n\nAlso P2020 bootrom sets mode to 1-bit when booting from SD/MMC card.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n drivers/mmc/fsl_esdhc.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c\nindex 3b3587bd8d72..834f8933b0c6 100644\n--- a/drivers/mmc/fsl_esdhc.c\n+++ b/drivers/mmc/fsl_esdhc.c\n@@ -963,9 +963,8 @@ int fsl_esdhc_initialize(struct bd_info *bis, struct fsl_esdhc_cfg *cfg)\n \t} else if (cfg->max_bus_width == 1) {\n \t\tmmc_cfg->host_caps |= MMC_MODE_1BIT;\n \t} else {\n-\t\tmmc_cfg->host_caps |= MMC_MODE_1BIT | MMC_MODE_4BIT |\n-\t\t\t\t MMC_MODE_8BIT;\n-\t\tprintf(\"No max bus width provided. Assume 8-bit supported.\\n\");\n+\t\tmmc_cfg->host_caps |= MMC_MODE_1BIT;\n+\t\tprintf(\"No max bus width provided. Fallback to 1-bit mode.\\n\");\n \t}\n \n \tif (IS_ENABLED(CONFIG_ESDHC_DETECT_8_BIT_QUIRK))\n", "prefixes": [ "1/2" ] }