Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627235/?format=api
{ "id": 1627235, "url": "http://patchwork.ozlabs.org/api/patches/1627235/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-27-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-27-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:34", "name": "[PULL,26/30] target/ppc: Remove msr_ts macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7e0022e1217164d92d5b0dee595498027a2ba8d4", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-27-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627235/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627235/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=fhqYWAFl;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPgJ47xzz9sCq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:59:56 +1000 (AEST)", "from localhost ([::1]:55470 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhdi-0005Vg-D9\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:59:54 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:48290)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZV-0003w6-JB; Thu, 05 May 2022 14:51:29 -0400", "from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:39568)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZT-0004oH-Sj; Thu, 05 May 2022 14:51:29 -0400", "by mail-ot1-x336.google.com with SMTP id\n z15-20020a9d65cf000000b00605f064482cso3519111oth.6;\n Thu, 05 May 2022 11:51:27 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.51.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:51:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=IdCfcze6EGR9I8aqWW73Q8OAoWf7FWuqvqpGkA3rNHg=;\n b=fhqYWAFly7VinC7Aep10TmT1eYY3rYm1jGA+BSI5KoA0g+/HKoXd2x6dRYugbvwiPN\n BOhM+nK2d2R4Yh2Qh/98NrS064dwA/DqLF4/ehQC7JJuGnHRkYe3wO0yDcoQz1iw+uXz\n WVtkfHJicFymAOACEDOkO27/bN9aO3WSa/EnKmMWrpDTuu2CG5/u3g0+51EtvWduyeSj\n D6Q3oy2CXK6GwYl1gZSRFM/Je4AEZmvIjK/5scD2bT7OCc70tJTpUWywdoJHuBsCZHT6\n Zwz7LiUbvqv/v/w6yCrT4AVt6SL6XlsVphGTFU2YUu0CzYW4DDD4WhOG8RHgeUS6+z/V\n lKBQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=IdCfcze6EGR9I8aqWW73Q8OAoWf7FWuqvqpGkA3rNHg=;\n b=BKQ0kWiQ2FMTTmnsQCexGWjMn9Inzl7/EQliybu5iFZKvToh3LRG7arPRo+KYVl3gf\n VyGUdcYNtL2ywmMZ/MgvY5Ee8t30mw9SRxAlwnE8Uyx12klg2NAkhFq9auBBla1S4rSM\n sxpr9GS/arnSifg/BDXd7rm98oFz05jRbunPyO3Lpa4SjZpq4BjafQ7xBDQgV4rCoj+/\n XKQcUsStI6ViqA2X3Q5YF5z7MZ4+1IuB8+pC/pC02dX3uDr0r+cqFVgN7WBff1f4Jj9m\n Dmj1w3WO8/sa0fvk0rLwtPbjkLgph+zt1t/kuyzOkMyoPKi5ai5dn9Ipkak5b4HyJYV8\n b4BA==", "X-Gm-Message-State": "AOAM531A/fxVW2FswaY9J+K16YR50QnMkFCAY4BXfCv7Cigmeq2X10Zn\n uep/mVDOtetNAqPCMkkoQtvUXs5Q7hE=", "X-Google-Smtp-Source": "\n ABdhPJwCTDZ2CupblSsHNySGbnQD3X+Hy8DcYDVLitEtxEnUfCeOPNZZQ03SzPeLTsNxJ85zRCEUGQ==", "X-Received": "by 2002:a05:6830:2375:b0:605:f3fb:79ab with SMTP id\n r21-20020a056830237500b00605f3fb79abmr10172685oth.261.1651776686803;\n Thu, 05 May 2022 11:51:26 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 26/30] target/ppc: Remove msr_ts macro", "Date": "Thu, 5 May 2022 15:49:34 -0300", "Message-Id": "<20220505184938.351866-27-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::336;\n envelope-from=danielhb413@gmail.com; helo=mail-ot1-x336.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_ts macro hides the usage of env->msr, which is a bad\nbehavior. Substitute it with FIELD_EX64 calls that explicitly use\nenv->msr as a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-19-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 2 +-\n target/ppc/kvm.c | 4 ++--\n target/ppc/machine.c | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex 74a3c01f99..5ac7d7d68f 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -354,6 +354,7 @@ typedef enum {\n #define MSR_RI 1 /* Recoverable interrupt 1 */\n #define MSR_LE 0 /* Little-endian mode 1 hflags */\n \n+FIELD(MSR, TS, MSR_TS0, 2)\n FIELD(MSR, CM, MSR_CM, 1)\n FIELD(MSR, GS, MSR_GS, 1)\n FIELD(MSR, POW, MSR_POW, 1)\n@@ -494,7 +495,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #define msr_hv (0)\n #endif\n #define msr_de ((env->msr >> MSR_DE) & 1)\n-#define msr_ts ((env->msr >> MSR_TS1) & 3)\n \n #define DBCR0_ICMP (1 << 27)\n #define DBCR0_BRT (1 << 26)\ndiff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\nindex db3a92869c..6eed466f80 100644\n--- a/target/ppc/kvm.c\n+++ b/target/ppc/kvm.c\n@@ -974,7 +974,7 @@ int kvm_arch_put_registers(CPUState *cs, int level)\n }\n \n #ifdef TARGET_PPC64\n- if (msr_ts) {\n+ if (FIELD_EX64(env->msr, MSR, TS)) {\n for (i = 0; i < ARRAY_SIZE(env->tm_gpr); i++) {\n kvm_set_one_reg(cs, KVM_REG_PPC_TM_GPR(i), &env->tm_gpr[i]);\n }\n@@ -1282,7 +1282,7 @@ int kvm_arch_get_registers(CPUState *cs)\n }\n \n #ifdef TARGET_PPC64\n- if (msr_ts) {\n+ if (FIELD_EX64(env->msr, MSR, TS)) {\n for (i = 0; i < ARRAY_SIZE(env->tm_gpr); i++) {\n kvm_get_one_reg(cs, KVM_REG_PPC_TM_GPR(i), &env->tm_gpr[i]);\n }\ndiff --git a/target/ppc/machine.c b/target/ppc/machine.c\nindex e673944597..7104a5c67e 100644\n--- a/target/ppc/machine.c\n+++ b/target/ppc/machine.c\n@@ -417,7 +417,7 @@ static bool tm_needed(void *opaque)\n {\n PowerPCCPU *cpu = opaque;\n CPUPPCState *env = &cpu->env;\n- return msr_ts;\n+ return FIELD_EX64(env->msr, MSR, TS);\n }\n \n static const VMStateDescription vmstate_tm = {\n", "prefixes": [ "PULL", "26/30" ] }