Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627225/?format=api
{ "id": 1627225, "url": "http://patchwork.ozlabs.org/api/patches/1627225/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-26-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-26-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:33", "name": "[PULL,25/30] target/ppc: Remove msr_fe0 and msr_fe1 macros", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "151299915a088c9f7d229fa83600a85c8a744265", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-26-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627225/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=Eflgb+jA;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPbc3jVmz9sG4\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:56:44 +1000 (AEST)", "from localhost ([::1]:46358 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhac-00073J-Bv\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:56:42 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:48250)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZT-0003ux-1U; Thu, 05 May 2022 14:51:27 -0400", "from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:37834)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZR-0004rP-Ax; Thu, 05 May 2022 14:51:26 -0400", "by mail-oi1-x22d.google.com with SMTP id r1so5264945oie.4;\n Thu, 05 May 2022 11:51:24 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.51.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:51:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=IhEq0lsFif+yk5UYMu9bvTazdbGyBbCEFAD4wBgfwZQ=;\n b=Eflgb+jAUeZmP3LeFx8Y8RunbWas4rATh1f03gx1jjFFtSO9s9ziaQyeq8NVV8XZkN\n 0g3305m01JyXKBR/KLj9NUhf7T+804P8heg+BUBmHjCEP0uXxfqUA1d2Cgvem1gXUnV8\n UtcTCYjubuR4Yh31ok6Pyr5V1aiNrANOGfVr2WDni2IcKEohfLyVnk/91zrwnhPuG5Pf\n f54lEe7fAYhDs2b9XXX6xrSSAbjAQDs8mRhckc3lwcZ0m//w6b/Nk3kfDAFKscl+gkye\n j7X5Dn/+sfi8vHKvhAIDM6DovFiDma5Oi3nJjrHzzdAMyNgaHr2p2l9GtVNglRnvJewc\n BYXA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=IhEq0lsFif+yk5UYMu9bvTazdbGyBbCEFAD4wBgfwZQ=;\n b=PycVurj2GBM/+zVcl3ZB+i86YCGwEYDs55L9ryyZhaKmrPZQVR7RRkyPuz8fD4atPs\n LfFxjXTyuvPlXob/knRQtMm7Ufp7NcOZRX6SNzLa6IU9fDxJHK/CaYw5LwsC0SLdcRfG\n RQTp5HL/Yu8qsvcpo1a/V0CJS08XDuukDlbPmJN0R7BiP3xjcWBNhRKCJsZQtwNubqqx\n IhBrPthLX/vT7EoJHNje76JUJfdhcglUX/jdGd4TZTvcup9XuLdZhFwD5hpm7HVg35LW\n i9s21FR2nDY10JgbdLjCkbc5OfIIRD98HhPti5eb3+/rTyRCvs2vduzxOshu6RTN8chI\n ps1A==", "X-Gm-Message-State": "AOAM532Sih4tAS+0yE0rtQUT5/Rc3dANURxCKk4mYKxoedXk51UQVyzv\n lXCfpVjSap8CCFpQ0lhzl6CgrecvuzU=", "X-Google-Smtp-Source": "\n ABdhPJwf8W7JajKhxRtzq6nL6AEdt6tp7Ct89SjtI1jNcfEN6A9Y8mX2bIKaO5CGycgwm+g2RI2FnA==", "X-Received": "by 2002:a05:6808:1825:b0:326:3e14:f156 with SMTP id\n bh37-20020a056808182500b003263e14f156mr3300946oib.144.1651776683913;\n Thu, 05 May 2022 11:51:23 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 25/30] target/ppc: Remove msr_fe0 and msr_fe1 macros", "Date": "Thu, 5 May 2022 15:49:33 -0300", "Message-Id": "<20220505184938.351866-26-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::22d;\n envelope-from=danielhb413@gmail.com; helo=mail-oi1-x22d.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_fe0 and msr_fe1 macros hide the usage of env->msr, which is a bad\nbehavior. Substitute it with FIELD_EX64 calls that explicitly use\nenv->msr as a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-18-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 11 +++++++++--\n target/ppc/excp_helper.c | 18 ++++++------------\n 2 files changed, 15 insertions(+), 14 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex 5e804f0373..74a3c01f99 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -363,12 +363,21 @@ FIELD(MSR, EE, MSR_EE, 1)\n FIELD(MSR, PR, MSR_PR, 1)\n FIELD(MSR, FP, MSR_FP, 1)\n FIELD(MSR, ME, MSR_ME, 1)\n+FIELD(MSR, FE0, MSR_FE0, 1)\n+FIELD(MSR, FE1, MSR_FE1, 1)\n FIELD(MSR, EP, MSR_EP, 1)\n FIELD(MSR, IR, MSR_IR, 1)\n FIELD(MSR, DR, MSR_DR, 1)\n FIELD(MSR, DS, MSR_DS, 1)\n FIELD(MSR, LE, MSR_LE, 1)\n \n+/*\n+ * FE0 and FE1 bits are not side-by-side\n+ * so we can't combine them using FIELD()\n+ */\n+#define FIELD_EX64_FE(msr) \\\n+ ((FIELD_EX64(msr, MSR, FE0) << 1) | FIELD_EX64(msr, MSR, FE1))\n+\n /* PMU bits */\n #define MMCR0_FC PPC_BIT(32) /* Freeze Counters */\n #define MMCR0_PMAO PPC_BIT(56) /* Perf Monitor Alert Ocurred */\n@@ -484,9 +493,7 @@ FIELD(MSR, LE, MSR_LE, 1)\n #else\n #define msr_hv (0)\n #endif\n-#define msr_fe0 ((env->msr >> MSR_FE0) & 1)\n #define msr_de ((env->msr >> MSR_DE) & 1)\n-#define msr_fe1 ((env->msr >> MSR_FE1) & 1)\n #define msr_ts ((env->msr >> MSR_TS1) & 3)\n \n #define DBCR0_ICMP (1 << 27)\ndiff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c\nindex 30baad0489..aa201c63c6 100644\n--- a/target/ppc/excp_helper.c\n+++ b/target/ppc/excp_helper.c\n@@ -478,8 +478,7 @@ static void powerpc_excp_40x(PowerPCCPU *cpu, int excp)\n case POWERPC_EXCP_PROGRAM: /* Program exception */\n switch (env->error_code & ~0xF) {\n case POWERPC_EXCP_FP:\n- if ((msr_fe0 == 0 && msr_fe1 == 0) ||\n- !FIELD_EX64(env->msr, MSR, FP)) {\n+ if (!FIELD_EX64_FE(env->msr) || !FIELD_EX64(env->msr, MSR, FP)) {\n trace_ppc_excp_fp_ignore();\n powerpc_reset_excp_state(cpu);\n return;\n@@ -616,8 +615,7 @@ static void powerpc_excp_6xx(PowerPCCPU *cpu, int excp)\n case POWERPC_EXCP_PROGRAM: /* Program exception */\n switch (env->error_code & ~0xF) {\n case POWERPC_EXCP_FP:\n- if ((msr_fe0 == 0 && msr_fe1 == 0) ||\n- !FIELD_EX64(env->msr, MSR, FP)) {\n+ if (!FIELD_EX64_FE(env->msr) || !FIELD_EX64(env->msr, MSR, FP)) {\n trace_ppc_excp_fp_ignore();\n powerpc_reset_excp_state(cpu);\n return;\n@@ -790,8 +788,7 @@ static void powerpc_excp_7xx(PowerPCCPU *cpu, int excp)\n case POWERPC_EXCP_PROGRAM: /* Program exception */\n switch (env->error_code & ~0xF) {\n case POWERPC_EXCP_FP:\n- if ((msr_fe0 == 0 && msr_fe1 == 0) ||\n- !FIELD_EX64(env->msr, MSR, FP)) {\n+ if (!FIELD_EX64_FE(env->msr) || !FIELD_EX64(env->msr, MSR, FP)) {\n trace_ppc_excp_fp_ignore();\n powerpc_reset_excp_state(cpu);\n return;\n@@ -976,8 +973,7 @@ static void powerpc_excp_74xx(PowerPCCPU *cpu, int excp)\n case POWERPC_EXCP_PROGRAM: /* Program exception */\n switch (env->error_code & ~0xF) {\n case POWERPC_EXCP_FP:\n- if ((msr_fe0 == 0 && msr_fe1 == 0) ||\n- !FIELD_EX64(env->msr, MSR, FP)) {\n+ if (!FIELD_EX64_FE(env->msr) || !FIELD_EX64(env->msr, MSR, FP)) {\n trace_ppc_excp_fp_ignore();\n powerpc_reset_excp_state(cpu);\n return;\n@@ -1175,8 +1171,7 @@ static void powerpc_excp_booke(PowerPCCPU *cpu, int excp)\n case POWERPC_EXCP_PROGRAM: /* Program exception */\n switch (env->error_code & ~0xF) {\n case POWERPC_EXCP_FP:\n- if ((msr_fe0 == 0 && msr_fe1 == 0) ||\n- !FIELD_EX64(env->msr, MSR, FP)) {\n+ if (!FIELD_EX64_FE(env->msr) || !FIELD_EX64(env->msr, MSR, FP)) {\n trace_ppc_excp_fp_ignore();\n powerpc_reset_excp_state(cpu);\n return;\n@@ -1439,8 +1434,7 @@ static void powerpc_excp_books(PowerPCCPU *cpu, int excp)\n case POWERPC_EXCP_PROGRAM: /* Program exception */\n switch (env->error_code & ~0xF) {\n case POWERPC_EXCP_FP:\n- if ((msr_fe0 == 0 && msr_fe1 == 0) ||\n- !FIELD_EX64(env->msr, MSR, FP)) {\n+ if (!FIELD_EX64_FE(env->msr) || !FIELD_EX64(env->msr, MSR, FP)) {\n trace_ppc_excp_fp_ignore();\n powerpc_reset_excp_state(cpu);\n return;\n", "prefixes": [ "PULL", "25/30" ] }