Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627224/?format=api
{ "id": 1627224, "url": "http://patchwork.ozlabs.org/api/patches/1627224/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-29-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-29-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:36", "name": "[PULL,28/30] target/ppc: Remove msr_de macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2c516ff240981b12e592ba5e6cacad5473ab6c98", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-29-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627224/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=eeCJxwdF;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPYn1ynPz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:55:09 +1000 (AEST)", "from localhost ([::1]:43750 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhZ5-0005D9-4D\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:55:07 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:48376)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZd-0003xa-D0; Thu, 05 May 2022 14:51:40 -0400", "from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:45992)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZb-0004tg-PY; Thu, 05 May 2022 14:51:37 -0400", "by mail-oi1-x234.google.com with SMTP id n24so5241483oie.12;\n Thu, 05 May 2022 11:51:34 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.51.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:51:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=HodvTr3B4YWOvMygizk75ypRfURZqF5htRLu+QyFfAw=;\n b=eeCJxwdFflV7c0TwG7s+AnnHS1Hwy/+9HdbWsqU4OXDbVv+Eelj/36N0H0LtyuI0sI\n z/YFjTSO+wSzTmhpube1DvXx+vui/Jg/VpajMQYr61KWtCTneo2vlqaHXR3YjGktq+I7\n cZ7paPkc3c0KCWuXkrVFirSITjn66O8eFiBPwPsowU5JO8NhfKlfbETCmP3stYHLeDqS\n 7/wK/5YHHmFIlYymR8PfQDQD2NDbBmi/50lXqqtKi3k9eMPCjaZ8CkWonrqa6vfiSLrG\n akrKSCGCfhmUs4h7amMvjFiV8x0J7YJ7BAo2Gz72/INmhWkkTJsj6dW/Jtb7fYZtSH41\n Ijrw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=HodvTr3B4YWOvMygizk75ypRfURZqF5htRLu+QyFfAw=;\n b=OPpM6wEAOsje6IZF1Ddt41qPx995GxsmEn8be8KkRL4BjmpQmjNOuFaqboTVx5Xqrk\n EiFPyqZXDh6V5QaEyYtxkhpDd5vWgciEpjxr63vYUzTUyNUjWmWm296C3MqAbNW7uCq2\n OcONP4F109O1atDo8tszyOtCKqMXqqVCtJ6TJeiR1AJAJxHID26hvyGvRqUK8DAdDL8G\n ZROBNQNrXg4OZeODo4fTdK1AU7ees/Cy0GswSI+Gvsagvy5bxb98ptoOb/aHggarMKdv\n /lA5866PXGlHzjkpYxzdx6djsoXOZq5nQhckagl2jzmhmXiXGhrePuNkBsasWeo+eLRQ\n 40AQ==", "X-Gm-Message-State": "AOAM533PuMLymuQWsd7+PMesp7HgJXJKjK0eupvApk/mC6NUH/W+jP4Q\n 0IrgygjeYU35tOdyaW4dGIZ0TQ540q8=", "X-Google-Smtp-Source": "\n ABdhPJwRe1Y4JIzkMNJ0q1jAlq/OBtlSUOyKd0tN1//ANzmD0FMUcdvjK8MgWLEFDB68XQ23XpfRnQ==", "X-Received": "by 2002:a05:6808:120f:b0:325:bc53:2150 with SMTP id\n a15-20020a056808120f00b00325bc532150mr3266103oil.139.1651776693488;\n Thu, 05 May 2022 11:51:33 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 28/30] target/ppc: Remove msr_de macro", "Date": "Thu, 5 May 2022 15:49:36 -0300", "Message-Id": "<20220505184938.351866-29-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::234;\n envelope-from=danielhb413@gmail.com; helo=mail-oi1-x234.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_de macro hides the usage of env->msr, which is a bad\nbehavior. Substitute it with FIELD_EX64 calls that explicitly use\nenv->msr as a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-21-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 3 +--\n target/ppc/helper_regs.c | 4 ++--\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex 9f19b3c0a8..af249239d5 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -371,6 +371,7 @@ FIELD(MSR, PR, MSR_PR, 1)\n FIELD(MSR, FP, MSR_FP, 1)\n FIELD(MSR, ME, MSR_ME, 1)\n FIELD(MSR, FE0, MSR_FE0, 1)\n+FIELD(MSR, DE, MSR_DE, 1)\n FIELD(MSR, FE1, MSR_FE1, 1)\n FIELD(MSR, EP, MSR_EP, 1)\n FIELD(MSR, IR, MSR_IR, 1)\n@@ -495,8 +496,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #define HFSCR_MSGP PPC_BIT(53) /* Privileged Message Send Facilities */\n #define HFSCR_IC_MSGP 0xA\n \n-#define msr_de ((env->msr >> MSR_DE) & 1)\n-\n #define DBCR0_ICMP (1 << 27)\n #define DBCR0_BRT (1 << 26)\n #define DBSR_ICMP (1 << 27)\ndiff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c\nindex 97cd263131..6159a15b7b 100644\n--- a/target/ppc/helper_regs.c\n+++ b/target/ppc/helper_regs.c\n@@ -63,10 +63,10 @@ static uint32_t hreg_compute_hflags_value(CPUPPCState *env)\n \n if (ppc_flags & POWERPC_FLAG_DE) {\n target_ulong dbcr0 = env->spr[SPR_BOOKE_DBCR0];\n- if ((dbcr0 & DBCR0_ICMP) && msr_de) {\n+ if ((dbcr0 & DBCR0_ICMP) && FIELD_EX64(env->msr, MSR, DE)) {\n hflags |= 1 << HFLAGS_SE;\n }\n- if ((dbcr0 & DBCR0_BRT) && msr_de) {\n+ if ((dbcr0 & DBCR0_BRT) && FIELD_EX64(env->msr, MSR, DE)) {\n hflags |= 1 << HFLAGS_BE;\n }\n } else {\n", "prefixes": [ "PULL", "28/30" ] }