Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627223/?format=api
{ "id": 1627223, "url": "http://patchwork.ozlabs.org/api/patches/1627223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-17-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-17-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:24", "name": "[PULL,16/30] target/ppc: Remove msr_ce macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "da62175cdbdd3a3f0caa972a2167a3a752d9d7ee", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-17-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627223/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=mcp7FNSO;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPYl4l2Pz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:55:07 +1000 (AEST)", "from localhost ([::1]:43520 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhZ3-00051W-8W\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:55:05 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:47874)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZ0-0003Na-BF; Thu, 05 May 2022 14:50:58 -0400", "from mail-oa1-x34.google.com ([2001:4860:4864:20::34]:41496)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYy-0004PM-RT; Thu, 05 May 2022 14:50:58 -0400", "by mail-oa1-x34.google.com with SMTP id\n 586e51a60fabf-edf9ddb312so4160044fac.8;\n Thu, 05 May 2022 11:50:56 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.50.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:50:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=z+R3INB0Bexk+VUNnDpDQqvZUPfqPS6rXAwPFi+ssvw=;\n b=mcp7FNSO9da/4CkcqxZWFTcKYgpAVPyGXhke1xB2u8pc7pBVX7VmkLz1qQNU0ohC5v\n YURGfI1EJmthFzDQuzQgYagm2HY1H72K0pHDnnbZqAMAUeTMuLprWR3mVD1MfkbkEoP6\n g5bJMKucUlu/J46g83Ji7HbAnGG6UB0V9NmfSaQ2ncwjB9r8/9Ih2AOynbZhMcrMdmDc\n ivbsjXHy2EqMxaWsCmkmN1tPpWdgwmjxC9BOmAUtKupppG7ztzRGBC3M7ytKaBARQeME\n 9MGFgbL8/GZF7qKk4gVw/u1d3ZFubV3+mMK04V1xc2LFL++oIgDE5m0lLarLzsPKLazN\n /dkA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=z+R3INB0Bexk+VUNnDpDQqvZUPfqPS6rXAwPFi+ssvw=;\n b=7QbcKbwNP2nCh0PBO5b9Ja0olbHyQEYYGdeQ2Fu/YCZLdtwS7SCEZyI7oPdXAQav86\n jNYFuzb8+TEdDcmZkGtDG5I9eNA33IYCiq0j4cchNqW6fB6iJCVL1z8djbGsmb6O9+wT\n 2CFKRCfA+L1rilaQWaUCVUGRvFxcOhlkLP9OGoEuzWCsFMxL1QkBUJqdkx7lGWx2zhOJ\n 4SxVgFxNgLH7WsG6jyL4HIw7YrTJccC/UlHhOagiEaHNENXnNeQ7i8zmPTW9zttTciRz\n gMpoeZvu6dQ8QL56hqCm9lUkjtUi16EuaIATbbOaSVLsNxjVwnolmtZ8jY6eQkn0rzVr\n gdkQ==", "X-Gm-Message-State": "AOAM530kswNAeLPKmzUZiMQD4YXDu7bAV/9t2+MNo45fTBztt3jtWl/a\n hzjDUIbqp8RbRjtKr++WaQN9zdOPLIQ=", "X-Google-Smtp-Source": "\n ABdhPJy2VqQky4KRn3EG6hg9853AXSbY7BcJW2IPAPWuyXUYBJlW0gZzcksfU0Yf6eepIjzJygBu5g==", "X-Received": "by 2002:a05:6870:1788:b0:e6:225:9841 with SMTP id\n r8-20020a056870178800b000e602259841mr2919242oae.152.1651776655670;\n Thu, 05 May 2022 11:50:55 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 16/30] target/ppc: Remove msr_ce macro", "Date": "Thu, 5 May 2022 15:49:24 -0300", "Message-Id": "<20220505184938.351866-17-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2001:4860:4864:20::34;\n envelope-from=danielhb413@gmail.com; helo=mail-oa1-x34.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_ce macro hides the usage of env->msr, which is a bad behavior\nSubstitute it with FIELD_EX64 calls that explicitly use env->msr\nas a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-9-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 2 +-\n target/ppc/excp_helper.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex 06667c2c60..b1883b23e2 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -354,6 +354,7 @@ typedef enum {\n #define MSR_RI 1 /* Recoverable interrupt 1 */\n #define MSR_LE 0 /* Little-endian mode 1 hflags */\n \n+FIELD(MSR, CE, MSR_CE, 1)\n FIELD(MSR, ILE, MSR_ILE, 1)\n FIELD(MSR, EE, MSR_EE, 1)\n FIELD(MSR, PR, MSR_PR, 1)\n@@ -478,7 +479,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #define msr_cm ((env->msr >> MSR_CM) & 1)\n #define msr_gs ((env->msr >> MSR_GS) & 1)\n #define msr_pow ((env->msr >> MSR_POW) & 1)\n-#define msr_ce ((env->msr >> MSR_CE) & 1)\n #define msr_fp ((env->msr >> MSR_FP) & 1)\n #define msr_me ((env->msr >> MSR_ME) & 1)\n #define msr_fe0 ((env->msr >> MSR_FE0) & 1)\ndiff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c\nindex 4c206ba209..ca80c1ed63 100644\n--- a/target/ppc/excp_helper.c\n+++ b/target/ppc/excp_helper.c\n@@ -1749,7 +1749,7 @@ static void ppc_hw_interrupt(CPUPPCState *env)\n return;\n }\n }\n- if (msr_ce != 0) {\n+ if (FIELD_EX64(env->msr, MSR, CE)) {\n /* External critical interrupt */\n if (env->pending_interrupts & (1 << PPC_INTERRUPT_CEXT)) {\n powerpc_excp(cpu, POWERPC_EXCP_CRITICAL);\n", "prefixes": [ "PULL", "16/30" ] }