Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627221/?format=api
{ "id": 1627221, "url": "http://patchwork.ozlabs.org/api/patches/1627221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-20-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-20-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:27", "name": "[PULL,19/30] target/ppc: Remove msr_gs macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1d9f0adb7d45abd0feea927d8a07a21a7af19a02", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-20-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627221/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=LRE9sFqL;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPYW0zXwz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:54:55 +1000 (AEST)", "from localhost ([::1]:42616 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhYq-0004My-Vu\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:54:53 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:47956)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZB-0003Sj-2H; Thu, 05 May 2022 14:51:10 -0400", "from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:46072)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZ8-0004b2-3Q; Thu, 05 May 2022 14:51:07 -0400", "by mail-ot1-x32c.google.com with SMTP id\n s18-20020a056830149200b006063fef3e17so3501558otq.12;\n Thu, 05 May 2022 11:51:05 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.51.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:51:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=iREEK7YQCVNl6aqmIZD6DiVspuMek65x7eD0wvb4T9M=;\n b=LRE9sFqLnNVdp96wrWyPd/mk58N2drK6Eht6MhUnFc5hFvfattVg0ZhzHnVTG/D7Gn\n JA2j4jih40FX6VxrLEi5PCxMwuz1gtU7Bin5XXGSnha6uyq5s0iLph028exALPEFUuLw\n JuntCu7YW3gwEbwu8SLKn2YJesQw/5SfS9SSxwIR7ClRv4xnisHpEbkDrO0xMTV7YjS5\n 3nA6/4zhH7CO0TtyO3mkLISNXpF2XK1O0E4EUh8zewN5dsshEIogDEun2CXuH6E+mO7r\n aTBFQOu3Y5klnLLxVuKVP/FQk6b1kNjpbGGcd+yy2iVm8ZL4DlMWD20vAhg9nT4gkuvU\n +OLw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=iREEK7YQCVNl6aqmIZD6DiVspuMek65x7eD0wvb4T9M=;\n b=GdJ8etTKpXf7bJCXPDFVGXWiLt9/ZHIwLq6GMWaKVguzVTGCBkznNaDx08uVwFDH3X\n tq1kDprURnzBuhJvVO/lD/bXNtH+x4dFYtQsStTjv28UGkWUTqfK7WSSuuj7cRCRujvz\n TPQ5pDD37I858uPl5WNIp2Fhq2IsrcwO068qaRpF0YdDIn/+8gW2JvOw9dVFyF6tENuO\n GbOIid5qmlkSZyoJnwNjXi5U/0Z58N6xvgIPu7rNh4a8YT7SF1BfAmsj5EFyy9zvw/el\n cHrkYBV/gSt6NvMd0Cr8o9G37PPztAOiEvjqBzvt+FK79KFJXJfdyWZGzYZlM2lqC9LK\n wkzw==", "X-Gm-Message-State": "AOAM533D24BsF6l4OEHTXequaoXJyuR5XJaH0nG7EirLxr5yBacyzdkS\n MRlNWjCWmTYmncmm6X4X1HKGHSazjCA=", "X-Google-Smtp-Source": "\n ABdhPJyS4foRERjMlFP587Vi0fjMET3Y3hvaTgmc6J3PKoFkqYC1Qo2Era9YQeVjwc426U33iG6TKA==", "X-Received": "by 2002:a9d:5e91:0:b0:605:df49:462 with SMTP id\n f17-20020a9d5e91000000b00605df490462mr10180618otl.228.1651776664952;\n Thu, 05 May 2022 11:51:04 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 19/30] target/ppc: Remove msr_gs macro", "Date": "Thu, 5 May 2022 15:49:27 -0300", "Message-Id": "<20220505184938.351866-20-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::32c;\n envelope-from=danielhb413@gmail.com; helo=mail-ot1-x32c.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_gs macro hides the usage of env->msr, which is a bad behavior\nSubstitute it with FIELD_EX64 calls that explicitly use env->msr\nas a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-12-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 2 +-\n target/ppc/helper_regs.c | 2 +-\n target/ppc/mmu_helper.c | 4 ++--\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex deb861f5f3..bd5dffc9b1 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -354,6 +354,7 @@ typedef enum {\n #define MSR_RI 1 /* Recoverable interrupt 1 */\n #define MSR_LE 0 /* Little-endian mode 1 hflags */\n \n+FIELD(MSR, GS, MSR_GS, 1)\n FIELD(MSR, POW, MSR_POW, 1)\n FIELD(MSR, CE, MSR_CE, 1)\n FIELD(MSR, ILE, MSR_ILE, 1)\n@@ -479,7 +480,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #define msr_hv (0)\n #endif\n #define msr_cm ((env->msr >> MSR_CM) & 1)\n-#define msr_gs ((env->msr >> MSR_GS) & 1)\n #define msr_fp ((env->msr >> MSR_FP) & 1)\n #define msr_fe0 ((env->msr >> MSR_FE0) & 1)\n #define msr_de ((env->msr >> MSR_DE) & 1)\ndiff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c\nindex 79c0143a7a..4e649d8b0e 100644\n--- a/target/ppc/helper_regs.c\n+++ b/target/ppc/helper_regs.c\n@@ -233,7 +233,7 @@ int hreg_store_msr(CPUPPCState *env, target_ulong value, int alter_hv)\n }\n if ((env->mmu_model == POWERPC_MMU_BOOKE ||\n env->mmu_model == POWERPC_MMU_BOOKE206) &&\n- ((value >> MSR_GS) & 1) != msr_gs) {\n+ ((value ^ env->msr) & R_MSR_GS_MASK)) {\n cpu_interrupt_exittb(cs);\n }\n if (unlikely((env->flags & POWERPC_FLAG_TGPR) &&\ndiff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c\nindex 142a717255..5bb5c71038 100644\n--- a/target/ppc/mmu_helper.c\n+++ b/target/ppc/mmu_helper.c\n@@ -935,7 +935,7 @@ void helper_booke206_tlbwe(CPUPPCState *env)\n }\n \n if (((env->spr[SPR_BOOKE_MAS0] & MAS0_ATSEL) == MAS0_ATSEL_LRAT) &&\n- !msr_gs) {\n+ !FIELD_EX64(env->msr, MSR, GS)) {\n /* XXX we don't support direct LRAT setting yet */\n fprintf(stderr, \"cpu: don't support LRAT setting yet\\n\");\n return;\n@@ -962,7 +962,7 @@ void helper_booke206_tlbwe(CPUPPCState *env)\n POWERPC_EXCP_INVAL_INVAL, GETPC());\n }\n \n- if (msr_gs) {\n+ if (FIELD_EX64(env->msr, MSR, GS)) {\n cpu_abort(env_cpu(env), \"missing HV implementation\\n\");\n }\n \n", "prefixes": [ "PULL", "19/30" ] }