Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627217/?format=api
{ "id": 1627217, "url": "http://patchwork.ozlabs.org/api/patches/1627217/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-22-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-22-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:29", "name": "[PULL,21/30] target/ppc: Remove msr_cm macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9d5493974e118273e64ea245dbf28d28f77effc3", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-22-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627217/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=Yg9UDIQ4;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPWW2swfz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:53:10 +1000 (AEST)", "from localhost ([::1]:37358 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhX8-0000hI-NW\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:53:06 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:48132)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZG-0003Yf-Ur; Thu, 05 May 2022 14:51:14 -0400", "from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:39568)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZF-0004oH-Bv; Thu, 05 May 2022 14:51:14 -0400", "by mail-ot1-x336.google.com with SMTP id\n z15-20020a9d65cf000000b00605f064482cso3519111oth.6;\n Thu, 05 May 2022 11:51:12 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.51.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:51:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=muPBgEzm7e+VquRbAm5msMUbmbtWtrchg3IRMQerwGM=;\n b=Yg9UDIQ4LfpZl0oL3M5VjE1WP7gmpNuLH0yE6FKTdnmZpP9k+G5fQtsF/Y4IteWYXM\n /D9DZsnv0wKO8KW1XzKDojL3zj1ayzh6KgkACdjUjB6DfTv9mDHwcInodWl2e9XAMfbT\n Gzri6XalEfrQ8iNRN/n98+bLK6yGQKbJCjTR3fLo6ZHqOABEFzrdlO4Fv9v/vy3E8iDl\n 1JcAM39oI1aLy4WF5DaaXptz2WUSO2UT1cfoNoE5+8i6IlJNegjLeQfiVn/CWieM4Vjv\n kLabJJPjCC+SLpvgY+h5b9Rno7NryaSNlNcZ1g8JAjlW86LMM+/XYfHxVNma/ccFyXx4\n BNTw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=muPBgEzm7e+VquRbAm5msMUbmbtWtrchg3IRMQerwGM=;\n b=OOJQQhy/Qld14Z8TziHR39XGUu8Ih22h41CVkzO7WkfmhdNz7wQm1Hjuffs68TP8Rs\n 2wl8DeBYf7kZrC5BDVAWftGo9oIu15+giCPLCVUPmJRh7zcRGdlZR9q8XVwRL088MusB\n FoXyOotTnpo/ncW0Lz5xg/CLEBRPbYzGvq0kHi/N7hM965yzzUZjaD89f7hkoHaMWq3n\n kt8HoEczmv7xV9dUumXv2X09d4f/nb+B4zcdGP4bQY4n8kUOlbYATYHjNMkdPfkHp5Lu\n kgNkwT31b/vv5L4TW1E3BsepBRviJZIBmv5bGW1NLqZ1Dz+qWG521GTL+olRK6nzr00n\n A8iA==", "X-Gm-Message-State": "AOAM533feG0/6kTXgNMhqIfFQ+lBb9bUH0UaId+Hduc8B/E0c1lKZIZc\n xMw8r4RNacljNfzOfM6wvGQL8SKE6d0=", "X-Google-Smtp-Source": "\n ABdhPJw7WzU5tfHEC7ZZbilspfIdJ88u6zi96WV8hvof+xGHqzeocs5nuzG0So/S83CM0Cit9k/lVA==", "X-Received": "by 2002:a05:6830:90b:b0:606:3c4b:8efe with SMTP id\n v11-20020a056830090b00b006063c4b8efemr4453443ott.103.1651776671169;\n Thu, 05 May 2022 11:51:11 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 21/30] target/ppc: Remove msr_cm macro", "Date": "Thu, 5 May 2022 15:49:29 -0300", "Message-Id": "<20220505184938.351866-22-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::336;\n envelope-from=danielhb413@gmail.com; helo=mail-ot1-x336.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_cm macro hides the usage of env->msr, which is a bad behavior\nSubstitute it with FIELD_EX64 calls that explicitly use env->msr\nas a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-14-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 2 +-\n target/ppc/mmu_common.c | 2 +-\n target/ppc/mmu_helper.c | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex 17b7f5f6d9..75a81d4304 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -354,6 +354,7 @@ typedef enum {\n #define MSR_RI 1 /* Recoverable interrupt 1 */\n #define MSR_LE 0 /* Little-endian mode 1 hflags */\n \n+FIELD(MSR, CM, MSR_CM, 1)\n FIELD(MSR, GS, MSR_GS, 1)\n FIELD(MSR, POW, MSR_POW, 1)\n FIELD(MSR, CE, MSR_CE, 1)\n@@ -480,7 +481,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #else\n #define msr_hv (0)\n #endif\n-#define msr_cm ((env->msr >> MSR_CM) & 1)\n #define msr_fe0 ((env->msr >> MSR_FE0) & 1)\n #define msr_de ((env->msr >> MSR_DE) & 1)\n #define msr_fe1 ((env->msr >> MSR_FE1) & 1)\ndiff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c\nindex 7e77b9b84a..031bb4493b 100644\n--- a/target/ppc/mmu_common.c\n+++ b/target/ppc/mmu_common.c\n@@ -692,7 +692,7 @@ int ppcmas_tlb_check(CPUPPCState *env, ppcmas_tlb_t *tlb,\n hwaddr mask;\n uint32_t tlb_pid;\n \n- if (!msr_cm) {\n+ if (!FIELD_EX64(env->msr, MSR, CM)) {\n /* In 32bit mode we can only address 32bit EAs */\n address = (uint32_t)address;\n }\ndiff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c\nindex 5bb5c71038..15239dc95b 100644\n--- a/target/ppc/mmu_helper.c\n+++ b/target/ppc/mmu_helper.c\n@@ -1003,7 +1003,7 @@ void helper_booke206_tlbwe(CPUPPCState *env)\n /* Add a mask for page attributes */\n mask |= MAS2_ACM | MAS2_VLE | MAS2_W | MAS2_I | MAS2_M | MAS2_G | MAS2_E;\n \n- if (!msr_cm) {\n+ if (!FIELD_EX64(env->msr, MSR, CM)) {\n /*\n * Executing a tlbwe instruction in 32-bit mode will set bits\n * 0:31 of the TLB EPN field to zero.\n", "prefixes": [ "PULL", "21/30" ] }