Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627216/?format=api
{ "id": 1627216, "url": "http://patchwork.ozlabs.org/api/patches/1627216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-25-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-25-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:32", "name": "[PULL,24/30] target/ppc: Remove msr_ep macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fdb670d9da19ac1014e1d42559d753225285acd0", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-25-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627216/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=SLjoowvC;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvPVH0Vh6z9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:52:07 +1000 (AEST)", "from localhost ([::1]:34652 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhW8-0007FC-Ru\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:52:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:48218)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZP-0003r2-M5; Thu, 05 May 2022 14:51:23 -0400", "from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:38709)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgZO-0004q7-4f; Thu, 05 May 2022 14:51:23 -0400", "by mail-ot1-x32b.google.com with SMTP id\n 88-20020a9d0ee1000000b005d0ae4e126fso3518570otj.5;\n Thu, 05 May 2022 11:51:21 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.51.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:51:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OgoxkURypwIbLDY3Z92W4Ub2bDcBdBdi030FbyLdqy0=;\n b=SLjoowvCQK6I00DNrQeMVycZGBtI1XckgfNnpLVUMUQJ+blbLOvcEUnQWIa5KRUEBA\n k5qaQDvXzFN89GmKRDS1lePw5LGA3QEgtwaBBrrHneazxNyfsT70KE8tZ4GOXX4Ycdv3\n je2OZQ3+uHnQRnUP98B78QfQg7yidA7S95sl3F/1IkbVH0aFhZujlU/Q1qJjTWK6V7lM\n tlRJukOXi6GwGOLhf0pAZ7vHUDQvWbcjMzWIS8NNlDj8J/D8vCgHSAjOHq4LdtfyrtVq\n hbP7K8d++WdIV4Dew7yT/JVIi28wuk6wZmQ4LgLHcKFTzC/ZkJLIJf8J8bdQHl2VNJYs\n iusg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OgoxkURypwIbLDY3Z92W4Ub2bDcBdBdi030FbyLdqy0=;\n b=PdAj+W+FUeNe/FSNap2iCekfbm1W/r9GYbPNln1LCmg3imYPj1y39jfZwvo9kTNTl+\n 2RewSS/tTWc4jM6mjKQHEEFhX5cNmZzl/yc6lfhqxFG05/gyaM8mu7ypn3OI/gzlpCAF\n YH8M7p+XgBZTsY+pM6ZdQ1kczntsiDL2cWx9F8CuXChthsvILpyAKvQoE8T2vIENLM9a\n T+MUGLIT/5sQ2+6oIorkQIL0Pt2JrDCw/el2pIlPTomS2Fb/kXoh+C2VirzCWI0RJOSn\n bYVJ4USlxaDctWjkdtwKPB3YMCjk22twW/zDnTKjiOuGUXYgYlIWDLxeLuNauJJgBVpI\n rWrA==", "X-Gm-Message-State": "AOAM530Z6cqkTxc/00ecNwHfvCZ1vYZjUpsdNfOj58KVIfG3LBH9JGZk\n mNWjDQ5WyT7yz7xmxKwyl3AyMgQGiwU=", "X-Google-Smtp-Source": "\n ABdhPJz3AqVZYSVB4TspzCL3goVvodPDVmSLhJFw4xZKQ2VUMQ3a+ob3CqGId4WPBTdMfx3SRh1i/w==", "X-Received": "by 2002:a9d:f25:0:b0:606:1c42:6b49 with SMTP id\n 34-20020a9d0f25000000b006061c426b49mr7297249ott.368.1651776680705;\n Thu, 05 May 2022 11:51:20 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 24/30] target/ppc: Remove msr_ep macro", "Date": "Thu, 5 May 2022 15:49:32 -0300", "Message-Id": "<20220505184938.351866-25-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::32b;\n envelope-from=danielhb413@gmail.com; helo=mail-ot1-x32b.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_ep macro hides the usage of env->msr, which is a bad behavior\nSubstitute it with FIELD_EX64 calls that explicitly use env->msr\nas a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-17-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 2 +-\n target/ppc/helper_regs.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex cd672dec93..5e804f0373 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -363,6 +363,7 @@ FIELD(MSR, EE, MSR_EE, 1)\n FIELD(MSR, PR, MSR_PR, 1)\n FIELD(MSR, FP, MSR_FP, 1)\n FIELD(MSR, ME, MSR_ME, 1)\n+FIELD(MSR, EP, MSR_EP, 1)\n FIELD(MSR, IR, MSR_IR, 1)\n FIELD(MSR, DR, MSR_DR, 1)\n FIELD(MSR, DS, MSR_DS, 1)\n@@ -486,7 +487,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #define msr_fe0 ((env->msr >> MSR_FE0) & 1)\n #define msr_de ((env->msr >> MSR_DE) & 1)\n #define msr_fe1 ((env->msr >> MSR_FE1) & 1)\n-#define msr_ep ((env->msr >> MSR_EP) & 1)\n #define msr_ts ((env->msr >> MSR_TS1) & 3)\n \n #define DBCR0_ICMP (1 << 27)\ndiff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c\nindex b150b78182..97cd263131 100644\n--- a/target/ppc/helper_regs.c\n+++ b/target/ppc/helper_regs.c\n@@ -240,8 +240,8 @@ int hreg_store_msr(CPUPPCState *env, target_ulong value, int alter_hv)\n /* Swap temporary saved registers with GPRs */\n hreg_swap_gpr_tgpr(env);\n }\n- if (unlikely((value >> MSR_EP) & 1) != msr_ep) {\n- env->excp_prefix = ((value >> MSR_EP) & 1) * 0xFFF00000;\n+ if (unlikely((value ^ env->msr) & R_MSR_EP_MASK)) {\n+ env->excp_prefix = FIELD_EX64(value, MSR, EP) * 0xFFF00000;\n }\n /*\n * If PR=1 then EE, IR and DR must be 1\n", "prefixes": [ "PULL", "24/30" ] }