Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627186/?format=api
{ "id": 1627186, "url": "http://patchwork.ozlabs.org/api/patches/1627186/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-14-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-14-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:21", "name": "[PULL,13/30] target/ppc: Remove msr_ds macro", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b2c72e8136ae3a5dbb01d0c469d50484d5d164ec", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-14-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627186/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=BAhCtRjR;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvP9x1zPvz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:37:57 +1000 (AEST)", "from localhost ([::1]:57734 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmhIR-0000XX-3L\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:37:55 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:47814)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYr-0003Jm-Mx; Thu, 05 May 2022 14:50:52 -0400", "from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]:33573)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYq-0004KL-5n; Thu, 05 May 2022 14:50:49 -0400", "by mail-oi1-x22f.google.com with SMTP id l203so5284655oif.0;\n Thu, 05 May 2022 11:50:47 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.50.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:50:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=MhbrV+sPh98Wjah4fShxYwAeYTq1APxwR/puaCj88KY=;\n b=BAhCtRjRzSw1BnkzRuc5IpEIIcHtc4JZuY7cPi861owdt3C/pyZx5555o+ebXpiEsZ\n DkYxJCYKAMsV65j7aSVaaGUxtM69h09RZmw9dLY0sdm+Db47I0YCYRr0JUCF5oDf5Dyp\n e2yVbcW9o8j+qC2uCL8TdynQw0ci7Bkhx9gG72pEtFt6hhSPctZBqOcxjSvykiMZICxI\n 1FcYV7NbDbqcCF4ng0d60duQmtj8qXxXchnBdvk0/aplV6D738tSm42gEZ1N92jtK0Xq\n Y6UmujPHquxe6kgdCXjtaXKsCjAdCiisoqkv9jcsa2q+CSQ3S6d8jLZjLJt395MFpcVb\n OJDA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=MhbrV+sPh98Wjah4fShxYwAeYTq1APxwR/puaCj88KY=;\n b=6xRPVlOrwcyYuye4pYXXfsKPWWc+oC4VBBcXLBpa8CwTSjLZmlGV25xyGjuVLeyQh5\n J0v4d8SV0mlCePObE2BduREzW9c3DO4ymfgsQeM9Is5AftzrbqiVIrFEFnxI2jpas8cY\n m1r6Q+0splPaU8eRdJ51PfuqoO0hI3FS6vYmyba8JLudxC0C6vzDHPPxridqp6G0KTK1\n Gq5dn6ZpOfN4idZuRlnKrIk/Lnt+E5PsRJum75lRCyi6OY23sadOxPsQ20bBSISrebP8\n yxUFzjZqWCL0rBYLVT5Urq99VslQqFrZbu5IgE6zRC2gYd+uTDZyIQb4Fdtf7X0LMn0d\n WTxQ==", "X-Gm-Message-State": "AOAM531vs20yxy8wr7RswU84Q4MD16OCEz0BfgzU1z5QR9aKcFlMAC1p\n ehO5FdVuK0QlkzWXQqu+LhySAxbERXQ=", "X-Google-Smtp-Source": "\n ABdhPJxayXzKt7gnPyClusBIPSjf7jypjf/RO49Hoq2xaPD86neIW9nhsTW1oXa6QQeucy74OZQJnQ==", "X-Received": "by 2002:a05:6808:ec3:b0:2ef:3f6a:5a1e with SMTP id\n q3-20020a0568080ec300b002ef3f6a5a1emr3383140oiv.296.1651776647006;\n Thu, 05 May 2022 11:50:47 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?V=C3=ADctor_Colombo?= <victor.colombo@eldorado.org.br>", "Subject": "[PULL 13/30] target/ppc: Remove msr_ds macro", "Date": "Thu, 5 May 2022 15:49:21 -0300", "Message-Id": "<20220505184938.351866-14-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::22f;\n envelope-from=danielhb413@gmail.com; helo=mail-oi1-x22f.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Víctor Colombo <victor.colombo@eldorado.org.br>\n\nmsr_ds macro hides the usage of env->msr, which is a bad behavior\nSubstitute it with FIELD_EX64 calls that explicitly use env->msr\nas a parameter.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20220504210541.115256-6-victor.colombo@eldorado.org.br>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/cpu.h | 2 +-\n target/ppc/mmu_common.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex c561d664de..5abc612fe0 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -355,6 +355,7 @@ typedef enum {\n #define MSR_LE 0 /* Little-endian mode 1 hflags */\n \n FIELD(MSR, PR, MSR_PR, 1)\n+FIELD(MSR, DS, MSR_DS, 1)\n FIELD(MSR, LE, MSR_LE, 1)\n \n /* PMU bits */\n@@ -486,7 +487,6 @@ FIELD(MSR, LE, MSR_LE, 1)\n #define msr_ep ((env->msr >> MSR_EP) & 1)\n #define msr_ir ((env->msr >> MSR_IR) & 1)\n #define msr_dr ((env->msr >> MSR_DR) & 1)\n-#define msr_ds ((env->msr >> MSR_DS) & 1)\n #define msr_ts ((env->msr >> MSR_TS1) & 3)\n \n #define DBCR0_ICMP (1 << 27)\ndiff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c\nindex 6ef8b1c00d..7e77b9b84a 100644\n--- a/target/ppc/mmu_common.c\n+++ b/target/ppc/mmu_common.c\n@@ -768,7 +768,7 @@ static bool mmubooke206_get_as(CPUPPCState *env,\n *pr_out = !!(epidr & EPID_EPR);\n return true;\n } else {\n- *as_out = msr_ds;\n+ *as_out = FIELD_EX64(env->msr, MSR, DS);\n *pr_out = FIELD_EX64(env->msr, MSR, PR);\n return false;\n }\n", "prefixes": [ "PULL", "13/30" ] }