Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627172/?format=api
{ "id": 1627172, "url": "http://patchwork.ozlabs.org/api/patches/1627172/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-6-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-6-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:13", "name": "[PULL,05/30] target/ppc: Fix BookE debug interrupt generation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5f83bba0a7feb692ee22c6e08726f687d2d45132", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-6-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627172/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627172/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=ELU5s3pK;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvNzK3Sckz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:28:45 +1000 (AEST)", "from localhost ([::1]:60570 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmh9V-0007xT-FE\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:28:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:47110)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYY-0002mR-2M; Thu, 05 May 2022 14:50:30 -0400", "from mail-oa1-x36.google.com ([2001:4860:4864:20::36]:45669)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYQ-0004QF-4M; Thu, 05 May 2022 14:50:29 -0400", "by mail-oa1-x36.google.com with SMTP id\n 586e51a60fabf-e93bbb54f9so5080760fac.12;\n Thu, 05 May 2022 11:50:21 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.50.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:50:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=smaERNTnj8VuQqy/NB3WV2AHxA7pkgB+yEo/MlXNzKE=;\n b=ELU5s3pKEBp9RWG/H2U83ZtUFnVuKlfuUSk/ZtCksu9I4YUjJ9YwbJ5hrIPiyKmiDx\n uA/wfPmTvdG/he2Q8kn8Ya4z0RY6s1d/CdjF6WZx2aImcRWbnLS2akGB4FQBc8YXbV6e\n 0BRLz2R8aH/wRnaEsQdENlsDnVulnNiKdDViP3bkmOjNlzaCQ2EnSRmZ7uTBRNvB4ANx\n YQEmlXuz2P+lCCv/gPUEbmt6eSoqi1qrv93UC/LskUwP1vfl+f0NNJZxDPwMeP8SMWyg\n vVEjwsJlTgg+gZk2Oo1rT/fHbVfGdcaVp4ed91uXfSKREo7VVmVjYPVYQdGQRnSTHbWt\n dZZw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=smaERNTnj8VuQqy/NB3WV2AHxA7pkgB+yEo/MlXNzKE=;\n b=DlLN9Jl6ILfKkc8XgSrk700v128E8e3h808dqIPlX/HuzxuY74iRSq9YzEIJ42vcrQ\n prWfvxhABwsdAyMfRLnVDWEn6tamoY/TAhKf/j0uBU/xt6TT8l7masjyBKVZ9xpfJjRO\n Mu9IeUhVK0N2GOqUlxwuWe5vGZ5MDelKM+37JCeWv+81xsaeyW+ssn3eL2liwmXE9k0b\n xi+2g7fFTVNznDlgFDFlEphrm6RH6tWJKgKBpoWClDXpJMQosTzsGp11mtxjQR98iOC3\n UwS3JKnTwa0BCt3lMTLBMqgTRZi4Zt/hE6llgz1HMlHE3vu8hViLGc7TZOoNAAKwU/kD\n FnpA==", "X-Gm-Message-State": "AOAM532gwkX25l4bqSSQOCp2CqRHFWNfrJTrSD2ctbLTgJpYr7Fyu7gg\n 9M0K5wKZtUMu4Hp2FlzUPGzu6C7zYiQ=", "X-Google-Smtp-Source": "\n ABdhPJxz9VN1xqM1jUwpwgTZmYlNP3oS8LtL4oe/K5oVjscgzxOCGwF4A9KWQ9BZy6lY47FLt4C9mg==", "X-Received": "by 2002:a05:6871:a5:b0:d4:41d7:d341 with SMTP id\n u37-20020a05687100a500b000d441d7d341mr3022669oaa.6.1651776620254;\n Thu, 05 May 2022 11:50:20 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org, Bin Meng <bin.meng@windriver.com>,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>,\n Fabiano Rosas <farosas@linux.ibm.com>,\n Lucas Mateus Castro <lucas.araujo@eldorado.org.br>", "Subject": "[PULL 05/30] target/ppc: Fix BookE debug interrupt generation", "Date": "Thu, 5 May 2022 15:49:13 -0300", "Message-Id": "<20220505184938.351866-6-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2001:4860:4864:20::36;\n envelope-from=danielhb413@gmail.com; helo=mail-oa1-x36.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Bin Meng <bin.meng@windriver.com>\n\nPer E500 core reference manual [1], chapter 8.4.4 \"Branch Taken Debug\nEvent\" and chapter 8.4.5 \"Instruction Complete Debug Event\":\n\n \"A branch taken debug event occurs if both MSR[DE] and DBCR0[BRT]\n are set ... Branch taken debug events are not recognized if MSR[DE]\n is cleared when the branch instruction executes.\"\n\n \"An instruction complete debug event occurs when any instruction\n completes execution so long as MSR[DE] and DBCR0[ICMP] are both\n set ... Instruction complete debug events are not recognized if\n MSR[DE] is cleared at the time of the instruction execution.\"\n\nCurrent codes do not check MSR.DE bit before setting HFLAGS_SE and\nHFLAGS_BE flag, which would cause the immediate debug interrupt to\nbe generated, e.g.: when DBCR0.ICMP bit is set by guest software\nand MSR.DE is not set.\n\n[1] https://www.nxp.com/docs/en/reference-manual/E500CORERM.pdf\n\nSigned-off-by: Bin Meng <bin.meng@windriver.com>\nReviewed-by: Cédric Le Goater <clg@kaod.org>\nReviewed-by: Fabiano Rosas <farosas@linux.ibm.com>\nReviewed-by: Lucas Mateus Castro <lucas.araujo@eldorado.org.br>\nMessage-Id: <20220421011729.1148727-1-bmeng.cn@gmail.com>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/helper_regs.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c\nindex 9a691d6833..77bc57415c 100644\n--- a/target/ppc/helper_regs.c\n+++ b/target/ppc/helper_regs.c\n@@ -63,10 +63,10 @@ static uint32_t hreg_compute_hflags_value(CPUPPCState *env)\n \n if (ppc_flags & POWERPC_FLAG_DE) {\n target_ulong dbcr0 = env->spr[SPR_BOOKE_DBCR0];\n- if (dbcr0 & DBCR0_ICMP) {\n+ if ((dbcr0 & DBCR0_ICMP) && msr_de) {\n hflags |= 1 << HFLAGS_SE;\n }\n- if (dbcr0 & DBCR0_BRT) {\n+ if ((dbcr0 & DBCR0_BRT) && msr_de) {\n hflags |= 1 << HFLAGS_BE;\n }\n } else {\n", "prefixes": [ "PULL", "05/30" ] }