Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627150/?format=api
{ "id": 1627150, "url": "http://patchwork.ozlabs.org/api/patches/1627150/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-3-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-3-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:10", "name": "[PULL,02/30] target/ppc: init 'lpcr' in kvmppc_enable_cap_large_decr()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "827daeb1e22ab713a5230a0693bfa99c09460577", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-3-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627150/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=BG+7HpVj;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvNZC1nvdz9sBF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 05:10:27 +1000 (AEST)", "from localhost ([::1]:53488 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmgrl-00073D-Pg\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 15:10:23 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:46890)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYS-0002YP-QF; Thu, 05 May 2022 14:50:24 -0400", "from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:38650)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYO-0004Mr-Cz; Thu, 05 May 2022 14:50:24 -0400", "by mail-oi1-x22d.google.com with SMTP id r185so435403oih.5;\n Thu, 05 May 2022 11:50:11 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.50.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:50:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Tyv6DKZTyEtbbjp2Y4mGixcjfCU3B5FHNbPjr8yeNfI=;\n b=BG+7HpVjDVBriEnXAjh7HI5/oPTz2Dyvch1BabDMIkfrBDXU5+rODJQEPvjO9nDMtp\n eTx4I+Th0RZY4F1r/3yIbzS2tlrdEmEdn8Vlp+XURYr8ujZAl/fRtXRZ7mqtLxl+ty2f\n HqJA3v3sZ4ZrQBBDptKgimBlbpzbAGUgJqmMzr9PXDAJxGYezSxO4rnPKGgYF35PO/9h\n mheltiuGnQ6nlR7/BODjDMviGKP2QnKm7Qb1HL7RyvjSaXYecIGI9UUxuHyRsjhUJgoG\n 5Urm4W1QRRqUKp24HWsPnBtt7v1mts/6lczUQyUVJUohoc9Pn3NpmmI74WUocGNx+yZB\n e30g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Tyv6DKZTyEtbbjp2Y4mGixcjfCU3B5FHNbPjr8yeNfI=;\n b=2wHET0THYF8/CMw37TT/T165lTpZomfj6AHKeSD296W/dSH7RKp+VZ6Lz+xtjfVSK4\n gjBb3q9Zzn2FesEWYwZMfVjbZBJPLc7ni5togVid/hAN2EtRpkl0WRJ8bcFd7KP48VgI\n XXcuEM8cQpOvL+CJiFVWXjMd7/aHo5inhAa3swR5Y5vom5ieBVqnuJswi5KUv7iZ5YKp\n rnRMkU/JawEUiBdFAwUzpEvq6IPMxy9Igq1wVib5K/CUbFJCEYOuYmjkUVie28DxYr3h\n LBrJO7yTWY0QZzLUQjwV2Vuqwgj0Gek0kkrqk0BVydU6XZ7nGFeYbmjPu3HNxBDlTLmd\n jn2A==", "X-Gm-Message-State": "AOAM530M3SJ7z7uUhJFmcemIPe2kSzM6XcH/b3uUWeLox9Thp6akjHff\n dU1qSjs1/q/i3wEB7qAIX0kA8hvAlkY=", "X-Google-Smtp-Source": "\n ABdhPJwZVuiYHMWZl10+1WrKr7Q0/0c0focAHHr5LcNmrMBi43rj7SUPO1XelpU+C2QB49TE40m12A==", "X-Received": "by 2002:aca:330b:0:b0:326:566a:5a74 with SMTP id\n z11-20020aca330b000000b00326566a5a74mr3257301oiz.6.1651776610466;\n Thu, 05 May 2022 11:50:10 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>", "Subject": "[PULL 02/30] target/ppc: init 'lpcr' in\n kvmppc_enable_cap_large_decr()", "Date": "Thu, 5 May 2022 15:49:10 -0300", "Message-Id": "<20220505184938.351866-3-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::22d;\n envelope-from=danielhb413@gmail.com; helo=mail-oi1-x22d.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "'lpcr' is used as an input of kvm_get_one_reg(). Valgrind doesn't\nunderstand that and it returns warnings as such for this function:\n\n==55240== Thread 1:\n==55240== Conditional jump or move depends on uninitialised value(s)\n==55240== at 0xB011E4: kvmppc_enable_cap_large_decr (kvm.c:2546)\n==55240== by 0x92F28F: cap_large_decr_cpu_apply (spapr_caps.c:523)\n==55240== by 0x930C37: spapr_caps_cpu_apply (spapr_caps.c:921)\n==55240== by 0x955D3B: spapr_reset_vcpu (spapr_cpu_core.c:73)\n==55240== by 0x95612B: spapr_cpu_core_reset (spapr_cpu_core.c:209)\n==55240== by 0x95619B: spapr_cpu_core_reset_handler (spapr_cpu_core.c:218)\n==55240== by 0xD3605F: qemu_devices_reset (reset.c:69)\n==55240== by 0x92112B: spapr_machine_reset (spapr.c:1641)\n==55240== by 0x4FBD63: qemu_system_reset (runstate.c:444)\n==55240== by 0x62812B: qdev_machine_creation_done (machine.c:1247)\n==55240== by 0x5064C3: qemu_machine_creation_done (vl.c:2725)\n==55240== by 0x5065DF: qmp_x_exit_preconfig (vl.c:2748)\n==55240== Uninitialised value was created by a stack allocation\n==55240== at 0xB01158: kvmppc_enable_cap_large_decr (kvm.c:2540)\n\nInit 'lpcr' to avoid this warning.\n\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\nMessage-Id: <20220331001717.616938-3-danielhb413@gmail.com>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/kvm.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\nindex 01baea467f..69094ddb7a 100644\n--- a/target/ppc/kvm.c\n+++ b/target/ppc/kvm.c\n@@ -2537,7 +2537,7 @@ int kvmppc_get_cap_large_decr(void)\n int kvmppc_enable_cap_large_decr(PowerPCCPU *cpu, int enable)\n {\n CPUState *cs = CPU(cpu);\n- uint64_t lpcr;\n+ uint64_t lpcr = 0;\n \n kvm_get_one_reg(cs, KVM_REG_PPC_LPCR_64, &lpcr);\n /* Do we need to modify the LPCR? */\n", "prefixes": [ "PULL", "02/30" ] }