Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1627143/?format=api
{ "id": 1627143, "url": "http://patchwork.ozlabs.org/api/patches/1627143/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-2-danielhb413@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220505184938.351866-2-danielhb413@gmail.com>", "list_archive_url": null, "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ceb404fd88e9fb9856cb9242082602f6691eed2c", "submitter": { "id": 74265, "url": "http://patchwork.ozlabs.org/api/people/74265/?format=api", "name": "Daniel Henrique Barboza", "email": "danielhb413@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220505184938.351866-2-danielhb413@gmail.com/mbox/", "series": [ { "id": 298671, "url": "http://patchwork.ozlabs.org/api/series/298671/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=298671", "date": "2022-05-05T18:49:09", "name": "[PULL,01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/298671/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1627143/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1627143/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=KGBv952l;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KvNFl4CyPz9sG6\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 May 2022 04:56:10 +1000 (AEST)", "from localhost ([::1]:34746 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nmgdz-0001ue-Fy\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 May 2022 14:56:07 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:46646)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYO-0002O2-8K; Thu, 05 May 2022 14:50:21 -0400", "from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]:37824)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <danielhb413@gmail.com>)\n id 1nmgYD-0004LN-Ey; Thu, 05 May 2022 14:50:11 -0400", "by mail-oi1-x22f.google.com with SMTP id r1so5261361oie.4;\n Thu, 05 May 2022 11:50:08 -0700 (PDT)", "from balboa.ibmuc.com (201-1-57-208.dsl.telesp.net.br.\n [201.1.57.208]) by smtp.gmail.com with ESMTPSA id\n n67-20020aca4046000000b00325cda1ff94sm917146oia.19.2022.05.05.11.50.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 11:50:07 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=8wRFsB4oxkSKLu/a1qVp36Mev+RY06uW0DVJiFCGAJk=;\n b=KGBv952lbkOAnZGy+ufi8U//mnLPYF4KmXyZlSInm6wl1rvA479kFy2KwSpVHhgJwy\n PFvlSnVnqxKh/ksOZGvbhsnRGx1ijg+bWgNsGc/JxjUBnqbK6sf6a4omSJZK+XYcFONI\n QI44Donrf7WdYqnkjCPsAyW5uVRRlkwd5EeOSD9dOge3Mp9kO6sdjdEKWghztQLFcGYj\n 81tUw4gSi3GwLjXXKk/Yj+SyZnCuX+pjIRlYOTUd0ExUoe8Ug6jnQeCA2Uk/TD3xX7o9\n lgwsFS5ECk5V4BWrgF0rtxTAFvJqW2WV7Fp6hw8e92BHfdCSSPFLuFEDmLhWThp0FUrO\n 7cGA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=8wRFsB4oxkSKLu/a1qVp36Mev+RY06uW0DVJiFCGAJk=;\n b=zVTiZwcVsA/KMjVxhCw3Ux5WjBOD7DpwKVlBJvIvGMiQ0zmyEWxFtnljcgRxuMBsBQ\n 6ZR7UBJC6WwSg4VJvKMj2B0S3pCLQSvDzsnTXYFFM0JNmX/Bk6zS7QCLM17fgPlqdQcx\n gZr38xxpNHFxPxA49+fVmDfsYHbdNNI3w9u771YYuOc5FXqg1bfl4zfwEUSELaAiDMUO\n mXHx7dDGba4y4BmuF6DyUE37PBlWlwdp1a6oInNyAPHwBxJq4KfrpRnXbSW9CvSv0iU4\n Mf2hNmCb5tYoiMRqVzfoVHbGH4MKmNTZXN8jYd7BA2e/Hlg2jGUN2mgsMNLNv+J7Xte7\n 5Ugg==", "X-Gm-Message-State": "AOAM532w0kgRr20VRrY3aqFKucEVwhwWCfO86vXNrTwcMSGyLkCs0WE+\n +XD+/b3oI6qRgWJAUCTzIsRDzs0CToo=", "X-Google-Smtp-Source": "\n ABdhPJz0LFf/f4jT6UHoW08+tCaMLBAH0lvJJC2HyNITaHmFiOMenrpT1d85INEwx8xpF6g6+XwHDw==", "X-Received": "by 2002:a05:6808:120f:b0:325:cef0:3f7 with SMTP id\n a15-20020a056808120f00b00325cef003f7mr3339685oil.38.1651776607643;\n Thu, 05 May 2022 11:50:07 -0700 (PDT)", "From": "Daniel Henrique Barboza <danielhb413@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-ppc@nongnu.org, danielhb413@gmail.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n David Gibson <david@gibson.dropbear.id.au>", "Subject": "[PULL 01/30] target/ppc: initialize 'val' union in kvm_get_one_spr()", "Date": "Thu, 5 May 2022 15:49:09 -0300", "Message-Id": "<20220505184938.351866-2-danielhb413@gmail.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220505184938.351866-1-danielhb413@gmail.com>", "References": "<20220505184938.351866-1-danielhb413@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::22f;\n envelope-from=danielhb413@gmail.com; helo=mail-oi1-x22f.google.com", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Valgrind isn't convinced that we are initializing the values we assign\nto env->spr[spr] because it doesn't understand that the 'val' union is\nbeing written by the kvm_vcpu_ioctl() that follows (via struct\nkvm_one_reg).\n\nThis results in Valgrind complaining about uninitialized values every\ntime we use env->spr in a conditional, like this instance:\n\n==707578== Thread 1:\n==707578== Conditional jump or move depends on uninitialised value(s)\n==707578== at 0xA10A40: hreg_compute_hflags_value (helper_regs.c:106)\n==707578== by 0xA10C9F: hreg_compute_hflags (helper_regs.c:173)\n==707578== by 0xA110F7: hreg_store_msr (helper_regs.c:262)\n==707578== by 0xA051A3: ppc_cpu_reset (cpu_init.c:7168)\n==707578== by 0xD4730F: device_transitional_reset (qdev.c:799)\n==707578== by 0xD4A11B: resettable_phase_hold (resettable.c:182)\n==707578== by 0xD49A77: resettable_assert_reset (resettable.c:60)\n==707578== by 0xD4994B: resettable_reset (resettable.c:45)\n==707578== by 0xD458BB: device_cold_reset (qdev.c:296)\n==707578== by 0x48FBC7: cpu_reset (cpu-common.c:114)\n==707578== by 0x97B5EB: spapr_reset_vcpu (spapr_cpu_core.c:38)\n==707578== by 0x97BABB: spapr_cpu_core_reset (spapr_cpu_core.c:209)\n==707578== Uninitialised value was created by a stack allocation\n==707578== at 0xB11F08: kvm_get_one_spr (kvm.c:543)\n\nInitializing 'val' has no impact in the logic and makes Valgrind output\nmore bearable.\n\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\nReviewed-by: David Gibson <david@gibson.dropbear.id.au>\nMessage-Id: <20220331001717.616938-2-danielhb413@gmail.com>\nSigned-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>\n---\n target/ppc/kvm.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\nindex a3c31b4e48..01baea467f 100644\n--- a/target/ppc/kvm.c\n+++ b/target/ppc/kvm.c\n@@ -542,10 +542,11 @@ static void kvm_get_one_spr(CPUState *cs, uint64_t id, int spr)\n {\n PowerPCCPU *cpu = POWERPC_CPU(cs);\n CPUPPCState *env = &cpu->env;\n+ /* Init 'val' to avoid \"uninitialised value\" Valgrind warnings */\n union {\n uint32_t u32;\n uint64_t u64;\n- } val;\n+ } val = { };\n struct kvm_one_reg reg = {\n .id = id,\n .addr = (uintptr_t) &val,\n", "prefixes": [ "PULL", "01/30" ] }