Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1624486/?format=api
{ "id": 1624486, "url": "http://patchwork.ozlabs.org/api/patches/1624486/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220429182734.4281-1-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220429182734.4281-1-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-29T18:27:34", "name": "mmc: fsl_esdhc: Fix 'Internal clock never stabilised.' error", "commit_ref": "6dcf1c28dd4344e73fb3108c037b5b9093852328", "pull_url": null, "state": "accepted", "archived": false, "hash": "7d1b069858601d605d72093c7599815393de96f0", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 12423, "url": "http://patchwork.ozlabs.org/api/users/12423/?format=api", "username": "Jaehoon", "first_name": "Jaehoon", "last_name": "Chung", "email": "jh80.chung@samsung.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220429182734.4281-1-pali@kernel.org/mbox/", "series": [ { "id": 297705, "url": "http://patchwork.ozlabs.org/api/series/297705/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=297705", "date": "2022-04-29T18:27:34", "name": "mmc: fsl_esdhc: Fix 'Internal clock never stabilised.' error", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/297705/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1624486/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1624486/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AzYZXeL5;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"AzYZXeL5\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kqgvs0gjlz9s75\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 30 Apr 2022 04:27:53 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E9AF88393F;\n\tFri, 29 Apr 2022 20:27:49 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 6B7FD81A02; Fri, 29 Apr 2022 20:27:48 +0200 (CEST)", "from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E11FA8393F\n for <u-boot@lists.denx.de>; Fri, 29 Apr 2022 20:27:45 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 8CC57B8377D;\n Fri, 29 Apr 2022 18:27:45 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 28AD4C385AE;\n Fri, 29 Apr 2022 18:27:44 +0000 (UTC)", "by pali.im (Postfix)\n id 8C2F3CAF; Fri, 29 Apr 2022 20:27:41 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1651256864;\n bh=iYgdBXyG16IapMDsnR7t0ayNFx9RYsDlHtUNyAvQqNU=;\n h=From:To:Cc:Subject:Date:From;\n b=AzYZXeL5VPuW/iWhCNJPiOF6UQOL0U2KkQ3chNs9g/YW3LY3/lfagAaTfpklYBmrm\n O05/5ixkVAPugyFdn6GJ5FXnFobd5JlxSH26d10Db4Dlk2kerOPVTCm27as5x+vehl\n NCxg3/YwA1qgEFHQ18LLikuHOA/OxuNRlKmAOW+4xTDQYJGQGALrfzAlU/xeZ/aBdA\n T/v9anz7XdwYBpYk387+1ZCclrQjPJL8XGCTPeA1eVuNLETDx5LBPh3hVOmOa8yOLe\n Z6v8gyYUgDamp2rdUYYRZbe7zIPn8sSQzv4ACnHnz3gVgVmT4HuSWfIc5+Ox2my+CU\n jepfs+0lqN3Kw==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Peng Fan <peng.fan@nxp.com>, Priyanka Jain <priyanka.jain@nxp.com>,\n Jaehoon Chung <jh80.chung@samsung.com>, Sinan Akman <sinan@writeme.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH] mmc: fsl_esdhc: Fix 'Internal clock never stabilised.' error", "Date": "Fri, 29 Apr 2022 20:27:34 +0200", "Message-Id": "<20220429182734.4281-1-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Only newer eSDHC controllers set PRSSTAT_SDSTB flag. So do not wait until\nflag PRSSTAT_SDSTB is set on old pre-2.2 controllers. Instead sleep for\nfixed amount of time like it was before commit 6f883e501b65 (\"mmc:\nfsl_esdhc: Add emmc hs200 support\").\n\nThis change fixes error 'Internal clock never stabilised.' which is printed\non P2020 board at every access to SD card.\n\nFixes: 6f883e501b65 (\"mmc: fsl_esdhc: Add emmc hs200 support\")\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n drivers/mmc/fsl_esdhc.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c\nindex fdf2cc290e06..3b3587bd8d72 100644\n--- a/drivers/mmc/fsl_esdhc.c\n+++ b/drivers/mmc/fsl_esdhc.c\n@@ -503,6 +503,7 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock)\n \tu32 time_out;\n \tu32 value;\n \tuint clk;\n+\tu32 hostver;\n \n \tif (clock < mmc->cfg->f_min)\n \t\tclock = mmc->cfg->f_min;\n@@ -543,6 +544,14 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock)\n \n \tesdhc_clrsetbits32(®s->sysctl, SYSCTL_CLOCK_MASK, clk);\n \n+\t/* Only newer eSDHC controllers set PRSSTAT_SDSTB flag */\n+\thostver = esdhc_read32(&priv->esdhc_regs->hostver);\n+\tif (HOSTVER_VENDOR(hostver) <= VENDOR_V_22) {\n+\t\tudelay(10000);\n+\t\tesdhc_setbits32(®s->sysctl, SYSCTL_PEREN | SYSCTL_CKEN);\n+\t\treturn;\n+\t}\n+\n \ttime_out = 20;\n \tvalue = PRSSTAT_SDSTB;\n \twhile (!(esdhc_read32(®s->prsstat) & value)) {\n@@ -562,6 +571,7 @@ static void esdhc_clock_control(struct fsl_esdhc_priv *priv, bool enable)\n \tstruct fsl_esdhc *regs = priv->esdhc_regs;\n \tu32 value;\n \tu32 time_out;\n+\tu32 hostver;\n \n \tvalue = esdhc_read32(®s->sysctl);\n \n@@ -572,6 +582,13 @@ static void esdhc_clock_control(struct fsl_esdhc_priv *priv, bool enable)\n \n \tesdhc_write32(®s->sysctl, value);\n \n+\t/* Only newer eSDHC controllers set PRSSTAT_SDSTB flag */\n+\thostver = esdhc_read32(&priv->esdhc_regs->hostver);\n+\tif (HOSTVER_VENDOR(hostver) <= VENDOR_V_22) {\n+\t\tudelay(10000);\n+\t\treturn;\n+\t}\n+\n \ttime_out = 20;\n \tvalue = PRSSTAT_SDSTB;\n \twhile (!(esdhc_read32(®s->prsstat) & value)) {\n", "prefixes": [] }