Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1621975/?format=api
{ "id": 1621975, "url": "http://patchwork.ozlabs.org/api/patches/1621975/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220425141216.2140-1-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220425141216.2140-1-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-25T14:12:16", "name": "[v2] board: freescale: p1_p2_rdb_pc: Fix parsing inverted bits from boot input data", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "208c9e6fb946ed7b73ef0cfbae304d4bb278625d", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 55230, "url": "http://patchwork.ozlabs.org/api/users/55230/?format=api", "username": "freenix", "first_name": "Peng", "last_name": "Fan", "email": "van.freenix@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220425141216.2140-1-pali@kernel.org/mbox/", "series": [ { "id": 296737, "url": "http://patchwork.ozlabs.org/api/series/296737/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=296737", "date": "2022-04-25T14:12:16", "name": "[v2] board: freescale: p1_p2_rdb_pc: Fix parsing inverted bits from boot input data", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/296737/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1621975/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1621975/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pucrKdBR;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"pucrKdBR\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kn6S35jZ9z9s0B\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 26 Apr 2022 00:13:21 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 85C9983B4F;\n\tMon, 25 Apr 2022 16:13:13 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id DB262839B7; Mon, 25 Apr 2022 16:13:10 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 19C7F80133\n for <u-boot@lists.denx.de>; Mon, 25 Apr 2022 16:13:08 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 0C908615DC;\n Mon, 25 Apr 2022 14:13:06 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 4A4E7C385A7;\n Mon, 25 Apr 2022 14:13:05 +0000 (UTC)", "by pali.im (Postfix)\n id 7158E4A32; Mon, 25 Apr 2022 16:13:02 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1650895985;\n bh=DT872Bx1TH6uG4XhX7p+vCedlXvpG93gcaFTF/gHVpY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pucrKdBRTt+il55LVsOxlLUZOMkRfqyNMI2xCUjiZmertrea88fJoaKmgHaHTRFiI\n QN+pg2aLRukhe7lCs1pFKGoXNr667BK3udkhpQpGO9PP0rYTXm20NyywBR9VXh78DO\n R3R6bJF6v1j6OUzzcjvcDWrUOIcDy3I4zHnIjKAeeuDoYd2S7fuG167H800NGafCmH\n I//d605GSvHpNTcrd/6ggosDoFz3H3+/MWKYrXU3udmBqCJ46k2+hDvvAmbaTuNSk6\n o+YYow5sOg3bRZ/mLWsxPKQ9pUw8HHkwmsgh+cz61sQ6nmIowh8IwVqQtUPSxw5UwY\n zWy5ejVZrPVdA==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>, Qiang Zhao <qiang.zhao@nxp.com>,\n Shengzhou Liu <Shengzhou.Liu@nxp.com>, Sinan Akman <sinan@writeme.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH v2] board: freescale: p1_p2_rdb_pc: Fix parsing inverted bits\n from boot input data", "Date": "Mon, 25 Apr 2022 16:12:16 +0200", "Message-Id": "<20220425141216.2140-1-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220407101624.15850-4-pali@kernel.org>", "References": "<20220407101624.15850-4-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "On some boards upper 4 bits of i2c boot input data (register 0) are\ninverted. Information which bits are inverted is stored in register 2.\n\nSo invert read input data back according to register 2 prior processing\nthem. This fixes printing \"rom_loc: value\" line during booting.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\nChanges in v2:\n* Use register 2 for detecting which bits needs to be inverted\n---\n board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c\nindex 29502a5c05c2..cdbff03ac45c 100644\n--- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c\n+++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c\n@@ -164,7 +164,7 @@ int checkboard(void)\n {\n \tstruct cpld_data *cpld_data = (void *)(CONFIG_SYS_CPLD_BASE);\n \tccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);\n-\tu8 in, out, io_config, val;\n+\tu8 in, out, invert, io_config, val;\n \tint bus_num = CONFIG_SYS_SPD_BUS_NUM;\n \n \tprintf(\"Board: %s CPLD: V%d.%d PCBA: V%d.0\\n\", CONFIG_BOARDNAME,\n@@ -187,6 +187,7 @@ int checkboard(void)\n \n \tif (dm_i2c_read(dev, 0, &in, 1) < 0 ||\n \t dm_i2c_read(dev, 1, &out, 1) < 0 ||\n+\t dm_i2c_read(dev, 2, &invert, 1) < 0 ||\n \t dm_i2c_read(dev, 3, &io_config, 1) < 0) {\n \t\tprintf(\"Error reading i2c boot information!\\n\");\n \t\treturn 0; /* Don't want to hang() on this error */\n@@ -196,13 +197,14 @@ int checkboard(void)\n \n \tif (i2c_read(CONFIG_SYS_I2C_PCA9557_ADDR, 0, 1, &in, 1) < 0 ||\n \t i2c_read(CONFIG_SYS_I2C_PCA9557_ADDR, 1, 1, &out, 1) < 0 ||\n+\t i2c_read(CONFIG_SYS_I2C_PCA9557_ADDR, 2, 1, &invert, 1) < 0 ||\n \t i2c_read(CONFIG_SYS_I2C_PCA9557_ADDR, 3, 1, &io_config, 1) < 0) {\n \t\tprintf(\"Error reading i2c boot information!\\n\");\n \t\treturn 0; /* Don't want to hang() on this error */\n \t}\n \t#endif\n \n-\tval = (in & io_config) | (out & (~io_config));\n+\tval = ((in ^ invert) & io_config) | (out & (~io_config));\n \n \tputs(\"rom_loc: \");\n \tif ((val & (~__SW_BOOT_MASK)) == __SW_BOOT_SD) {\n", "prefixes": [ "v2" ] }