Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1614772/?format=api
{ "id": 1614772, "url": "http://patchwork.ozlabs.org/api/patches/1614772/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220408082805.12561-1-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220408082805.12561-1-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-08T08:28:05", "name": "[v2] SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default", "commit_ref": "b616947052178f358bbb07d368ba3399fce9d495", "pull_url": null, "state": "accepted", "archived": false, "hash": "42ee06e1cc8e503206dfa40c62e87e7eb2c00978", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220408082805.12561-1-pali@kernel.org/mbox/", "series": [ { "id": 294157, "url": "http://patchwork.ozlabs.org/api/series/294157/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=294157", "date": "2022-04-08T08:28:05", "name": "[v2] SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/294157/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1614772/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1614772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Cm+4PVWR;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"Cm+4PVWR\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KZWcM1FNFz9sG6\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 8 Apr 2022 18:28:51 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EB65E83DAE;\n\tFri, 8 Apr 2022 10:28:46 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id E573F83DB9; Fri, 8 Apr 2022 10:28:44 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1799F83DAE\n for <u-boot@lists.denx.de>; Fri, 8 Apr 2022 10:28:42 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id F3CB3617EA;\n Fri, 8 Apr 2022 08:28:39 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 3E05BC385A1;\n Fri, 8 Apr 2022 08:28:39 +0000 (UTC)", "by pali.im (Postfix)\n id 5F13E6D7; Fri, 8 Apr 2022 10:28:36 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1649406519;\n bh=e8/bR3Q+0Rd47eiKQ1P31ONoKVX0YLs1/aAx16D0iTE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Cm+4PVWRi6WEwhMEqQd9qYOABI9FQD/Gr6tjBnLI8cxUEi0b+Wh7vgAtkWxw3KKnE\n S5g78O0QsR3Y8wo0opL9HUwgjKEA3U/lFG/bac8vu+lZN2Z2Kunpz9J8p+8KFr8asQ\n kAa9+YUmWPdACZbiQWcyFTZLDua+1a5lmZ4YQ5rfGK5drhyXAxDiuPeFqHru07oOlx\n /f74Q/INwRMsHwEGuiwqoBbVeWz4noNE8Xq5PDUH95ZGj/Ykc28UIg8YjtCBunz4QY\n 1/ZqhFIYbSH9I4D7bqCgInr2y8SZdsmvKMsgmr0ngp1BGjFhc+2aAcPrCANmj/KIb7\n MvK9AsEihs6kw==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>, Simon Glass <sjg@chromium.org>,\n Rick Chen <rick@andestech.com>, Andre Przywara <andre.przywara@arm.com>,\n Michal Simek <michal.simek@xilinx.com>,\n =?utf-8?q?Marek_Beh=C3=BAn?= <marek.behun@nic.cz>,\n Sinan Akman <sinan@writeme.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH v2] SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without\n SPL_FRAMEWORK by default", "Date": "Fri, 8 Apr 2022 10:28:05 +0200", "Message-Id": "<20220408082805.12561-1-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220405092822.20547-1-pali@kernel.org>", "References": "<20220405092822.20547-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "On P2020 board is SPL malloc simple always failing with error and loops:\n\n SD boot...\n alloc space exhausted\n Bad trap at PC: f8f8b5f0, SR: 21200, vector=d00\n NIP: 00000000 XER: 00000000 LR: 00000000 REGS: f8f8b5f0 TRAP: 20000000 DAR: 00000000\n MSR: 00021200 EE: 0 PR: 0 FP: 0 ME: 1 IR/DR: 00\n\n GPR00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000\n GPR08: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000\n GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000\n GPR24: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000\n Call backtrace:\n Exception in kernel pc f8f8b5f0 signal 0\n\nInspection showed that gd->malloc_limit is zero. And it is because\ngenerally SPL_FRAMEWORK initialize SPL's gd->malloc_limit. But when\nSPL_FRAMEWORK is not enabled then in most cases nobody initialize\ngd->malloc_limit and so SPL malloc simple does not work.\n\nSo disable SPL_SYS_MALLOC_SIMPLE by default when SPL_FRAMEWORK is not\nenabled. SPL_SYS_MALLOC_SIMPLE can be disabled only by setting\nSPL_SYS_MALLOC_F_LEN to zero. So do it.\n\nThis change fixes SPL error \"alloc space exhausted\" on P2020 board.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n\n---\nChanges in v2:\n* Fixed name of the config option\n---\n Kconfig | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/Kconfig b/Kconfig\nindex 9dd9ec7f6dfb..e8047eca3b52 100644\n--- a/Kconfig\n+++ b/Kconfig\n@@ -258,6 +258,7 @@ config SYS_MALLOC_LEN\n config SPL_SYS_MALLOC_F_LEN\n \thex \"Size of malloc() pool in SPL\"\n \tdepends on SYS_MALLOC_F && SPL\n+\tdefault 0 if !SPL_FRAMEWORK\n \tdefault 0x2800 if RCAR_GEN3\n \tdefault SYS_MALLOC_F_LEN\n \thelp\n", "prefixes": [ "v2" ] }