Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1613424/?format=api
{ "id": 1613424, "url": "http://patchwork.ozlabs.org/api/patches/1613424/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220405131237.405-2-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220405131237.405-2-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-05T13:12:30", "name": "[1/8] powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support", "commit_ref": "e8c0e0064c8a7b0665fd1393c2e3266f80e884a8", "pull_url": null, "state": "accepted", "archived": false, "hash": "7e2aacd69d24b150e5bb3e4823603bc9ebb54e39", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 87636, "url": "http://patchwork.ozlabs.org/api/users/87636/?format=api", "username": "priyankajain", "first_name": "Priyanka", "last_name": "Jain", "email": "priyanka.jain@nxp.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220405131237.405-2-pali@kernel.org/mbox/", "series": [ { "id": 293592, "url": "http://patchwork.ozlabs.org/api/series/293592/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=293592", "date": "2022-04-05T13:12:33", "name": "powerpc: mpc85xx: Fix and cleanup mpc85xx code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/293592/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1613424/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1613424/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=H2+ocJCH;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"H2+ocJCH\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KXp7Z2jBXz9sCD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 Apr 2022 23:16:26 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BC01D83C0E;\n\tTue, 5 Apr 2022 15:15:10 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id D6B1583BEB; Tue, 5 Apr 2022 15:14:38 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A5EEE83B0E\n for <u-boot@lists.denx.de>; Tue, 5 Apr 2022 15:14:15 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id A5EAB61867;\n Tue, 5 Apr 2022 13:14:13 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id E3D46C385A2;\n Tue, 5 Apr 2022 13:14:12 +0000 (UTC)", "by pali.im (Postfix)\n id 679804A0B; Tue, 5 Apr 2022 15:14:10 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=unavailable\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1649164453;\n bh=hsWf1K1mnN+Wks8X+bko0BezQsm6Pah8ZbgesKQdnFQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=H2+ocJCHjN9lYI2enETryIohoSzoOSjciKcufdmS0EGxr66O4jz7J1VoMIgAkhl3j\n oxRrlmGGt3Jc+JzDfHoNAortnjWZ+dqqLLQr0itnUkqKosTooszz0hZLNl0PpE+3Lr\n EKL3UWhrWS6gDa4gbeBSbIjM6G4gbuKFCa9qig4WZo5CpTlS4HeltuQqPTafS+216F\n KJUwE5KMq5nMCF1bPnuAvajUchaqxcIuBlWHeRt9vBTOfMpCNFHyT4HUQDLi9zvb/u\n YivfXcOwo1ztoqPv0Vn1cCGiMFFzxGIRqAaiVFZgkcvPTCWXDO9ZDLEOAhJ92wYux+\n 0YoTXwpOBjEng==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>, Qiang Zhao <qiang.zhao@nxp.com>,\n Shengzhou Liu <Shengzhou.Liu@nxp.com>, Alexander Graf <agraf@csgraf.de>,\n Bin Meng <bmeng.cn@gmail.com>, Wolfgang Denk <wd@denx.de>,\n Sinan Akman <sinan@writeme.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 1/8] powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support", "Date": "Tue, 5 Apr 2022 15:12:30 +0200", "Message-Id": "<20220405131237.405-2-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220405131237.405-1-pali@kernel.org>", "References": "<20220405131237.405-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Currently CONFIG_OF_SEPARATE is completely broken and U-Boot for some\nmpc85xx board (e.g. P2020) has to be compiled with CONFIG_OF_EMBED.\nOtherwise it crashes during early init.\n\nWhen debug console is enabled and all debug logging options are turned on\nthen U-Boot on P2020 with CONFIG_OF_SEPARATE prints following error:\n\n No valid device tree binary found at 110dc300\n initcall sequence 110d3560 failed at call 1109535c (err=-1)\n ### ERROR ### Please RESET the board ###\n\nProblem is with appended DTB. When CONFIG_SYS_MPC85XX_NO_RESETVEC is set\nU-Boot binary image without DTB ends immediately after the .u_boot_list\nsection. At this position is defined _end symbol at which U-Boot expects\nstart of the appended DTB.\n\nProblem is that after .u_boot_list section are in linker script defined\nanother sections with 256 byte long padding which are completely empty.\nDuring conversion of U-Boot ELF binary to RAW binary u-boot-nodtb.bin,\nobjcopy removes trailing zero padding and therefore DTB is appended at\nwrong position.\n\nChanging alignment from 256 bytes to 4 bytes fixes this issue. And appended\nDTB is finally at he correct position. With this fix U-Boot on P2020 with\nCONFIG_OF_SEPARATE option starts working again.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n arch/powerpc/cpu/mpc85xx/u-boot.lds | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/arch/powerpc/cpu/mpc85xx/u-boot.lds b/arch/powerpc/cpu/mpc85xx/u-boot.lds\nindex 17a0e631ca3e..48509dbdae01 100644\n--- a/arch/powerpc/cpu/mpc85xx/u-boot.lds\n+++ b/arch/powerpc/cpu/mpc85xx/u-boot.lds\n@@ -75,11 +75,11 @@ SECTIONS\n __ex_table : { *(__ex_table) }\n __stop___ex_table = .;\n \n- . = ALIGN(256);\n+ . = ALIGN(4);\n __init_begin = .;\n .text.init : { *(.text.init) }\n .data.init : { *(.data.init) }\n- . = ALIGN(256);\n+ . = ALIGN(4);\n __init_end = .;\n _end = .;\n \n", "prefixes": [ "1/8" ] }