Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1613421/?format=api
{ "id": 1613421, "url": "http://patchwork.ozlabs.org/api/patches/1613421/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220405131237.405-7-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220405131237.405-7-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-05T13:12:35", "name": "[6/8] powerpc: mpc85xx: Define linker sections in ascending order", "commit_ref": "1245c6e2582cb67db2a84e60a61cfe5a8d77e068", "pull_url": null, "state": "accepted", "archived": false, "hash": "cdaf30ab8614d3b2638ff6ff8903bb084a524fb8", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 87636, "url": "http://patchwork.ozlabs.org/api/users/87636/?format=api", "username": "priyankajain", "first_name": "Priyanka", "last_name": "Jain", "email": "priyanka.jain@nxp.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220405131237.405-7-pali@kernel.org/mbox/", "series": [ { "id": 293592, "url": "http://patchwork.ozlabs.org/api/series/293592/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=293592", "date": "2022-04-05T13:12:33", "name": "powerpc: mpc85xx: Fix and cleanup mpc85xx code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/293592/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1613421/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1613421/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dgB08qXw;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"dgB08qXw\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KXp6f1sKJz9sCD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 5 Apr 2022 23:15:38 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4CF7F83BC7;\n\tTue, 5 Apr 2022 15:14:52 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 13C9C83B20; Tue, 5 Apr 2022 15:14:31 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C7BC883B38\n for <u-boot@lists.denx.de>; Tue, 5 Apr 2022 15:14:18 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 993176187D;\n Tue, 5 Apr 2022 13:14:17 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id DAB8CC385A1;\n Tue, 5 Apr 2022 13:14:16 +0000 (UTC)", "by pali.im (Postfix)\n id 8F15A7B2; Tue, 5 Apr 2022 15:14:16 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1649164457;\n bh=7GeXk/h2vpNwDWCVR06ie7bIHVPDN+RPZij3IMuyiNE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=dgB08qXwyom4Dh8rys/xF94uSYaWCIveJN/YFnhyBSNVOlhJ1XHmoGS2VBTX4cwez\n bUKaL6X8oeyqoRqnXrEHVM/kO3EzTsq+iy8V36WylHdxEakDsKTBlgwo2xbfQ00kcl\n USsBXLwb4w65/bVEnChEZCjWVEdYjhgp+xHSgSZESdGlXgf/6MhcS0wonCsctVw4hW\n rwF1be7/ijGSPpiq3z7cY5CepzZUCBuSTS+Qd4x/C8wUzCXpfO1IvjdMXEtlsCSGCk\n 7i5tvwBS+3dGor27BSQsGhlvDmH9Y/fPgsLprvHLBnA4rw71PshJYkG9qH37sT5CFE\n 0uJYi4l8jlwNQ==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>, Qiang Zhao <qiang.zhao@nxp.com>,\n Shengzhou Liu <Shengzhou.Liu@nxp.com>, Alexander Graf <agraf@csgraf.de>,\n Bin Meng <bmeng.cn@gmail.com>, Wolfgang Denk <wd@denx.de>,\n Sinan Akman <sinan@writeme.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 6/8] powerpc: mpc85xx: Define linker sections in ascending\n order", "Date": "Tue, 5 Apr 2022 15:12:35 +0200", "Message-Id": "<20220405131237.405-7-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220405131237.405-1-pali@kernel.org>", "References": "<20220405131237.405-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "It is too confusing if sections are defined in non-ascending order.\n\nAlso linker has to go backward and then again forward when generating final\nbinary.\n\nTo make future changes easier, define all linker sections in ascending\norder.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 20 +++++++++++---------\n arch/powerpc/cpu/mpc85xx/u-boot.lds | 15 ++++++++-------\n 2 files changed, 19 insertions(+), 16 deletions(-)", "diff": "diff --git a/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds b/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds\nindex 27a5fe6306a3..1b4d1e05a4a3 100644\n--- a/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds\n+++ b/arch/powerpc/cpu/mpc85xx/u-boot-spl.lds\n@@ -18,6 +18,13 @@ PHDRS\n #endif\n SECTIONS\n {\n+/* For ifc, elbc, esdhc, espi, all need the SPL without section .resetvec */\n+#ifdef CONFIG_SYS_MPC85XX_NO_RESETVEC\n+\t.bootpg IMAGE_TEXT_BASE - 0x1000 :\n+\t{\n+\t\tKEEP(*(.bootpg))\n+\t} :text = 0xffff\n+#endif\n \t. = IMAGE_TEXT_BASE;\n \t.text : {\n \t\t*(.text*)\n@@ -67,18 +74,13 @@ SECTIONS\n \t__bss_end = .;\n #endif\n \n-/* For ifc, elbc, esdhc, espi, all need the SPL without section .resetvec */\n-#ifdef CONFIG_SYS_MPC85XX_NO_RESETVEC\n-\t.bootpg ADDR(.text) - 0x1000 :\n-\t{\n-\t\tKEEP(*(.bootpg))\n-\t} :text = 0xffff\n-#else\n+/* For nor and nand is needed the SPL with section .resetvec */\n+#ifndef CONFIG_SYS_MPC85XX_NO_RESETVEC\n #if defined(CONFIG_FSL_IFC) /* Restrict bootpg at 4K boundry for IFC */\n #ifndef BOOT_PAGE_OFFSET\n #define BOOT_PAGE_OFFSET 0x1000\n #endif\n-\t.bootpg ADDR(.text) + BOOT_PAGE_OFFSET :\n+\t.bootpg IMAGE_TEXT_BASE + BOOT_PAGE_OFFSET :\n \t{\n \t\tarch/powerpc/cpu/mpc85xx/start.o (.bootpg)\n \t}\n@@ -90,7 +92,7 @@ SECTIONS\n #else\n #error unknown NAND controller\n #endif\n-\t.resetvec ADDR(.text) + RESET_VECTOR_OFFSET : {\n+\t.resetvec IMAGE_TEXT_BASE + RESET_VECTOR_OFFSET : {\n \t\tKEEP(*(.resetvec))\n \t} = 0xffff\n #endif\ndiff --git a/arch/powerpc/cpu/mpc85xx/u-boot.lds b/arch/powerpc/cpu/mpc85xx/u-boot.lds\nindex 9d0f0d58d804..e1bbee43bcb4 100644\n--- a/arch/powerpc/cpu/mpc85xx/u-boot.lds\n+++ b/arch/powerpc/cpu/mpc85xx/u-boot.lds\n@@ -23,6 +23,13 @@ PHDRS\n SECTIONS\n {\n /* Read-only sections, merged into text segment: */\n+#ifdef CONFIG_SYS_MPC85XX_NO_RESETVEC\n+ .bootpg CONFIG_SYS_TEXT_BASE - 0x1000 :\n+ {\n+ KEEP(arch/powerpc/cpu/mpc85xx/start.o (.bootpg))\n+ } :text = 0xffff\n+ . = CONFIG_SYS_TEXT_BASE;\n+#endif\n .text :\n {\n *(.text*)\n@@ -77,13 +84,7 @@ SECTIONS\n __init_end = .;\n _end = .;\n \n-#ifdef CONFIG_SYS_MPC85XX_NO_RESETVEC\n- .bootpg ADDR(.text) - 0x1000 :\n- {\n- KEEP(arch/powerpc/cpu/mpc85xx/start.o (.bootpg))\n- } :text = 0xffff\n- . = _end;\n-#else\n+#ifndef CONFIG_SYS_MPC85XX_NO_RESETVEC\n .bootpg RESET_VECTOR_ADDRESS - 0xffc :\n {\n arch/powerpc/cpu/mpc85xx/start.o\t(.bootpg)\n", "prefixes": [ "6/8" ] }