Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1612682/?format=api
{ "id": 1612682, "url": "http://patchwork.ozlabs.org/api/patches/1612682/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220402222427.19212-3-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220402222427.19212-3-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-02T22:24:26", "name": "[2/3] ddr: fsl: Allow to compile it without env support", "commit_ref": "78cdaf405311682281d9c5f58dc0b4455e72da61", "pull_url": null, "state": "accepted", "archived": false, "hash": "87580158985f43c3d03e95a0dc1c49033ac8b6bf", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 87636, "url": "http://patchwork.ozlabs.org/api/users/87636/?format=api", "username": "priyankajain", "first_name": "Priyanka", "last_name": "Jain", "email": "priyanka.jain@nxp.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220402222427.19212-3-pali@kernel.org/mbox/", "series": [ { "id": 293278, "url": "http://patchwork.ozlabs.org/api/series/293278/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=293278", "date": "2022-04-02T22:24:24", "name": "powerpc: p2020: Allow to compile it without env support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/293278/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1612682/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1612682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=X5p+Kfjz;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"X5p+Kfjz\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KWBSj3LQcz9sFv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 3 Apr 2022 08:25:41 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EEBA483931;\n\tSun, 3 Apr 2022 00:24:57 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 698E6839BB; Sun, 3 Apr 2022 00:24:54 +0200 (CEST)", "from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 64BF2839D3\n for <u-boot@lists.denx.de>; Sun, 3 Apr 2022 00:24:48 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 1BCF7B80187;\n Sat, 2 Apr 2022 22:24:48 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id B8032C340F3;\n Sat, 2 Apr 2022 22:24:46 +0000 (UTC)", "by pali.im (Postfix)\n id 75A2D1640; Sun, 3 Apr 2022 00:24:44 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,\n T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1648938286;\n bh=6T/3PKG33VJP4DU4d4rvHBqbN6O2yfhXqLjXsZl/oh8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=X5p+KfjzDKTItmpynpOTRzzeKpBq3EDBF9bEnBglvNVErFR/jEaJ0fDO9AGPIAl5q\n rbb8hPDGd3mX3JHTopEDydeugf/E6x5WaT0UPtO1/+MA0M9i/njmH088Qldbm7PjBV\n nDvIrcWIcI2ACdDvPS5shmI/pJd/JNG6u0iX5wHuHr7we5zyoptPII/+QJSiuJtgGw\n /D3tfNyEKF1C+iNembj/ycZOWBGN5nn+YITzEelKijzgdtG7Q5I0FzOxLzkjjNvqp1\n jlvyn4PNjrv0WYkXLQWoJzmjyq4F49SIyITXehS9Xg0N2+RuomSFGZYhAhRFtzEjV8\n BwbQoNvizPtcw==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>,\n\tWolfgang Denk <wd@denx.de>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 2/3] ddr: fsl: Allow to compile it without env support", "Date": "Sun, 3 Apr 2022 00:24:26 +0200", "Message-Id": "<20220402222427.19212-3-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220402222427.19212-1-pali@kernel.org>", "References": "<20220402222427.19212-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "When env support is disabled then usage of env_get_f() generates linker\nerrors. So do not compile env_get_f() when env support is disabled (for\nexample when disabled only in SPL).\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n drivers/ddr/fsl/options.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/ddr/fsl/options.c b/drivers/ddr/fsl/options.c\nindex c000a45f8ea8..9555b9a29d45 100644\n--- a/drivers/ddr/fsl/options.c\n+++ b/drivers/ddr/fsl/options.c\n@@ -761,7 +761,9 @@ unsigned int populate_memctl_options(const common_timing_params_t *common_dimm,\n \t * Extract hwconfig from environment since we have not properly setup\n \t * the environment but need it for ddr config params\n \t */\n+#if CONFIG_IS_ENABLED(ENV_SUPPORT)\n \tif (env_get_f(\"hwconfig\", buf, sizeof(buf)) < 0)\n+#endif\n \t\tbuf[0] = '\\0';\n \n #if defined(CONFIG_SYS_FSL_DDR3) || \\\n@@ -1408,7 +1410,9 @@ int fsl_use_spd(void)\n \t * Extract hwconfig from environment since we have not properly setup\n \t * the environment but need it for ddr config params\n \t */\n+#if CONFIG_IS_ENABLED(ENV_SUPPORT)\n \tif (env_get_f(\"hwconfig\", buf, sizeof(buf)) < 0)\n+#endif\n \t\tbuf[0] = '\\0';\n \n \t/* if hwconfig is not enabled, or \"sdram\" is not defined, use spd */\n", "prefixes": [ "2/3" ] }