Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1612679/?format=api
{ "id": 1612679, "url": "http://patchwork.ozlabs.org/api/patches/1612679/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220402221701.18498-4-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220402221701.18498-4-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-02T22:17:01", "name": "[3/3] mmc: fsl_esdhc_spl: Call mmc_init() before booting from SD card", "commit_ref": "57d527e753bb5efe89fceea341e7d327bf58e312", "pull_url": null, "state": "accepted", "archived": false, "hash": "279fc69d388e21fff4ae189953de5725a1cb2be7", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 87636, "url": "http://patchwork.ozlabs.org/api/users/87636/?format=api", "username": "priyankajain", "first_name": "Priyanka", "last_name": "Jain", "email": "priyanka.jain@nxp.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220402221701.18498-4-pali@kernel.org/mbox/", "series": [ { "id": 293276, "url": "http://patchwork.ozlabs.org/api/series/293276/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=293276", "date": "2022-04-02T22:16:59", "name": "mmc: fsl_esdhc_spl: Fix booting P2020 from SD card", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/293276/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1612679/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1612679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=b74cRqP9;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"b74cRqP9\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KWBJ73WMYz9sFv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 3 Apr 2022 08:18:15 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2041D8395A;\n\tSun, 3 Apr 2022 00:17:35 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id F37DC839B9; Sun, 3 Apr 2022 00:17:29 +0200 (CEST)", "from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4A9DA83988\n for <u-boot@lists.denx.de>; Sun, 3 Apr 2022 00:17:18 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id EA05BB80AC3;\n Sat, 2 Apr 2022 22:17:17 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 86701C340F0;\n Sat, 2 Apr 2022 22:17:16 +0000 (UTC)", "by pali.im (Postfix)\n id 3F780819; Sun, 3 Apr 2022 00:17:16 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1648937836;\n bh=3T7WUaTjBkXsgkC1oP0G4vqLYMvB18IhZscyhVj+pxw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=b74cRqP9FBV/mWQyaK6jPB8+qtyHnwK8XIrneGaXeFdj55UHwSmTVBIXZaFqhP6jt\n 73pSwljcWMGxi9AyIKrsJYLDZAbGsVxDUwJkKFBrkmiN64s7SQ4Ptl7WLuz2OeVItg\n 4H9AyKnvM9to/hLEF+tKeQK2bSnPd156ZE5ke0KBlO2azUy0+y0cK2JGykkiEw22or\n fsIUomIvLUPZfDRlLjWLkPBCDQFL183fZ4OdMPv9jJLtN+RnYR76Vo9i37g7rzkXSl\n 2PnuJA2AHpzeO0kPs8Y9wB+oYCQniN8qc4P1pbAT3GjHb2981IVqtb3QFd4q1MR9Sz\n BObe5jgyxVunA==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>, Peng Fan <peng.fan@nxp.com>,\n Jaehoon Chung <jh80.chung@samsung.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 3/3] mmc: fsl_esdhc_spl: Call mmc_init() before booting from\n SD card", "Date": "Sun, 3 Apr 2022 00:17:01 +0200", "Message-Id": "<20220402221701.18498-4-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220402221701.18498-1-pali@kernel.org>", "References": "<20220402221701.18498-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "If env is stored on SD card then U-Boot SPL automatically calls mmc_init()\nbefore it is going to load proper U-Boot from SD card.\n\nIf env is not stored on SD card then U-Boot SPL fails to read proper U-Boot\nfrom SD card due to missing mmc_init() call.\n\nSo add missing mmc_init() call into fsl_esdhc_spl's mmc_boot() function.\nIt fixes booting from SD card on P2020 boards without env support in SPL.\n\nmmc_init() returns early if card was already initialized, so there is no\nissue with calling this function more times.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n drivers/mmc/fsl_esdhc_spl.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c\nindex b87597a88e1d..0146a231b221 100644\n--- a/drivers/mmc/fsl_esdhc_spl.c\n+++ b/drivers/mmc/fsl_esdhc_spl.c\n@@ -77,6 +77,11 @@ void __noreturn mmc_boot(void)\n \t\thang();\n \t}\n \n+\tif (mmc_init(mmc)) {\n+\t\tputs(\"spl: mmc device init failed!\\n\");\n+\t\thang();\n+\t}\n+\n #ifdef CONFIG_FSL_CORENET\n \toffset = CONFIG_SYS_MMC_U_BOOT_OFFS;\n #else\n", "prefixes": [ "3/3" ] }